From 5059f83d7dccd7221458fca414a0756bb83466a5 Mon Sep 17 00:00:00 2001 From: Bob Arnson Date: Fri, 9 Sep 2022 21:23:26 -0400 Subject: Support bundle updates in WixStdBA. Fixes https://github.com/wixtoolset/issues/issues/6894. --- src/burn/engine/detect.cpp | 2 +- .../Bal/wixstdba/Resources/HyperlinkLargeTheme.xml | 5 + .../wixstdba/Resources/HyperlinkSidebarTheme.xml | 5 + src/ext/Bal/wixstdba/Resources/HyperlinkTheme.wxl | 2 + src/ext/Bal/wixstdba/Resources/HyperlinkTheme.xml | 5 + src/ext/Bal/wixstdba/Resources/RtfLargeTheme.xml | 5 + src/ext/Bal/wixstdba/Resources/RtfTheme.wxl | 2 + src/ext/Bal/wixstdba/Resources/RtfTheme.xml | 5 + .../WixStandardBootstrapperApplication.cpp | 121 ++++++++++++++++++++- src/test/burn/TestBA/TestBA.cs | 2 +- .../burn/TestData/WixStdBaTests/BundleA/Bundle.wxs | 2 + 11 files changed, 152 insertions(+), 4 deletions(-) diff --git a/src/burn/engine/detect.cpp b/src/burn/engine/detect.cpp index 25d184c1..fcd1c966 100644 --- a/src/burn/engine/detect.cpp +++ b/src/burn/engine/detect.cpp @@ -400,7 +400,7 @@ static HRESULT DetectAtomFeedUpdate( APPLICATION_UPDATE_ENTRY* pAppUpdateEntry = &pApupChain->rgEntries[i]; APPLICATION_UPDATE_ENCLOSURE* pEnclosure = pAppUpdateEntry->rgEnclosures; - if (pEnclosure) + if (pEnclosure && pEnclosure->rgbDigest && *pEnclosure->rgbDigest) { hr = StrAllocHexEncode(pEnclosure->rgbDigest, pEnclosure->cbDigest, &sczHash); ExitOnFailure(hr, "Failed to encode hash as string."); diff --git a/src/ext/Bal/wixstdba/Resources/HyperlinkLargeTheme.xml b/src/ext/Bal/wixstdba/Resources/HyperlinkLargeTheme.xml index c018249f..6e7b69ee 100644 --- a/src/ext/Bal/wixstdba/Resources/HyperlinkLargeTheme.xml +++ b/src/ext/Bal/wixstdba/Resources/HyperlinkLargeTheme.xml @@ -12,6 +12,9 @@ + + @@ -29,6 +32,7 @@ #(loc.InstallLicenseLinkText) #(loc.InstallAcceptCheckbox) + + + @@ -30,6 +33,7 @@ #(loc.InstallLicenseLinkText) #(loc.InstallAcceptCheckbox) + + + #(loc.InstallLicenseLinkText) #(loc.InstallAcceptCheckbox) + + + + + #(loc.InstallAcceptCheckbox) +