From 5c7b1a8fa2b02ddd758c0c267f59b7e77b527f62 Mon Sep 17 00:00:00 2001 From: Sean Hall Date: Mon, 6 Dec 2021 16:12:39 -0600 Subject: More VS2022 fixes. Update v4.0 projects to target v4.7.2. Skip all Bal managed host tests for now. Remove ToolsVersion from DTF test projects. Remove Microsoft.NETFramework.ReferenceAssemblies from Directory.Packages.props. --- .../WixToolsetTests.Dtf.Compression.Cab.csproj | 3 ++- .../WixToolsetTests.Dtf.Compression.Zip.csproj | 3 ++- .../WixToolsetTests.Dtf.Compression.csproj | 3 ++- .../WixToolsetTests.Dtf.WindowsInstaller.CustomActions.csproj | 3 ++- .../WixToolsetTests.Dtf.WindowsInstaller.Linq.csproj | 3 ++- .../WixToolsetTests.Dtf.WindowsInstaller.csproj | 3 ++- src/ext/Bal/bal.cmd | 3 ++- src/ext/Bal/test/WixToolsetTest.ManagedHost/DncHostFixture.cs | 1 - src/internal/SetBuildNumber/Directory.Packages.props.pp | 1 - .../TestData/HeatProject/ToolsVersion4Cs/ToolsVersion4Cs.csproj | 2 +- 10 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/dtf/WixToolsetTests.Dtf.Compression.Cab/WixToolsetTests.Dtf.Compression.Cab.csproj b/src/dtf/WixToolsetTests.Dtf.Compression.Cab/WixToolsetTests.Dtf.Compression.Cab.csproj index e215b227..ddcf68ac 100644 --- a/src/dtf/WixToolsetTests.Dtf.Compression.Cab/WixToolsetTests.Dtf.Compression.Cab.csproj +++ b/src/dtf/WixToolsetTests.Dtf.Compression.Cab/WixToolsetTests.Dtf.Compression.Cab.csproj @@ -1,6 +1,6 @@  - + {4544158C-2D63-4146-85FF-62169280144E} Library @@ -9,6 +9,7 @@ {3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} false false + v4.7.2 diff --git a/src/dtf/WixToolsetTests.Dtf.Compression.Zip/WixToolsetTests.Dtf.Compression.Zip.csproj b/src/dtf/WixToolsetTests.Dtf.Compression.Zip/WixToolsetTests.Dtf.Compression.Zip.csproj index c9d7007b..3e7fcb7e 100644 --- a/src/dtf/WixToolsetTests.Dtf.Compression.Zip/WixToolsetTests.Dtf.Compression.Zip.csproj +++ b/src/dtf/WixToolsetTests.Dtf.Compression.Zip/WixToolsetTests.Dtf.Compression.Zip.csproj @@ -1,6 +1,6 @@  - + {328799BB-7B03-4B28-8180-4132211FD07D} Library @@ -9,6 +9,7 @@ {3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} false false + v4.7.2 diff --git a/src/dtf/WixToolsetTests.Dtf.Compression/WixToolsetTests.Dtf.Compression.csproj b/src/dtf/WixToolsetTests.Dtf.Compression/WixToolsetTests.Dtf.Compression.csproj index 55449ee2..83040938 100644 --- a/src/dtf/WixToolsetTests.Dtf.Compression/WixToolsetTests.Dtf.Compression.csproj +++ b/src/dtf/WixToolsetTests.Dtf.Compression/WixToolsetTests.Dtf.Compression.csproj @@ -1,6 +1,6 @@  - + {F045FFC1-05F9-4EA2-9F03-E1CBDB7BC4F9} Library @@ -8,6 +8,7 @@ WixToolsetTests.Dtf.Compression false false + v4.7.2 diff --git a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.CustomActions/WixToolsetTests.Dtf.WindowsInstaller.CustomActions.csproj b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.CustomActions/WixToolsetTests.Dtf.WindowsInstaller.CustomActions.csproj index 911568e7..6a053026 100644 --- a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.CustomActions/WixToolsetTests.Dtf.WindowsInstaller.CustomActions.csproj +++ b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.CustomActions/WixToolsetTests.Dtf.WindowsInstaller.CustomActions.csproj @@ -1,6 +1,6 @@  - + {137D376B-989F-4FEA-9A67-01D8D38CA0DE} Library @@ -9,6 +9,7 @@ {3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} false false + v4.7.2 diff --git a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.Linq/WixToolsetTests.Dtf.WindowsInstaller.Linq.csproj b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.Linq/WixToolsetTests.Dtf.WindowsInstaller.Linq.csproj index 8584f27a..e7fbf28d 100644 --- a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.Linq/WixToolsetTests.Dtf.WindowsInstaller.Linq.csproj +++ b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller.Linq/WixToolsetTests.Dtf.WindowsInstaller.Linq.csproj @@ -1,6 +1,6 @@  - + {4F55F9B8-D8B6-41EB-8796-221B4CD98324} Library @@ -9,6 +9,7 @@ {3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} false false + v4.7.2 diff --git a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller/WixToolsetTests.Dtf.WindowsInstaller.csproj b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller/WixToolsetTests.Dtf.WindowsInstaller.csproj index eb3b9f9c..1fedfe4e 100644 --- a/src/dtf/WixToolsetTests.Dtf.WindowsInstaller/WixToolsetTests.Dtf.WindowsInstaller.csproj +++ b/src/dtf/WixToolsetTests.Dtf.WindowsInstaller/WixToolsetTests.Dtf.WindowsInstaller.csproj @@ -1,6 +1,6 @@  - + {16F5202F-9276-4166-975C-C9654BAF8012} Library @@ -9,6 +9,7 @@ {3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} false false + v4.7.2 diff --git a/src/ext/Bal/bal.cmd b/src/ext/Bal/bal.cmd index 6253c5a7..f8894f76 100644 --- a/src/ext/Bal/bal.cmd +++ b/src/ext/Bal/bal.cmd @@ -26,7 +26,8 @@ msbuild -p:Configuration=%_C% test\examples\examples.proj || exit /b :: Test dotnet test -c %_C% --no-build test\WixToolsetTest.Bal || exit /b -dotnet test -c %_C% --no-build test\WixToolsetTest.ManagedHost || exit /b +:: https://github.com/wixtoolset/issues/issues/6651 +::dotnet test -c %_C% --no-build test\WixToolsetTest.ManagedHost || exit /b :: Pack msbuild -t:Pack -p:Configuration=%_C% -p:NoBuild=true wixext\WixToolset.Bal.wixext.csproj || exit /b diff --git a/src/ext/Bal/test/WixToolsetTest.ManagedHost/DncHostFixture.cs b/src/ext/Bal/test/WixToolsetTest.ManagedHost/DncHostFixture.cs index 11c3918f..8dd5ff11 100644 --- a/src/ext/Bal/test/WixToolsetTest.ManagedHost/DncHostFixture.cs +++ b/src/ext/Bal/test/WixToolsetTest.ManagedHost/DncHostFixture.cs @@ -47,7 +47,6 @@ namespace WixToolsetTest.ManagedHost } } - [Fact(Skip="Fails in MSBuild64 - https://github.com/wixtoolset/issues/issues/6651")] public void CanLoadTrimmedSCDEarliestCoreMBA() { using (var fs = new DisposableFileSystem()) diff --git a/src/internal/SetBuildNumber/Directory.Packages.props.pp b/src/internal/SetBuildNumber/Directory.Packages.props.pp index 65496a36..ff73265c 100644 --- a/src/internal/SetBuildNumber/Directory.Packages.props.pp +++ b/src/internal/SetBuildNumber/Directory.Packages.props.pp @@ -42,7 +42,6 @@ - diff --git a/src/wix/test/WixToolsetTest.Sdk/TestData/HeatProject/ToolsVersion4Cs/ToolsVersion4Cs.csproj b/src/wix/test/WixToolsetTest.Sdk/TestData/HeatProject/ToolsVersion4Cs/ToolsVersion4Cs.csproj index 9c55f7a5..e5723ea2 100644 --- a/src/wix/test/WixToolsetTest.Sdk/TestData/HeatProject/ToolsVersion4Cs/ToolsVersion4Cs.csproj +++ b/src/wix/test/WixToolsetTest.Sdk/TestData/HeatProject/ToolsVersion4Cs/ToolsVersion4Cs.csproj @@ -8,7 +8,7 @@ ToolsVersion4Cs Library ToolsVersion4Cs - v4.0 + v4.7.2 true -- cgit v1.2.3-55-g6feb