From 66360b60b0298c88d32ce2b5e5ce5befa1c09ff8 Mon Sep 17 00:00:00 2001
From: Sean Hall <r.sean.hall@gmail.com>
Date: Fri, 16 Apr 2021 10:21:26 -0500
Subject: Only set the last used folder if the target passed verification.

---
 src/engine/apply.cpp | 37 +++++++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 6 deletions(-)

diff --git a/src/engine/apply.cpp b/src/engine/apply.cpp
index dc9f905b..c39a7746 100644
--- a/src/engine/apply.cpp
+++ b/src/engine/apply.cpp
@@ -26,6 +26,7 @@ typedef struct _BURN_CACHE_CONTEXT
     LPWSTR* rgSearchPaths;
     DWORD cSearchPaths;
     DWORD cSearchPathsMax;
+    LPWSTR sczLastUsedFolderCandidate;
 } BURN_CACHE_CONTEXT;
 
 typedef struct _BURN_CACHE_ACQUIRE_PROGRESS_CONTEXT
@@ -563,6 +564,7 @@ LExit:
         ReleaseNullStr(cacheContext.rgSearchPaths[i]);
     }
     ReleaseMem(cacheContext.rgSearchPaths);
+    ReleaseStr(cacheContext.sczLastUsedFolderCandidate);
 
     UserExperienceOnCacheComplete(pUX, hr);
     return hr;
@@ -840,9 +842,17 @@ static HRESULT ApplyExtractContainer(
     hr = ExtractContainer(pContext, pContainer);
     LogExitOnFailure(hr, MSG_FAILED_EXTRACT_CONTAINER, "Failed to extract payloads from container: %ls to working path: %ls", pContainer->sczId, pContainer->sczUnverifiedPath);
 
+    if (pContext->sczLastUsedFolderCandidate)
+    {
+        // We successfully copied from a source location, set that as the last used source.
+        CacheSetLastUsedSource(pContext->pVariables, pContext->sczLastUsedFolderCandidate, pContainer->sczFilePath);
+    }
+
     pContext->qwSuccessfulCacheProgress += pContainer->qwFileSize;
 
 LExit:
+    ReleaseNullStr(pContext->sczLastUsedFolderCandidate);
+
     return hr;
 }
 
@@ -901,6 +911,12 @@ static HRESULT ApplyLayoutContainer(
         hr = LayoutOrCacheContainerOrPayload(pContext, pContainer, NULL, NULL, TRUE, cTryAgainAttempts, &fRetry);
         if (SUCCEEDED(hr))
         {
+            if (pContext->sczLastUsedFolderCandidate)
+            {
+                // We successfully copied from a source location, set that as the last used source.
+                CacheSetLastUsedSource(pContext->pVariables, pContext->sczLastUsedFolderCandidate, pContainer->sczFilePath);
+            }
+
             pContext->qwSuccessfulCacheProgress += pContainer->qwFileSize;
             break;
         }
@@ -915,11 +931,14 @@ static HRESULT ApplyLayoutContainer(
 
             ++cTryAgainAttempts;
             pContext->qwSuccessfulCacheProgress -= pContainer->qwFileSize;
+            ReleaseNullStr(pContext->sczLastUsedFolderCandidate);
             LogErrorId(hr, MSG_APPLY_RETRYING_PAYLOAD, pContainer->sczId, NULL, NULL);
         }
     }
 
 LExit:
+    ReleaseNullStr(pContext->sczLastUsedFolderCandidate);
+
     return hr;
 }
 
@@ -961,6 +980,12 @@ static HRESULT ApplyProcessPayload(
         hr = LayoutOrCacheContainerOrPayload(pContext, NULL, pPackage, pPayload, FALSE, cTryAgainAttempts, &fRetry);
         if (SUCCEEDED(hr))
         {
+            if (pContext->sczLastUsedFolderCandidate)
+            {
+                // We successfully copied from a source location, set that as the last used source.
+                CacheSetLastUsedSource(pContext->pVariables, pContext->sczLastUsedFolderCandidate, pPayload->sczFilePath);
+            }
+
             pContext->qwSuccessfulCacheProgress += pPayload->qwFileSize;
             break;
         }
@@ -975,11 +1000,14 @@ static HRESULT ApplyProcessPayload(
 
             ++cTryAgainAttempts;
             pContext->qwSuccessfulCacheProgress -= pPayload->qwFileSize;
+            ReleaseNullStr(pContext->sczLastUsedFolderCandidate);
             LogErrorId(hr, MSG_APPLY_RETRYING_PAYLOAD, pPayload->sczKey, NULL, NULL);
         }
     }
 
 LExit:
+    ReleaseNullStr(pContext->sczLastUsedFolderCandidate);
+
     return hr;
 }
 
@@ -1245,12 +1273,9 @@ static HRESULT AcquireContainerOrPayload(
                 hr = CopyPayload(&progress, INVALID_HANDLE_VALUE, pContext->rgSearchPaths[dwChosenSearchPath], wzDestinationPath);
                 // Error handling happens after sending complete message to BA.
 
-                // TODO: wait for verification?
-                // We successfully copied from a source location, set that as the last used source.
-                if (SUCCEEDED(hr))
-                {
-                    CacheSetLastUsedSource(pContext->pVariables, pContext->rgSearchPaths[dwChosenSearchPath], wzRelativePath);
-                }
+                // Store the source path so it can be used as the LastUsedFolder if it passes verification.
+                pContext->sczLastUsedFolderCandidate = pContext->rgSearchPaths[dwChosenSearchPath];
+                pContext->rgSearchPaths[dwChosenSearchPath] = NULL;
             }
 
             fBeginCalled = FALSE;
-- 
cgit v1.2.3-55-g6feb