From 4921664f92bb6bd39ed7fd3dd24d58108973af25 Mon Sep 17 00:00:00 2001 From: Sean Hall Date: Sun, 1 Nov 2020 15:16:07 -0600 Subject: Stop encrypting hidden variables. They were persisted in plaintext, and always had to be decrypted and sent to a separate process to actually be used. --- src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h') diff --git a/src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h b/src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h index becb5be3..003ff635 100644 --- a/src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h +++ b/src/WixToolset.BootstrapperCore.Native/inc/BundleExtensionEngine.h @@ -78,7 +78,6 @@ typedef struct _BUNDLE_EXTENSION_ENGINE_FORMATSTRING_ARGS typedef struct _BUNDLE_EXTENSION_ENGINE_FORMATSTRING_RESULTS { DWORD cbSize; - // The contents of wzOut may be sensitive, should keep encrypted and SecureZeroFree. LPWSTR wzOut; // Should be initialized to the size of wzOut. DWORD cchOut; @@ -93,7 +92,6 @@ typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLENUMERIC_ARGS typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLENUMERIC_RESULTS { DWORD cbSize; - // The contents of llValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroMemory. LONGLONG llValue; } BUNDLE_EXTENSION_ENGINE_GETVARIABLENUMERIC_RESULTS; @@ -106,7 +104,6 @@ typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLESTRING_ARGS typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLESTRING_RESULTS { DWORD cbSize; - // The contents of wzValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroFree. LPWSTR wzValue; // Should be initialized to the size of wzValue. DWORD cchValue; @@ -121,7 +118,6 @@ typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLEVERSION_ARGS typedef struct _BUNDLE_EXTENSION_ENGINE_GETVARIABLEVERSION_RESULTS { DWORD cbSize; - // The contents of wzValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroFree. LPWSTR wzValue; // Should be initialized to the size of wzValue. DWORD cchValue; -- cgit v1.2.3-55-g6feb