From 181aa7076a5bdc4d554d29ec9f96dc923e40a6ed Mon Sep 17 00:00:00 2001
From: Rob Mensching <rob@firegiant.com>
Date: Wed, 1 Jul 2020 00:10:08 -0700
Subject: Make Publish/@Condition truly optional

There is a change to the Core to add the condition back
---
 src/WixToolset.Converters/WixConverter.cs | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

(limited to 'src/WixToolset.Converters')

diff --git a/src/WixToolset.Converters/WixConverter.cs b/src/WixToolset.Converters/WixConverter.cs
index 73538d56..c18b095e 100644
--- a/src/WixToolset.Converters/WixConverter.cs
+++ b/src/WixToolset.Converters/WixConverter.cs
@@ -601,7 +601,16 @@ namespace WixToolset.Converters
             }
         }
 
-        private void ConvertPublishElement(XElement element) => this.ConvertInnerTextToAttribute(element, "Condition");
+        private void ConvertPublishElement(XElement element)
+        {
+            this.ConvertInnerTextToAttribute(element, "Condition");
+
+            var xCondition = element.Attribute("Condition");
+            if (xCondition?.Value == "1")
+            {
+                xCondition.Remove();
+            }
+        }
 
         private void ConvertMultiStringValueElement(XElement element) => this.ConvertInnerTextToAttribute(element, "Value");
 
-- 
cgit v1.2.3-55-g6feb