From ed20ef6dc8caa5d585c1a715ff4ba577687bf291 Mon Sep 17 00:00:00 2001 From: Sean Hall Date: Sat, 27 Feb 2021 16:28:42 -0600 Subject: Add failing tests for package description and packages sharing payloads In Core projects, treat warnings as errors. --- .../Bundles/CreateBootstrapperApplicationManifestCommand.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/WixToolset.Core.Burn') diff --git a/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs b/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs index f85a5b62..a24137f3 100644 --- a/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs +++ b/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs @@ -211,7 +211,9 @@ namespace WixToolset.Core.Burn.Bundles private void WritePayloadInfo(XmlTextWriter writer) { - var payloadSymbols = this.Section.Symbols.OfType(); + // TODO: check v3 - should this be only include package payloads or include all non-UX container payloads? + var payloadSymbols = this.Section.Symbols.OfType() + .Where(p => !String.IsNullOrEmpty(p.PackageRef)); foreach (var payloadSymbol in payloadSymbols) { @@ -219,10 +221,7 @@ namespace WixToolset.Core.Burn.Bundles writer.WriteAttributeString("Payload", payloadSymbol.Id.Id); - if (!String.IsNullOrEmpty(payloadSymbol.PackageRef)) - { - writer.WriteAttributeString("Package", payloadSymbol.PackageRef); - } + writer.WriteAttributeString("Package", payloadSymbol.PackageRef); if (!String.IsNullOrEmpty(payloadSymbol.ContainerRef)) { -- cgit v1.2.3-55-g6feb