From 2c3793752060e50fe2049d860a8ccb4a2475414c Mon Sep 17 00:00:00 2001
From: Rob Mensching <rob@firegiant.com>
Date: Thu, 4 Jun 2020 11:22:16 -0700
Subject: Minor code cleanup

---
 .../Bind/BindDatabaseCommand.cs                    | 34 ++++++++++------------
 .../Bind/ExtractMergeModuleFilesCommand.cs         | 19 ++++++------
 .../Bind/GetFileFacadesFromTransforms.cs           |  2 +-
 3 files changed, 27 insertions(+), 28 deletions(-)

(limited to 'src/WixToolset.Core.WindowsInstaller/Bind')

diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs
index 8887d4eb..a4b9be85 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs
@@ -238,6 +238,14 @@ namespace WixToolset.Core.WindowsInstaller.Bind
 
             // This must occur after all variables and source paths have been resolved.
             List<FileFacade> fileFacades;
+            if (SectionType.Patch == section.Type)
+            {
+                var command = new GetFileFacadesFromTransforms(this.Messaging, this.FileSystemManager, this.SubStorages);
+                command.Execute();
+
+                fileFacades = command.FileFacades;
+            }
+            else
             {
                 var command = new GetFileFacadesCommand(section);
                 command.Execute();
@@ -254,24 +262,12 @@ namespace WixToolset.Core.WindowsInstaller.Bind
                 {
                     containsMergeModules = true;
 
-                    var command = new ExtractMergeModuleFilesCommand(this.Messaging, section, wixMergeTuples);
-                    command.FileFacades = fileFacades;
-                    command.OutputInstallerVersion = installerVersion;
-                    command.SuppressLayout = this.SuppressLayout;
-                    command.IntermediateFolder = this.IntermediateFolder;
+                    var command = new ExtractMergeModuleFilesCommand(this.Messaging, wixMergeTuples, fileFacades, installerVersion, this.IntermediateFolder, this.SuppressLayout);
                     command.Execute();
 
                     fileFacades.AddRange(command.MergeModulesFileFacades);
                 }
             }
-            else if (SectionType.Patch == section.Type)
-            {
-                var command = new GetFileFacadesFromTransforms(this.Messaging, this.FileSystemManager, this.SubStorages);
-                command.Execute();
-                var filesFromTransforms = command.FileFacades;
-
-                fileFacades.AddRange(filesFromTransforms);
-            }
 
             // stop processing if an error previously occurred
             if (this.Messaging.EncounteredError)
@@ -368,11 +364,6 @@ namespace WixToolset.Core.WindowsInstaller.Bind
                     output.SubStorages.Add(storage);
                 }
             }
-            else // we can create instance transforms since Component Guids are set.
-            {
-                var command = new CreateInstanceTransformsCommand(section, output, tableDefinitions, this.BackendHelper);
-                command.Execute();
-            }
 
 #if TODO_FINISH_UPDATE
             // Extended binder extensions can be called now that fields are resolved.
@@ -412,6 +403,13 @@ namespace WixToolset.Core.WindowsInstaller.Bind
 
             this.ValidateComponentGuids(output);
 
+            // We can create instance transforms since Component Guids and Outputs are created.
+            if (output.Type == OutputType.Product)
+            {
+                var command = new CreateInstanceTransformsCommand(section, output, tableDefinitions, this.BackendHelper);
+                command.Execute();
+            }
+
             // Stop processing if an error previously occurred.
             if (this.Messaging.EncounteredError)
             {
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
index 62f7fce3..792a13a9 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
@@ -21,26 +21,27 @@ namespace WixToolset.Core.WindowsInstaller.Bind
     /// </summary>
     internal class ExtractMergeModuleFilesCommand
     {
-        public ExtractMergeModuleFilesCommand(IMessaging messaging, IntermediateSection section, List<WixMergeTuple> wixMergeTuples)
+        public ExtractMergeModuleFilesCommand(IMessaging messaging, IEnumerable<WixMergeTuple> wixMergeTuples, IEnumerable<FileFacade> fileFacades, int installerVersion, string intermediateFolder, bool suppressLayout)
         {
             this.Messaging = messaging;
-            this.Section = section;
             this.WixMergeTuples = wixMergeTuples;
+            this.FileFacades = fileFacades;
+            this.OutputInstallerVersion = installerVersion;
+            this.IntermediateFolder = intermediateFolder;
+            this.SuppressLayout = suppressLayout;
         }
 
         private IMessaging Messaging { get; }
 
-        private IntermediateSection Section { get; }
+        private IEnumerable<WixMergeTuple> WixMergeTuples { get; }
 
-        private List<WixMergeTuple> WixMergeTuples { get; }
+        private IEnumerable<FileFacade> FileFacades { get; }
 
-        public IEnumerable<FileFacade> FileFacades { private get; set; }
+        private int OutputInstallerVersion { get; }
 
-        public int OutputInstallerVersion { private get; set; }
+        private string IntermediateFolder { get; }
 
-        public bool SuppressLayout { private get; set; }
-
-        public string IntermediateFolder { private get; set; }
+        private bool SuppressLayout { get; }
 
         public IEnumerable<FileFacade> MergeModulesFileFacades { get; private set; }
 
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/GetFileFacadesFromTransforms.cs b/src/WixToolset.Core.WindowsInstaller/Bind/GetFileFacadesFromTransforms.cs
index 99bf7101..585bdac0 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/GetFileFacadesFromTransforms.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/GetFileFacadesFromTransforms.cs
@@ -27,7 +27,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
 
         private IEnumerable<SubStorage> SubStorages { get; }
 
-        public IEnumerable<FileFacade> FileFacades { get; private set; }
+        public List<FileFacade> FileFacades { get; private set; }
 
         public void Execute()
         {
-- 
cgit v1.2.3-55-g6feb