From e29c25090e26c8cca52232d580528840d1161b73 Mon Sep 17 00:00:00 2001
From: Bob Arnson <bob@firegiant.com>
Date: Fri, 8 Nov 2019 14:54:15 -0500
Subject: Ensure upgrade action properties are secure.

---
 .../Bind/CreateSpecialPropertiesCommand.cs                            | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'src/WixToolset.Core.WindowsInstaller')

diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs
index 8f769904..0d165f80 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs
@@ -51,6 +51,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind
                 .Select(ca => ca.Id.Id);
             hiddenProperties.UnionWith(hideTargetCustomActions);
 
+            // Ensure upgrade action properties are secure.
+            var actionProperties = this.Section.Tuples.OfType<UpgradeTuple>().Select(u => u.ActionProperty);
+            secureProperties.UnionWith(actionProperties);
+
             if (0 < adminProperties.Count)
             {
                 var tuple = new PropertyTuple(null, new Identifier(AccessModifier.Private, "AdminProperties"));
-- 
cgit v1.2.3-55-g6feb