From 458ff7ce24b33f6df46ae8ef728685c555d55ff7 Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Thu, 7 Jan 2021 15:37:28 -0800 Subject: Remove unnecessary SuppressMessage attributes --- src/WixToolset.Core/CompilerCore.cs | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'src/WixToolset.Core/CompilerCore.cs') diff --git a/src/WixToolset.Core/CompilerCore.cs b/src/WixToolset.Core/CompilerCore.cs index 50b88e51..1f6d6329 100644 --- a/src/WixToolset.Core/CompilerCore.cs +++ b/src/WixToolset.Core/CompilerCore.cs @@ -493,7 +493,6 @@ namespace WixToolset.Core /// The attribute containing the value to get. /// A rule for the contents of the value. If the contents do not follow the rule, an error is thrown. /// The attribute's value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public string GetAttributeValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, EmptyRule emptyRule = EmptyRule.CanBeWhitespaceOnly) { return this.parseHelper.GetAttributeValue(sourceLineNumbers, attribute, emptyRule); @@ -505,7 +504,6 @@ namespace WixToolset.Core /// Source line information about the owner element. /// The attribute containing the value to get. /// A valid code page integer value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public int GetAttributeCodePageValue(SourceLineNumber sourceLineNumbers, XAttribute attribute) { if (null == attribute) @@ -535,7 +533,6 @@ namespace WixToolset.Core /// The attribute containing the value to get. /// Whether to allow Unicode (UCS) or UTF code pages. /// A valid code page integer value or variable expression. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public string GetAttributeLocalizableCodePageValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool onlyAnsi = false) { if (null == attribute) @@ -577,7 +574,6 @@ namespace WixToolset.Core /// The minimum legal value. /// The maximum legal value. /// The attribute's integer value or a special value if an error occurred during conversion. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public int GetAttributeIntegerValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, int minimum, int maximum) { return this.parseHelper.GetAttributeIntegerValue(sourceLineNumbers, attribute, minimum, maximum); @@ -602,7 +598,6 @@ namespace WixToolset.Core /// Source line information about the owner element. /// The attribute containing the value to get. /// Int representation of the date time. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public int GetAttributeDateTimeValue(SourceLineNumber sourceLineNumbers, XAttribute attribute) { if (null == attribute) @@ -748,7 +743,6 @@ namespace WixToolset.Core /// Source line information about the owner element. /// The attribute containing the value to get. /// The attribute's YesNoDefaultType value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public YesNoDefaultType GetAttributeYesNoDefaultValue(SourceLineNumber sourceLineNumbers, XAttribute attribute) { return this.parseHelper.GetAttributeYesNoDefaultValue(sourceLineNumbers, attribute); @@ -793,7 +787,6 @@ namespace WixToolset.Core /// true if wildcards are allowed in the filename. /// true if relative paths are allowed in the filename. /// The attribute's long filename value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public string GetAttributeLongFilename(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool allowWildcards = false, bool allowRelative = false) { return this.parseHelper.GetAttributeLongFilename(sourceLineNumbers, attribute, allowWildcards, allowRelative); @@ -817,7 +810,6 @@ namespace WixToolset.Core /// The attribute containing the value to get. /// Whether HKMU is returned as -1 (true), or treated as an error (false). /// The attribute's RegisitryRootType value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public RegistryRootType? GetAttributeRegistryRootValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool allowHkmu) { return this.parseHelper.GetAttributeRegistryRootValue(sourceLineNumbers, attribute, allowHkmu); @@ -829,7 +821,6 @@ namespace WixToolset.Core /// Source line information about the owner element. /// The attribute containing the value to get. /// The attribute's value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public string GetAttributeBundleVariableValue(SourceLineNumber sourceLineNumbers, XAttribute attribute) { string value = this.GetAttributeValue(sourceLineNumbers, attribute); @@ -852,7 +843,6 @@ namespace WixToolset.Core /// Source line information about the owner element. /// The attribute containing the value to get. /// The attribute's value. - [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")] public string GetAttributeMsiPropertyNameValue(SourceLineNumber sourceLineNumbers, XAttribute attribute) { string value = this.GetAttributeValue(sourceLineNumbers, attribute); @@ -885,7 +875,6 @@ namespace WixToolset.Core /// Three letter or less prefix for generated row identifier. /// Information to hash. /// The generated identifier. - [SuppressMessage("Microsoft.Globalization", "CA1303:DoNotPassLiteralsAsLocalizedParameters", MessageId = "System.InvalidOperationException.#ctor(System.String)")] public Identifier CreateIdentifier(string prefix, params string[] args) { return this.parseHelper.CreateIdentifier(prefix, args); -- cgit v1.2.3-55-g6feb