From 98c54e6a6dbf6dd8944eef12fa43a5cf79a2895d Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Sat, 10 Apr 2021 15:06:58 -0700 Subject: Improve duplicate GUID messages --- src/WixToolset.Data/ErrorMessages.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/WixToolset.Data/ErrorMessages.cs') diff --git a/src/WixToolset.Data/ErrorMessages.cs b/src/WixToolset.Data/ErrorMessages.cs index ffd975e3..86504f60 100644 --- a/src/WixToolset.Data/ErrorMessages.cs +++ b/src/WixToolset.Data/ErrorMessages.cs @@ -278,9 +278,9 @@ namespace WixToolset.Data return Message(null, Ids.DuplicateCommandLineOptionInExtension, "The command line option '{0}' has already been loaded by another Heat extension.", arg); } - public static Message DuplicateComponentGuids(SourceLineNumber sourceLineNumbers, string componentId, string guid) + public static Message DuplicateComponentGuids(SourceLineNumber sourceLineNumbers, string componentId, string guid, string type, string keyPath) { - return Message(sourceLineNumbers, Ids.DuplicateComponentGuids, "Component/@Id='{0}' has a @Guid value '{1}' that duplicates another component in this package. It is recommended to give each component its own unique GUID.", componentId, guid); + return Message(sourceLineNumbers, Ids.DuplicateComponentGuids, "Component/@Id='{0}' with {2} '{3}' has a @Guid value '{1}' that duplicates another component in this package. It is recommended to give each component its own unique GUID.", componentId, guid, type, keyPath); } public static Message DuplicateContextValue(SourceLineNumber sourceLineNumbers, string contextValue) @@ -686,7 +686,7 @@ namespace WixToolset.Data public static Message FinishCabFailed() { - return Message(null, Ids.FinishCabFailed, "An error (E_FAIL) was returned while finalizing a CAB file. This most commonly happens when creating a CAB file with more than 65535 files in it. Either reduce the number of files in your installation package or split your installation package's files into more than one CAB file using the Media element."); + return Message(null, Ids.FinishCabFailed, "An error (E_FAIL) was returned while finalizing a CAB file. This most commonly happens when creating a CAB file with more than 65535 files in it or a compressed size greater than 2GB. Either reduce the number of files in your installation package or split your installation package's files into more than one CAB file using the Media element."); } public static Message FullTempDirectory(string prefix, string directory) -- cgit v1.2.3-55-g6feb