From 5390ea994aa575d0b31abd2d577fc6a278c851c6 Mon Sep 17 00:00:00 2001
From: Rob Mensching <rob@firegiant.com>
Date: Sat, 19 Mar 2022 11:11:58 -0700
Subject: Minor code clean up

---
 .../WindowsInstaller/TableDefinitionCollection.cs  | 47 +++++++++++++++++-----
 1 file changed, 37 insertions(+), 10 deletions(-)

(limited to 'src/api')

diff --git a/src/api/wix/WixToolset.Data/WindowsInstaller/TableDefinitionCollection.cs b/src/api/wix/WixToolset.Data/WindowsInstaller/TableDefinitionCollection.cs
index fcc2b1f6..522e3b84 100644
--- a/src/api/wix/WixToolset.Data/WindowsInstaller/TableDefinitionCollection.cs
+++ b/src/api/wix/WixToolset.Data/WindowsInstaller/TableDefinitionCollection.cs
@@ -14,7 +14,7 @@ namespace WixToolset.Data.WindowsInstaller
     {
         public const string XmlNamespaceUri = "http://wixtoolset.org/schemas/v4/wi/tables";
 
-        private Dictionary<string, TableDefinition> collection;
+        private readonly Dictionary<string, TableDefinition> collection;
 
         /// <summary>
         /// Instantiate a new TableDefinitionCollection class.
@@ -74,59 +74,86 @@ namespace WixToolset.Data.WindowsInstaller
         /// <param name="tableName">Name of table to locate.</param>
         /// <param name="table">Table definition if found.</param>
         /// <returns>True if table definition was found otherwise false.</returns>
-        public bool TryGet(string tableName, out TableDefinition table) => this.collection.TryGetValue(tableName, out table);
+        public bool TryGet(string tableName, out TableDefinition table)
+        {
+            return this.collection.TryGetValue(tableName, out table);
+        }
 
         /// <summary>
         /// Adds a table definition to the collection.
         /// </summary>
         /// <param name="tableDefinition">Table definition to add to the collection.</param>
         /// <value>Indexes by table definition name.</value>
-        public void Add(TableDefinition tableDefinition) => this.collection.Add(tableDefinition.Name, tableDefinition);
+        public void Add(TableDefinition tableDefinition)
+        {
+            this.collection.Add(tableDefinition.Name, tableDefinition);
+        }
 
         /// <summary>
         /// Removes all table definitions from the collection.
         /// </summary>
-        public void Clear() => this.collection.Clear();
+        public void Clear()
+        {
+            this.collection.Clear();
+        }
 
         /// <summary>
         /// Checks if the collection contains a table name.
         /// </summary>
         /// <param name="tableName">The table to check in the collection.</param>
         /// <returns>True if collection contains the table.</returns>
-        public bool Contains(string tableName) => this.collection.ContainsKey(tableName);
+        public bool Contains(string tableName)
+        {
+            return this.collection.ContainsKey(tableName);
+        }
 
         /// <summary>
         /// Checks if the collection contains a table.
         /// </summary>
         /// <param name="table">The table to check in the collection.</param>
         /// <returns>True if collection contains the table.</returns>
-        public bool Contains(TableDefinition table) => this.collection.ContainsKey(table.Name);
+        public bool Contains(TableDefinition table)
+        {
+            return this.collection.ContainsKey(table.Name);
+        }
 
         /// <summary>
         /// Copies table definitions to an arry.
         /// </summary>
         /// <param name="array">Array to copy the table definitions to.</param>
         /// <param name="index">Index in the array to start copying at.</param>
-        public void CopyTo(TableDefinition[] array, int index) => this.collection.Values.CopyTo(array, index);
+        public void CopyTo(TableDefinition[] array, int index)
+        {
+            this.collection.Values.CopyTo(array, index);
+        }
 
         /// <summary>
         /// Removes a table definition from the collection.
         /// </summary>
         /// <param name="table">Table to remove from the collection.</param>
         /// <returns>True if the table definition existed in the collection and was removed.</returns>
-        public bool Remove(TableDefinition table) => this.collection.Remove(table.Name);
+        public bool Remove(TableDefinition table)
+        {
+            return this.collection.Remove(table.Name);
+        }
 
         /// <summary>
         /// Gets enumerator for the collection.
         /// </summary>
         /// <returns>Enumerator for the collection.</returns>
-        public IEnumerator<TableDefinition> GetEnumerator() => this.collection.Values.GetEnumerator();
+        public IEnumerator<TableDefinition> GetEnumerator()
+        {
+            return this.collection.Values.GetEnumerator();
+        }
 
         /// <summary>
         /// Gets the untyped enumerator for the collection.
         /// </summary>
         /// <returns>Untyped enumerator for the collection.</returns>
-        IEnumerator IEnumerable.GetEnumerator() => this.collection.Values.GetEnumerator();
+        IEnumerator IEnumerable.GetEnumerator()
+        {
+            return this.collection.Values.GetEnumerator();
+        }
 
         /// <summary>
         /// Loads a collection of table definitions from a XmlReader in memory.
-- 
cgit v1.2.3-55-g6feb