From 64750a8dd105d89c27613694e1008a454df2a4ee Mon Sep 17 00:00:00 2001
From: Rob Mensching <rob@firegiant.com>
Date: Thu, 10 Mar 2022 14:18:34 -0800
Subject: Remove Unbind as backend function

Unbinding is not a general purpose function as initially imagined.
---
 .../Data/IUnbindContext.cs                         | 24 ----------------------
 src/api/wix/WixToolset.Extensibility/IBackend.cs   | 13 ++++++++----
 .../WixToolset.Extensibility/IBackendFactory.cs    | 11 +++++++++-
 .../WixToolset.Extensibility/IUnbinderExtension.cs | 18 ----------------
 4 files changed, 19 insertions(+), 47 deletions(-)
 delete mode 100644 src/api/wix/WixToolset.Extensibility/Data/IUnbindContext.cs
 delete mode 100644 src/api/wix/WixToolset.Extensibility/IUnbinderExtension.cs

(limited to 'src/api')

diff --git a/src/api/wix/WixToolset.Extensibility/Data/IUnbindContext.cs b/src/api/wix/WixToolset.Extensibility/Data/IUnbindContext.cs
deleted file mode 100644
index 6427422f..00000000
--- a/src/api/wix/WixToolset.Extensibility/Data/IUnbindContext.cs
+++ /dev/null
@@ -1,24 +0,0 @@
-// Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information.
-
-namespace WixToolset.Extensibility.Data
-{
-    using System;
-
-#pragma warning disable 1591 // TODO: add documentation
-    public interface IUnbindContext
-    {
-        IServiceProvider ServiceProvider { get; }
-
-        string ExportBasePath { get; set; }
-
-        string InputFilePath { get; set; }
-
-        string IntermediateFolder { get; set; }
-
-        bool IsAdminImage { get; set; }
-
-        bool SuppressDemodularization { get; set; }
-
-        bool SuppressExtractCabinets { get; set; }
-    }
-}
\ No newline at end of file
diff --git a/src/api/wix/WixToolset.Extensibility/IBackend.cs b/src/api/wix/WixToolset.Extensibility/IBackend.cs
index be8406e4..cb151e05 100644
--- a/src/api/wix/WixToolset.Extensibility/IBackend.cs
+++ b/src/api/wix/WixToolset.Extensibility/IBackend.cs
@@ -2,16 +2,21 @@
 
 namespace WixToolset.Extensibility
 {
-    using WixToolset.Data;
     using WixToolset.Extensibility.Data;
 
-#pragma warning disable 1591 // TODO: add documentation
+    /// <summary>
+    /// Interface all backends implement.
+    /// </summary>
     public interface IBackend
     {
+        /// <summary>
+        /// Bind the intermediate into the final output.
+        /// </summary>
+        /// <param name="context">Bind context.</param>
+        /// <returns>Result of the bind operation.</returns>
         IBindResult Bind(IBindContext context);
 
+#pragma warning disable 1591 // TODO: add documentation
         IDecompileResult Decompile(IDecompileContext context);
-
-        Intermediate Unbind(IUnbindContext context);
     }
 }
diff --git a/src/api/wix/WixToolset.Extensibility/IBackendFactory.cs b/src/api/wix/WixToolset.Extensibility/IBackendFactory.cs
index 99a6704f..7f9ef62d 100644
--- a/src/api/wix/WixToolset.Extensibility/IBackendFactory.cs
+++ b/src/api/wix/WixToolset.Extensibility/IBackendFactory.cs
@@ -2,9 +2,18 @@
 
 namespace WixToolset.Extensibility
 {
-#pragma warning disable 1591 // TODO: add documentation
+    /// <summary>
+    /// Implemented by extensions to create backends.
+    /// </summary>
     public interface IBackendFactory
     {
+        /// <summary>
+        /// Called to find the backend used to produce the requested output type.
+        /// </summary>
+        /// <param name="outputType">Type of output being created.</param>
+        /// <param name="outputPath">Path to the output to create.</param>
+        /// <param name="backend">The backend for the output.</param>
+        /// <returns>True if the backend was created, otherwise false.</returns>
         bool TryCreateBackend(string outputType, string outputPath, out IBackend backend);
     }
 }
diff --git a/src/api/wix/WixToolset.Extensibility/IUnbinderExtension.cs b/src/api/wix/WixToolset.Extensibility/IUnbinderExtension.cs
deleted file mode 100644
index 0e9a2504..00000000
--- a/src/api/wix/WixToolset.Extensibility/IUnbinderExtension.cs
+++ /dev/null
@@ -1,18 +0,0 @@
-// Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information.
-
-namespace WixToolset.Extensibility
-{
-    using System;
-    using WixToolset.Data;
-
-    /// <summary>
-    /// Base class for creating an unbinder extension.
-    /// </summary>
-    public interface IUnbinderExtension
-    {
-        /// <summary>
-        /// Called during the generation of sectionIds for an admin image.
-        /// </summary>
-        void GenerateSectionIds(Intermediate output);
-    }
-}
-- 
cgit v1.2.3-55-g6feb