From b1b90775c9d715ae4193e3faaa419cf163a49bd5 Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Fri, 2 Jan 2026 16:12:01 -0800 Subject: Random fixes --- src/burn/engine/cache.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'src/burn/engine/cache.cpp') diff --git a/src/burn/engine/cache.cpp b/src/burn/engine/cache.cpp index f5df6500..c85a1be4 100644 --- a/src/burn/engine/cache.cpp +++ b/src/burn/engine/cache.cpp @@ -363,6 +363,8 @@ extern "C" HRESULT CacheEnsureBaseWorkingFolder( } pWorkingFolderAcl = reinterpret_cast(MemAlloc(sizeof(SECURITY_ATTRIBUTES), TRUE)); + ExitOnNull(pWorkingFolderAcl, hr, E_OUTOFMEMORY, "Failed to allocate security attributes."); + pWorkingFolderAcl->nLength = sizeof(SECURITY_ATTRIBUTES); pWorkingFolderAcl->lpSecurityDescriptor = psd; pWorkingFolderAcl->bInheritHandle = FALSE; @@ -857,6 +859,7 @@ extern "C" HRESULT CacheSendProgressCallback( case PROGRESS_STOP: hr = HRESULT_FROM_WIN32(ERROR_INSTALL_USEREXIT); ExitOnRootFailure(hr, "UX aborted on download progress."); + break; case PROGRESS_QUIET: // Not actually an error, just an indication to the caller to stop requesting progress. pCallback->pfnProgress = NULL; @@ -866,6 +869,7 @@ extern "C" HRESULT CacheSendProgressCallback( default: hr = E_UNEXPECTED; ExitOnRootFailure(hr, "Invalid return code from progress routine."); + break; } } @@ -1435,8 +1439,8 @@ extern "C" void CacheUninitialize( ReleaseStr(pCache->sczBaseWorkingFolder); ReleaseStr(pCache->sczAcquisitionFolder); ReleaseStr(pCache->sczSourceProcessFolder); - ReleaseStr(pCache->sczBundleEngineWorkingPath) - ReleaseFileHandle(pCache->hBundleEngineWorkingFile) + ReleaseStr(pCache->sczBundleEngineWorkingPath); + ReleaseFileHandle(pCache->hBundleEngineWorkingFile); memset(pCache, 0, sizeof(BURN_CACHE)); } -- cgit v1.2.3-55-g6feb