From 941c47e5a3f57ce9626b447a95740b1444e69343 Mon Sep 17 00:00:00 2001 From: Sean Hall Date: Fri, 16 Apr 2021 09:40:18 -0500 Subject: Detect a package as cached if any of its payloads exist. Detect is supposed to be fast, so it can't fully verify every payload for every package. The engine was wasting its time by trying to verify file sizes without the hash. Even worse, it was making decisions during planning based on that insufficient verification. Contributes to #3640 --- src/engine/exeengine.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/engine/exeengine.cpp') diff --git a/src/engine/exeengine.cpp b/src/engine/exeengine.cpp index cee755e3..46905fc3 100644 --- a/src/engine/exeengine.cpp +++ b/src/engine/exeengine.cpp @@ -269,8 +269,7 @@ extern "C" HRESULT ExeEnginePlanAddPackage( __in BURN_PLAN* pPlan, __in BURN_LOGGING* pLog, __in BURN_VARIABLES* pVariables, - __in_opt HANDLE hCacheEvent, - __in BOOL fPlanPackageCacheRollback + __in_opt HANDLE hCacheEvent ) { HRESULT hr = S_OK; @@ -279,7 +278,7 @@ extern "C" HRESULT ExeEnginePlanAddPackage( // add wait for cache if (hCacheEvent) { - hr = PlanExecuteCacheSyncAndRollback(pPlan, pPackage, hCacheEvent, fPlanPackageCacheRollback); + hr = PlanExecuteCacheSyncAndRollback(pPlan, pPackage, hCacheEvent); ExitOnFailure(hr, "Failed to plan package cache syncpoint"); } -- cgit v1.2.3-55-g6feb