From 44a13ff738267fc7e1147e46cd86df6cdbba7bb3 Mon Sep 17 00:00:00 2001 From: Bob Arnson Date: Mon, 1 Jan 2024 22:07:46 -0500 Subject: Remove warning for `Wix` bundle variable prefix. It's a bit overzealous. Fixes https://github.com/wixtoolset/issues/issues/7579. --- .../WixToolsetTest.Util/UtilExtensionFixture.cs | 47 ---------------------- 1 file changed, 47 deletions(-) (limited to 'src/ext/Util/test/WixToolsetTest.Util/UtilExtensionFixture.cs') diff --git a/src/ext/Util/test/WixToolsetTest.Util/UtilExtensionFixture.cs b/src/ext/Util/test/WixToolsetTest.Util/UtilExtensionFixture.cs index 7cc3a6d4..06e70dcf 100644 --- a/src/ext/Util/test/WixToolsetTest.Util/UtilExtensionFixture.cs +++ b/src/ext/Util/test/WixToolsetTest.Util/UtilExtensionFixture.cs @@ -470,53 +470,6 @@ namespace WixToolsetTest.Util }, results.OrderBy(s => s).ToArray()); } - [Fact] - public void CanBuildBundleWithWarningsWithSearchesUsingDiscouragedVariableNames() - { - var folder = TestData.Get("TestData", "BundleWithSearches"); - var rootFolder = TestData.Get(); - var wixext = Path.Combine(rootFolder, "WixToolset.Util.wixext.dll"); - - using (var fs = new DisposableFileSystem()) - { - var baseFolder = fs.GetFolder(); - var intermediateFolder = Path.Combine(baseFolder, "obj"); - var bundlePath = Path.Combine(baseFolder, @"bin\test.exe"); - var baFolderPath = Path.Combine(baseFolder, "ba"); - var extractFolderPath = Path.Combine(baseFolder, "extract"); - - var result = WixRunner.Execute(false, new[] - { - "build", - Path.Combine(folder, "BundleUsingDiscouragedVariableNames.wxs"), - "-ext", wixext, - "-loc", Path.Combine(folder, "Bundle.en-us.wxl"), - "-bindpath", Path.Combine(folder, "data"), - "-intermediateFolder", intermediateFolder, - "-o", bundlePath, - }); - - var messages = result.Messages.Select(m => m.ToString()).ToList(); - messages.Sort(); - - WixAssert.CompareLineByLine(new[] - { - "The *Search/@Variable attribute's value begins with the reserved prefix 'Wix'. Some prefixes are reserved by the WiX toolset for well-known values. Change your attribute's value to not begin with the same prefix.", - }, messages.ToArray()); - - result.AssertSuccess(); - - var extractResult = BundleExtractor.ExtractBAContainer(null, bundlePath, baFolderPath, extractFolderPath); - extractResult.AssertSuccess(); - - var utilSearches = extractResult.GetManifestTestXmlLines("/burn:BurnManifest/*[self::burn:ExtensionSearch or self::burn:DirectorySearch or self::burn:FileSearch or self::burn:MsiProductSearch or self::burn:RegistrySearch]"); - WixAssert.CompareLineByLine(new[] - { - @"", - }, utilSearches); - } - } - [Fact] public void CannotBuildBundleWithSearchesUsingBuiltinVariableNames() { -- cgit v1.2.3-55-g6feb