From e35ee2e8c58bf55da5f3d04915d588fb04d6809d Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Thu, 7 Jan 2021 23:12:49 -0800 Subject: Report invalid command line arguments as errors Fixes wixtoolset/issues#6313 --- src/test/WixToolsetTest.CoreIntegration/BadInputFixture.cs | 3 +-- src/test/WixToolsetTest.CoreIntegration/CustomTableFixture.cs | 2 +- src/test/WixToolsetTest.CoreIntegration/DecompileFixture.cs | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) (limited to 'src/test/WixToolsetTest.CoreIntegration') diff --git a/src/test/WixToolsetTest.CoreIntegration/BadInputFixture.cs b/src/test/WixToolsetTest.CoreIntegration/BadInputFixture.cs index c5168856..62ffe1eb 100644 --- a/src/test/WixToolsetTest.CoreIntegration/BadInputFixture.cs +++ b/src/test/WixToolsetTest.CoreIntegration/BadInputFixture.cs @@ -48,7 +48,7 @@ namespace WixToolsetTest.CoreIntegration } } - [Fact(Skip = "Test demonstrates failure")] + [Fact] public void CantBuildSingleExeBundleWithInvalidArgument() { var folder = TestData.Get(@"TestData"); @@ -72,7 +72,6 @@ namespace WixToolsetTest.CoreIntegration }); Assert.NotEqual(0, result.ExitCode); - Assert.False(File.Exists(exePath)); } } diff --git a/src/test/WixToolsetTest.CoreIntegration/CustomTableFixture.cs b/src/test/WixToolsetTest.CoreIntegration/CustomTableFixture.cs index 4a5cf544..3ee88640 100644 --- a/src/test/WixToolsetTest.CoreIntegration/CustomTableFixture.cs +++ b/src/test/WixToolsetTest.CoreIntegration/CustomTableFixture.cs @@ -216,7 +216,7 @@ namespace WixToolsetTest.CoreIntegration result.AssertSuccess(); Assert.True(File.Exists(msiPath)); - result = WixRunner.Execute(new[] + result = WixRunner.Execute(false, new[] { "decompile", msiPath, "-intermediateFolder", intermediateFolder, diff --git a/src/test/WixToolsetTest.CoreIntegration/DecompileFixture.cs b/src/test/WixToolsetTest.CoreIntegration/DecompileFixture.cs index b07f5bda..924337ba 100644 --- a/src/test/WixToolsetTest.CoreIntegration/DecompileFixture.cs +++ b/src/test/WixToolsetTest.CoreIntegration/DecompileFixture.cs @@ -20,7 +20,7 @@ namespace WixToolsetTest.CoreIntegration var intermediateFolder = fs.GetFolder(); var outputPath = Path.Combine(intermediateFolder, @"Actual.wxs"); - var result = WixRunner.Execute(new[] + var result = WixRunner.Execute(false, new[] { "decompile", Path.Combine(folder, msiName), -- cgit v1.2.3-55-g6feb