From eda11c7eb726da970de68c5b353f946d1da0a7a3 Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Tue, 24 Dec 2024 18:11:55 -0800 Subject: Group creation and update PR nits and feedback fixes --- src/test/burn/WixTestTools/RuntimeFactAttribute.cs | 9 +++++---- src/test/burn/WixTestTools/UserGroupVerifier.cs | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) (limited to 'src/test') diff --git a/src/test/burn/WixTestTools/RuntimeFactAttribute.cs b/src/test/burn/WixTestTools/RuntimeFactAttribute.cs index 76004f26..d7f56f70 100644 --- a/src/test/burn/WixTestTools/RuntimeFactAttribute.cs +++ b/src/test/burn/WixTestTools/RuntimeFactAttribute.cs @@ -10,6 +10,8 @@ namespace WixTestTools public class RuntimeFactAttribute : SkippableFactAttribute { + private bool domainRequired; + const string RequiredEnvironmentVariableName = "RuntimeTestsEnabled"; const string RequiredDomainEnvironmentVariableName = "RuntimeDomainTestsEnabled"; @@ -47,17 +49,16 @@ namespace WixTestTools RuntimeDomainTestsEnabled = Boolean.TryParse(domainTestsEnabledString, out var domainTestsEnabled) && domainTestsEnabled; } - private bool _domainRequired; public bool DomainRequired { get { - return _domainRequired; + return this.domainRequired; } set { - _domainRequired = value; - if (_domainRequired && String.IsNullOrEmpty(this.Skip) && (!RunningInDomain || !RuntimeDomainTestsEnabled)) + this.domainRequired = value; + if (this.domainRequired && String.IsNullOrEmpty(this.Skip) && (!RunningInDomain || !RuntimeDomainTestsEnabled)) { this.Skip = $"These tests require the test host to be running as a domain member ({(RunningInDomain ? "passed" : "failed")}). These tests affect both MACHINE AND DOMAIN state. To accept the consequences, set the {RequiredDomainEnvironmentVariableName} environment variable to true ({(RuntimeDomainTestsEnabled ? "passed" : "failed")})."; } diff --git a/src/test/burn/WixTestTools/UserGroupVerifier.cs b/src/test/burn/WixTestTools/UserGroupVerifier.cs index 52a1a6bf..8c2da46e 100644 --- a/src/test/burn/WixTestTools/UserGroupVerifier.cs +++ b/src/test/burn/WixTestTools/UserGroupVerifier.cs @@ -29,7 +29,7 @@ namespace WixTestTools } /// - /// Deletes a local gorup from the machine + /// Deletes a local group from the machine /// /// group name to delete /// Has to be run as an Admin -- cgit v1.2.3-55-g6feb