From 0031d5e8f859b342ac9860b7055bb738b6303ec0 Mon Sep 17 00:00:00 2001
From: Sean Hall <r.sean.hall@gmail.com>
Date: Sat, 31 Oct 2020 19:54:44 -0500
Subject: Add test for Overridable.

Also, reenable MBA test.
---
 src/test/WixToolsetTest.Bal/BalExtensionFixture.cs | 36 ++++++++++++++++++++--
 .../WixToolsetTest.Bal/TestData/MBA/Bundle.wxs     |  2 +-
 .../TestData/Overridable/Bundle.wxs                | 13 ++++++++
 .../WixToolsetTest.Bal/WixToolsetTest.Bal.csproj   |  2 +-
 4 files changed, 49 insertions(+), 4 deletions(-)
 create mode 100644 src/test/WixToolsetTest.Bal/TestData/Overridable/Bundle.wxs

(limited to 'src')

diff --git a/src/test/WixToolsetTest.Bal/BalExtensionFixture.cs b/src/test/WixToolsetTest.Bal/BalExtensionFixture.cs
index a19013f5..277a941a 100644
--- a/src/test/WixToolsetTest.Bal/BalExtensionFixture.cs
+++ b/src/test/WixToolsetTest.Bal/BalExtensionFixture.cs
@@ -45,6 +45,39 @@ namespace WixToolsetTest.Bal
             }
         }
 
+        [Fact]
+        public void CanBuildUsingOverridable()
+        {
+            using (var fs = new DisposableFileSystem())
+            {
+                var baseFolder = fs.GetFolder();
+                var bundleFile = Path.Combine(baseFolder, "bin", "test.exe");
+                var bundleSourceFolder = TestData.Get(@"TestData\Overridable");
+                var intermediateFolder = Path.Combine(baseFolder, "obj");
+                var baFolderPath = Path.Combine(baseFolder, "ba");
+                var extractFolderPath = Path.Combine(baseFolder, "extract");
+
+                var compileResult = WixRunner.Execute(new[]
+                {
+                    "build",
+                    Path.Combine(bundleSourceFolder, "Bundle.wxs"),
+                    "-ext", TestData.Get(@"WixToolset.Bal.wixext.dll"),
+                    "-intermediateFolder", intermediateFolder,
+                    "-o", bundleFile,
+                });
+                compileResult.AssertSuccess();
+
+                Assert.True(File.Exists(bundleFile));
+
+                var extractResult = BundleExtractor.ExtractBAContainer(null, bundleFile, baFolderPath, extractFolderPath);
+                extractResult.AssertSuccess();
+
+                var balOverridableVariables = extractResult.SelectBADataNodes("/ba:BootstrapperApplicationData/ba:WixStdbaOverridableVariable");
+                var balOverridableVariable = (XmlNode)Assert.Single(balOverridableVariables);
+                Assert.Equal("<WixStdbaOverridableVariable Name='Test1' />", balOverridableVariable.GetTestXml());
+            }
+        }
+
         [Fact]
         public void CanBuildUsingWixStdBa()
         {
@@ -69,7 +102,7 @@ namespace WixToolsetTest.Bal
             }
         }
 
-        [Fact(Skip = "Skip test until cycle with Netfx.wixext and this repo is resolved")]
+        [Fact]
         public void CantBuildUsingMBAWithNoPrereqs()
         {
             using (var fs = new DisposableFileSystem())
@@ -84,7 +117,6 @@ namespace WixToolsetTest.Bal
                     "build",
                     Path.Combine(bundleSourceFolder, "Bundle.wxs"),
                     "-ext", TestData.Get(@"WixToolset.Bal.wixext.dll"),
-                    "-ext", TestData.Get(@"WixToolset.NetFx.wixext.dll"),
                     "-intermediateFolder", intermediateFolder,
                     "-o", bundleFile,
                 });
diff --git a/src/test/WixToolsetTest.Bal/TestData/MBA/Bundle.wxs b/src/test/WixToolsetTest.Bal/TestData/MBA/Bundle.wxs
index b3538c68..e6f1d566 100644
--- a/src/test/WixToolsetTest.Bal/TestData/MBA/Bundle.wxs
+++ b/src/test/WixToolsetTest.Bal/TestData/MBA/Bundle.wxs
@@ -4,7 +4,7 @@
     <Bundle Name="WixStdBa" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="75D5D534-E177-4689-AAE9-CAC1C39002C2">
         <BootstrapperApplicationRef Id="ManagedBootstrapperApplicationHost" />
         <Chain>
-            <PackageGroupRef Id="NetFx462Redist" />
+            <ExePackage SourceFile="runtimes\win-x86\native\wixnative.exe" />
         </Chain>
     </Bundle>
 </Wix>
diff --git a/src/test/WixToolsetTest.Bal/TestData/Overridable/Bundle.wxs b/src/test/WixToolsetTest.Bal/TestData/Overridable/Bundle.wxs
new file mode 100644
index 00000000..3ac3df60
--- /dev/null
+++ b/src/test/WixToolsetTest.Bal/TestData/Overridable/Bundle.wxs
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"
+     xmlns:bal="http://wixtoolset.org/schemas/v4/wxs/bal">
+    <Bundle Name="WixStdBa" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="75D5D534-E177-4689-AAE9-CAC1C39002C2">
+        <BootstrapperApplicationRef Id="WixStandardBootstrapperApplication.HyperlinkLicense">
+            <bal:WixStandardBootstrapperApplication LicenseUrl="http://wixtoolset.org/about/license/" />
+        </BootstrapperApplicationRef>
+        <Variable Name="Test1" bal:Overridable="yes" />
+        <Chain>
+            <ExePackage SourceFile="runtimes\win-x86\native\wixnative.exe" />
+        </Chain>
+    </Bundle>
+</Wix>
diff --git a/src/test/WixToolsetTest.Bal/WixToolsetTest.Bal.csproj b/src/test/WixToolsetTest.Bal/WixToolsetTest.Bal.csproj
index 3c742604..199b82e2 100644
--- a/src/test/WixToolsetTest.Bal/WixToolsetTest.Bal.csproj
+++ b/src/test/WixToolsetTest.Bal/WixToolsetTest.Bal.csproj
@@ -13,6 +13,7 @@
 
   <ItemGroup>
     <Content Include="TestData\MBA\Bundle.wxs" CopyToOutputDirectory="PreserveNewest" />
+    <Content Include="TestData\Overridable\Bundle.wxs" CopyToOutputDirectory="PreserveNewest" />
     <Content Include="TestData\WixStdBa\Bundle.wxs" CopyToOutputDirectory="PreserveNewest" />
     <Content Include="TestData\WixStdBa\Data\test.msi" CopyToOutputDirectory="PreserveNewest" />
     <Content Include="TestData\WixStdBa\DisplayInternalUIConditionBundle.wxs" CopyToOutputDirectory="PreserveNewest" />
@@ -32,7 +33,6 @@
     <PackageReference Include="WixToolset.Core.WindowsInstaller" Version="4.0.*" />
     <PackageReference Include="WixToolset.Core.TestPackage" Version="4.0.*" />
     <PackageReference Include="WixToolset.Data" Version="4.0.*" />
-    <!-- <PackageReference Include="WixToolset.NetFx.wixext" Version="4.0.*" /> -->
   </ItemGroup>
 
   <ItemGroup>
-- 
cgit v1.2.3-55-g6feb