From 3354cdba91ed4e67a00a23c4e556c9672b2b1f45 Mon Sep 17 00:00:00 2001 From: Bob Arnson Date: Sun, 16 Feb 2025 23:15:41 -0500 Subject: Convert WixToolsetTest.Sdk to MSTest.*** ***Does not include a full conversion to traversal projects. The wix segment already uses traversal projects extensively so there isn't a significant per win, especially compared to the effort required...but MSTest's method-level parallelism cuts test run time in half (~60->~30). --- .../SetBuildNumber/Directory.Packages.props.pp | 2 +- .../WixBuildFinalize/WixBuildFinalize.proj | 2 +- .../WixInternal.MSTestSupport/WixAssert.cs | 10 + src/internal/internal.sln | 2 - src/testresultfilelist.txt | 11 +- src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs | 212 +++++++++++---------- .../WixToolsetTest.Sdk/MsbuildValidationFixture.cs | 21 +- src/wix/test/WixToolsetTest.Sdk/README.md | 2 +- .../WixToolsetTest.Sdk/WixToolsetTest.Sdk.csproj | 8 +- src/wix/wix.cmd | 4 +- 10 files changed, 138 insertions(+), 136 deletions(-) (limited to 'src') diff --git a/src/internal/SetBuildNumber/Directory.Packages.props.pp b/src/internal/SetBuildNumber/Directory.Packages.props.pp index 18a9b5eb..8204df97 100644 --- a/src/internal/SetBuildNumber/Directory.Packages.props.pp +++ b/src/internal/SetBuildNumber/Directory.Packages.props.pp @@ -100,7 +100,7 @@ - + diff --git a/src/internal/WixBuildFinalize/WixBuildFinalize.proj b/src/internal/WixBuildFinalize/WixBuildFinalize.proj index bd68a471..1025fad1 100644 --- a/src/internal/WixBuildFinalize/WixBuildFinalize.proj +++ b/src/internal/WixBuildFinalize/WixBuildFinalize.proj @@ -6,7 +6,7 @@ net472 - + (IEnumerable collection, Func predicate) + { + Assert.IsTrue(collection.Any(predicate)); + } + + public static void NotEmpty(IEnumerable collection) + { + Assert.IsTrue(collection.Count() > 0); + } + public static void Empty(IEnumerable collection) { Assert.AreEqual(0, collection.Count()); diff --git a/src/internal/internal.sln b/src/internal/internal.sln index 5514e543..8a326615 100644 --- a/src/internal/internal.sln +++ b/src/internal/internal.sln @@ -9,8 +9,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WixInternal.TestSupport.Nat EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WixInternal.BaseBuildTasks.Sources", "WixInternal.BaseBuildTasks.Sources\WixInternal.BaseBuildTasks.Sources.csproj", "{6B654490-AB0D-4F94-B564-DAA80044D5A3}" EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WixInternal.XunitTestSupport", "WixInternal.XunitTestSupport\WixInternal.XunitTestSupport.csproj", "{AF7C4730-583B-46F8-9BB6-16D1F0330932}" -EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WixInternal.MSTestSupport", "WixInternal.MSTestSupport\WixInternal.MSTestSupport.csproj", "{E70898F2-8D08-4FCE-9CFF-EF1792FCA2E2}" EndProject Global diff --git a/src/testresultfilelist.txt b/src/testresultfilelist.txt index 9e156730..71f35d6b 100644 --- a/src/testresultfilelist.txt +++ b/src/testresultfilelist.txt @@ -1,10 +1 @@ -build/logs/TestResults/api.trx -build/logs/TestResults/burn.trx -build/logs/TestResults/libs.trx -build/logs/TestResults/tools.trx -build/logs/TestResults/wix.trx -build/logs/TestResults/WixToolsetTest.BurnE2E.trx -build/logs/TestResults/util.wixext.trx -build/logs/TestResults/bal.wixext.trx -build/logs/TestResults/WixToolsetTest.MsiE2E.trx -build/logs/TestResults/WixToolsetTest.WixE2ETests.trx \ No newline at end of file +build/logs/TestResults/*.trx diff --git a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs index 5d2d1b2c..a14c8e5b 100644 --- a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs +++ b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs @@ -6,18 +6,19 @@ namespace WixToolsetTest.Sdk using System.Collections.Generic; using System.IO; using System.Linq; - using WixInternal.TestSupport; - using Xunit; + using Microsoft.VisualStudio.TestTools.UnitTesting; + using WixInternal.MSTestSupport; + [TestClass] public class MsbuildFixture { public static readonly string WixMsbuildPath = Path.Combine(Path.GetDirectoryName(new Uri(typeof(MsbuildFixture).Assembly.CodeBase).LocalPath), "..", "..", "..", "publish", "WixToolset.Sdk"); public static readonly string WixPropsPath = Path.Combine(WixMsbuildPath, "Sdk", "Sdk.props"); - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleBundle(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "SimpleMsiPackage"); @@ -57,10 +58,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildUncompressedBundle(BuildSystem buildSystem) { var sourceFolder = TestData.Get("TestData", "SimpleMsiPackage"); @@ -100,10 +101,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleMergeModule(BuildSystem buildSystem) { var sourceFolder = TestData.Get("TestData", "MergeModule", "SimpleMergeModule"); @@ -135,10 +136,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleMsiPackage(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\SimpleMsiPackage\MsiPackage"); @@ -160,7 +161,7 @@ namespace WixToolsetTest.Sdk result.AssertSuccess(); var platformSwitches = result.Output.Where(line => line.Contains("-platform x86")); - Assert.Single(platformSwitches); + WixAssert.Single(platformSwitches); var warnings = result.Output.Where(line => line.Contains(": warning")).Select(line => ExtractWarningFromMessage(line, baseFolder)).ToArray(); WixAssert.CompareLineByLine(new[] @@ -193,10 +194,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleMsiPackageWithMergeModule(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "MergeModule"); @@ -229,10 +230,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildMsiPackageWithBindVariables(BuildSystem buildSystem) { var sourceFolder = TestData.Get("TestData", "MsiPackageWithBindVariables"); @@ -276,10 +277,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildWithDefaultAndExplicitlyFullWixpdbs(BuildSystem buildSystem) { var expectedOutputs = new[] @@ -293,10 +294,10 @@ namespace WixToolsetTest.Sdk this.AssertWixpdb(buildSystem, "Full", expectedOutputs); } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildWithNoWixpdb(BuildSystem buildSystem) { this.AssertWixpdb(buildSystem, "NONE", new[] @@ -306,10 +307,10 @@ namespace WixToolsetTest.Sdk }); } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildWithWixpdbToDifferentFolder(BuildSystem buildSystem) { var expectedOutputFiles = new[] @@ -346,10 +347,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuild64BitMsiPackage(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\SimpleMsiPackage\MsiPackage"); @@ -369,7 +370,7 @@ namespace WixToolsetTest.Sdk result.AssertSuccess(); var platformSwitches = result.Output.Where(line => line.Contains("-platform x64")); - Assert.Single(platformSwitches); + WixAssert.Single(platformSwitches); var paths = Directory.EnumerateFiles(binFolder, @"*.*", SearchOption.AllDirectories) .Select(s => s.Substring(baseFolder.Length + 1)) @@ -384,10 +385,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildMsiPackageWithIceSuppressions(BuildSystem buildSystem) { var sourceFolder = TestData.Get("TestData", "MsiPackageWithIceError", "MsiPackage"); @@ -408,10 +409,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleMsiPackageWithWarningSuppressions(BuildSystem buildSystem) { var sourceFolder = TestData.Get("TestData", "SimpleMsiPackage", "MsiPackage"); @@ -435,10 +436,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSingleCultureWithFallbackMsiPackage(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "SingleCultureWithFallbackMsiPackage"); @@ -469,10 +470,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildMultiCulturalMsiPackage(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "MultiCulturalMsiPackage"); @@ -514,10 +515,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleMsiPackageAsWixipl(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\SimpleMsiPackage\MsiPackage"); @@ -537,7 +538,7 @@ namespace WixToolsetTest.Sdk result.AssertSuccess(); var wixBuildCommands = MsbuildUtilities.GetToolCommandLines(result, "wix", "build", buildSystem); - Assert.Single(wixBuildCommands); + WixAssert.Single(wixBuildCommands); var path = Directory.EnumerateFiles(binFolder, @"*.*", SearchOption.AllDirectories) .Select(s => s.Substring(baseFolder.Length + 1)) @@ -546,10 +547,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildSimpleWixlib(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "Wixlib", "SimpleWixlib"); @@ -568,7 +569,7 @@ namespace WixToolsetTest.Sdk result.AssertSuccess(); var wixBuildCommands = MsbuildUtilities.GetToolCommandLines(result, "wix", "build", buildSystem); - Assert.Single(wixBuildCommands); + WixAssert.Single(wixBuildCommands); var path = Directory.EnumerateFiles(binFolder, @"*.*", SearchOption.AllDirectories) .Select(s => s.Substring(baseFolder.Length + 1)) @@ -577,10 +578,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildPackageIncludingSimpleWixlib(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "Wixlib"); @@ -610,10 +611,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildAndCleanSimpleMsiPackage(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\SimpleMsiPackage\MsiPackage"); @@ -636,7 +637,7 @@ namespace WixToolsetTest.Sdk .Select(s => s.Substring(baseFolder.Length + 1)) .OrderBy(s => s) .ToArray(); - Assert.NotEmpty(createdPaths); + WixAssert.NotEmpty(createdPaths); // Clean result = MsbuildUtilities.BuildProject(buildSystem, projectPath, new[] @@ -670,10 +671,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildMultiTargetingWixlibUsingRids(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "MultiTargetingWixlib"); @@ -708,10 +709,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildMultiTargetingWixlibUsingRidsWithReleaseAndDebug(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "MultiTargetingWixlib"); @@ -750,10 +751,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CannotBuildMultiTargetingWixlibUsingExplicitSubsetOfTfmAndRid(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "MultiTargetingWixlib"); @@ -779,10 +780,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildWithWarningWhenExtensionIsMissing(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "WixlibMissingExtension"); @@ -818,10 +819,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CanBuildPackageWithComma(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData", "PackageWith,Comma"); @@ -852,10 +853,11 @@ namespace WixToolsetTest.Sdk } } - [Theory(Skip = "Depends on creating broken publish which is not supported at this time")] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [Ignore("Depends on creating broken publish which is not supported at this time")] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void ReportsInnerExceptionForUnexpectedExceptions(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\SimpleMsiPackage\MsiPackage"); @@ -871,10 +873,10 @@ namespace WixToolsetTest.Sdk { MsbuildUtilities.GetQuotedPropertySwitch(buildSystem, "WixToolDir", Path.Combine(MsbuildFixture.WixMsbuildPath, "broken", "net461")), }); - Assert.Equal(1, result.ExitCode); + Assert.AreEqual(1, result.ExitCode); var expectedMessage = "System.PlatformNotSupportedException: Could not find platform specific 'wixnative.exe' ---> System.IO.FileNotFoundException: Could not find internal piece of WiX Toolset from"; - Assert.Contains(result.Output, m => m.Contains(expectedMessage)); + WixAssert.Any(result.Output, m => m.Contains(expectedMessage)); } } diff --git a/src/wix/test/WixToolsetTest.Sdk/MsbuildValidationFixture.cs b/src/wix/test/WixToolsetTest.Sdk/MsbuildValidationFixture.cs index 82e72e6b..7fc06b40 100644 --- a/src/wix/test/WixToolsetTest.Sdk/MsbuildValidationFixture.cs +++ b/src/wix/test/WixToolsetTest.Sdk/MsbuildValidationFixture.cs @@ -5,8 +5,8 @@ namespace WixToolsetTest.Sdk using System; using System.IO; using System.Linq; - using WixInternal.TestSupport; - using Xunit; + using Microsoft.VisualStudio.TestTools.UnitTesting; + using WixInternal.MSTestSupport; // When these tests are run repeatedly, they will expose an issue // in the Windows Installer where ICE validations will occasionally @@ -17,12 +17,13 @@ namespace WixToolsetTest.Sdk // around for manual testing. Uncomment or define the following // line to do so. #if DISABLE_VALIDATION_TESTS_DUE_TO_WINDOWS_INSTALLER_INCONSISTENCIES + [TestClass] public class MsbuildValidationFixture { - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CannotBuildMsiPackageWithIceIssues(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\MsiPackageWithIceError\MsiPackage"); @@ -59,10 +60,10 @@ namespace WixToolsetTest.Sdk } } - [Theory] - [InlineData(BuildSystem.DotNetCoreSdk)] - [InlineData(BuildSystem.MSBuild)] - [InlineData(BuildSystem.MSBuild64)] + [TestMethod] + [DataRow(BuildSystem.DotNetCoreSdk)] + [DataRow(BuildSystem.MSBuild)] + [DataRow(BuildSystem.MSBuild64)] public void CannotBuildMsiPackageWithIceWarningsAsErrors(BuildSystem buildSystem) { var sourceFolder = TestData.Get(@"TestData\MsiPackageWithIceError\MsiPackage"); diff --git a/src/wix/test/WixToolsetTest.Sdk/README.md b/src/wix/test/WixToolsetTest.Sdk/README.md index daf85e5a..d593cca7 100644 --- a/src/wix/test/WixToolsetTest.Sdk/README.md +++ b/src/wix/test/WixToolsetTest.Sdk/README.md @@ -2,4 +2,4 @@ In order to properly test wix.targets, all of the supported architectures for WixToolset.BuildTasks need to be available in the layout used in the Nuget package. Making this happen on every build for the solution takes too long, so this project relies on manually running devbuild.cmd to publish everything before the tests can be run. -devbuild.cmd needs to be ran again every time changes are made in other projects, including the targets themselves. \ No newline at end of file +devbuild.cmd needs to be run again every time changes are made in other projects, including the targets themselves. \ No newline at end of file diff --git a/src/wix/test/WixToolsetTest.Sdk/WixToolsetTest.Sdk.csproj b/src/wix/test/WixToolsetTest.Sdk/WixToolsetTest.Sdk.csproj index 7fe39da3..5a617fb1 100644 --- a/src/wix/test/WixToolsetTest.Sdk/WixToolsetTest.Sdk.csproj +++ b/src/wix/test/WixToolsetTest.Sdk/WixToolsetTest.Sdk.csproj @@ -1,12 +1,12 @@ - + net472 TestData\**;$(DefaultItemExcludes) true - true + true @@ -14,10 +14,10 @@ - + - + diff --git a/src/wix/wix.cmd b/src/wix/wix.cmd index e49cfd53..ba5738cb 100644 --- a/src/wix/wix.cmd +++ b/src/wix/wix.cmd @@ -26,7 +26,7 @@ msbuild -t:Restore wix.sln -p:Configuration=%_C% -tl -nologo -m -warnaserror -bl :: Build msbuild wixnative\wixnative_t.proj -p:Configuration=%_C% -tl -nologo -m -warnaserror -bl:%_L%\wixnative_build.binlog || exit /b -msbuild wix.sln -p:Configuration=%_C% -tl -nologo -m -warnaserror -bl:%_L%\wix_build.binlog || exit /b +msbuild wix.sln -p:Configuration=%_C% -p:SuppressWixTests=true -tl -nologo -m -warnaserror -bl:%_L%\wix_build.binlog || exit /b msbuild publish_t.proj -p:Configuration=%_C% -tl -nologo -warnaserror -bl:%_L%\wix_publish.binlog || exit /b @@ -35,6 +35,7 @@ msbuild -t:Publish -p:Configuration=%_C% -tl -nologo -warnaserror WixToolset.Sdk :: TODO - used by MsbuildFixture.ReportsInnerExceptionForUnexpectedExceptions test :: msbuild -t:Publish -Restore -p:Configuration=%_C% -p:TargetFramework=net472 -p:RuntimeIdentifier=linux-x86 -p:PublishDir=%_P%WixToolset.Sdk\broken\net472\ wix\wix.csproj || exit /b +msbuild -t:RunWixTests test\WixToolsetTest.Sdk\WixToolsetTest.Sdk.csproj -p:Configuration=%_C% -p:NoBuild=true -tl -nologo -warnaserror || exit /b :: Test dotnet test ^ @@ -44,7 +45,6 @@ dotnet test ^ %_B%\test\WixToolsetTest.Core.Native\net6.0\win-x64\WixToolsetTest.Core.Native.dll ^ %_B%\test\WixToolsetTest.CoreIntegration\net6.0\WixToolsetTest.CoreIntegration.dll ^ %_B%\test\WixToolsetTest.BuildTasks\net472\WixToolsetTest.BuildTasks.dll ^ - %_B%\test\WixToolsetTest.Sdk\net472\WixToolsetTest.Sdk.dll ^ --nologo -l "trx;LogFileName=%_L%\TestResults\wix.trx" || exit /b -- cgit v1.2.3-55-g6feb