From 988d1d497411bc515bc0a032c07cc0713f985200 Mon Sep 17 00:00:00 2001
From: Bevan Weiss <bevan.weiss@gmail.com>
Date: Thu, 27 Feb 2025 22:16:51 +1100
Subject: util: correct usage of NetLocalGroupGetInfo in GroupExecute

Microsoft documentation doesn't list Level 0 as being a valid group info
level to request for NetLocalGroupGetInfo.  So we should only be requesting
Level 1 instead.


Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
---
 src/ext/Util/ca/scagroup.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'src')

diff --git a/src/ext/Util/ca/scagroup.cpp b/src/ext/Util/ca/scagroup.cpp
index 666100b0..6d67ffa4 100644
--- a/src/ext/Util/ca/scagroup.cpp
+++ b/src/ext/Util/ca/scagroup.cpp
@@ -427,7 +427,7 @@ HRESULT ScaGroupExecute(
     LPWSTR pwzBaseScriptKey = NULL;
     DWORD cScriptKey = 0;
 
-    LOCALGROUP_INFO_0 *pGroupInfo = NULL;
+    LOCALGROUP_INFO_1 *pGroupInfo1 = NULL;
     LPWSTR pwzScriptKey = NULL;
     LPWSTR pwzActionData = NULL;
     LPWSTR pwzRollbackData = NULL;
@@ -472,7 +472,7 @@ HRESULT ScaGroupExecute(
             }
         }
 
-        er = ::NetLocalGroupGetInfo(pwzServerName, psg->wzName, 0, reinterpret_cast<LPBYTE*>(&pGroupInfo));
+        er = ::NetLocalGroupGetInfo(pwzServerName, psg->wzName, 1, reinterpret_cast<LPBYTE*>(&pGroupInfo1));
         if (NERR_Success == er)
         {
             geGroupExists = GROUP_EXISTS_YES;
@@ -614,10 +614,10 @@ HRESULT ScaGroupExecute(
         ReleaseNullStr(pwzActionData);
         ReleaseNullStr(pwzRollbackData);
         ReleaseNullStr(pwzServerName);
-        if (pGroupInfo)
+        if (pGroupInfo1)
         {
-            ::NetApiBufferFree(static_cast<LPVOID>(pGroupInfo));
-            pGroupInfo = NULL;
+            ::NetApiBufferFree(static_cast<LPVOID>(pGroupInfo1));
+            pGroupInfo1 = NULL;
         }
     }
 
@@ -627,10 +627,10 @@ LExit:
     ReleaseStr(pwzActionData);
     ReleaseStr(pwzRollbackData);
     ReleaseStr(pwzServerName);
-    if (pGroupInfo)
+    if (pGroupInfo1)
     {
-        ::NetApiBufferFree(static_cast<LPVOID>(pGroupInfo));
-        pGroupInfo = NULL;
+        ::NetApiBufferFree(static_cast<LPVOID>(pGroupInfo1));
+        pGroupInfo1 = NULL;
     }
 
     return hr;
-- 
cgit v1.2.3-55-g6feb