From a3af25607b56f5ecf21d6712a8367217e5c43eb0 Mon Sep 17 00:00:00 2001 From: Rob Mensching Date: Fri, 14 Oct 2022 14:27:03 -0700 Subject: Use "wixext4" instead of "tools" as the root folder in ".wixext.nupkg"s Fixes 6944 --- src/Directory.Build.targets | 4 ++++ .../Services/IExtensionManager.cs | 6 ++++++ .../WixToolset.Dtf.CustomAction.nuspec | 4 ++-- src/ext/Bal/wixext/WixToolset.Bal.wixext.csproj | 6 ++---- src/ext/Bal/wixext/WixToolset.Bal.wixext.nuspec | 24 --------------------- src/ext/Bal/wixext/WixToolset.Bal.wixext.targets | 10 ++++----- .../wixext/WixToolset.ComPlus.wixext.csproj | 6 ++---- .../wixext/WixToolset.ComPlus.wixext.nuspec | 21 ------------------ .../wixext/WixToolset.ComPlus.wixext.targets | 10 ++++----- .../wixext/WixToolset.Dependency.wixext.csproj | 6 ++---- .../wixext/WixToolset.Dependency.wixext.nuspec | 21 ------------------ .../wixext/WixToolset.Dependency.wixext.targets | 10 ++++----- .../wixext/WixToolset.DifxApp.wixext.csproj | 6 ++---- .../wixext/WixToolset.DifxApp.wixext.targets | 10 ++++----- .../wixext/WixToolset.DirectX.wixext.csproj | 6 ++---- .../wixext/WixToolset.DirectX.wixext.targets | 10 ++++----- .../wixext/WixToolset.Firewall.wixext.csproj | 6 ++---- .../wixext/WixToolset.Firewall.wixext.targets | 10 ++++----- src/ext/Http/wixext/WixToolset.Http.wixext.csproj | 6 ++---- src/ext/Http/wixext/WixToolset.Http.wixext.targets | 10 ++++----- src/ext/Iis/wixext/WixToolset.Iis.wixext.csproj | 6 ++---- src/ext/Iis/wixext/WixToolset.Iis.wixext.targets | 10 ++++----- src/ext/Msmq/wixext/WixToolset.Msmq.wixext.csproj | 6 ++---- src/ext/Msmq/wixext/WixToolset.Msmq.wixext.targets | 10 ++++----- .../WixToolsetTest.Netfx/NetfxExtensionFixture.cs | 16 ++++++++++++-- .../WixToolsetTest.Netfx.csproj | 5 ----- .../NetFx/wixext/WixToolset.Netfx.wixext.csproj | 6 ++---- .../NetFx/wixext/WixToolset.Netfx.wixext.nuspec | 24 --------------------- .../NetFx/wixext/WixToolset.Netfx.wixext.targets | 10 ++++----- .../wixext/WixToolset.PowerShell.wixext.csproj | 6 ++---- .../wixext/WixToolset.PowerShell.wixext.targets | 10 ++++----- src/ext/Sql/wixext/WixToolset.Sql.wixext.csproj | 6 ++---- src/ext/Sql/wixext/WixToolset.Sql.wixext.nuspec | 21 ------------------ src/ext/Sql/wixext/WixToolset.Sql.wixext.targets | 10 ++++----- src/ext/UI/ui.cmd | 18 +++++++++++++++- src/ext/UI/wixext/WixToolset.UI.wixext.csproj | 6 ++---- src/ext/UI/wixext/WixToolset.UI.wixext.nuspec | 24 --------------------- src/ext/UI/wixext/WixToolset.UI.wixext.targets | 10 ++++----- src/ext/Util/wixext/WixToolset.Util.wixext.csproj | 13 +++++------ src/ext/Util/wixext/WixToolset.Util.wixext.nuspec | 24 --------------------- src/ext/Util/wixext/WixToolset.Util.wixext.targets | 10 ++++----- .../wixext/WixToolset.VisualStudio.wixext.csproj | 6 ++---- .../wixext/WixToolset.VisualStudio.wixext.nuspec | 21 ------------------ .../wixext/WixToolset.VisualStudio.wixext.targets | 7 ++++-- src/ext/WixExt.props | 19 ++++++++++++++++ src/internal/images/wix-black-bg.png | Bin 11650 -> 7917 bytes src/internal/images/wix-white-bg.png | Bin 22481 -> 17022 bytes src/internal/images/wix.png | Bin 0 -> 3410 bytes .../ExtensionCacheManager.cs | 4 +++- .../ExtensibilityServices/ExtensionManager.cs | 14 +++++++++--- src/wix/WixToolset.Sdk/WixToolset.Sdk.csproj | 22 +++++++++++++++++-- src/wix/WixToolset.Sdk/tools/wix.props | 6 +++++- src/wix/WixToolset.Sdk/tools/wix.targets | 3 +++ src/wix/pack-wix/pack-wix.nuspec | 4 ++-- .../ExtensionFixture.cs | 2 +- 55 files changed, 215 insertions(+), 336 deletions(-) delete mode 100644 src/ext/Bal/wixext/WixToolset.Bal.wixext.nuspec delete mode 100644 src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.nuspec delete mode 100644 src/ext/Dependency/wixext/WixToolset.Dependency.wixext.nuspec delete mode 100644 src/ext/NetFx/wixext/WixToolset.Netfx.wixext.nuspec delete mode 100644 src/ext/Sql/wixext/WixToolset.Sql.wixext.nuspec delete mode 100644 src/ext/UI/wixext/WixToolset.UI.wixext.nuspec delete mode 100644 src/ext/Util/wixext/WixToolset.Util.wixext.nuspec delete mode 100644 src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.nuspec create mode 100644 src/ext/WixExt.props create mode 100644 src/internal/images/wix.png (limited to 'src') diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index 5a8ef429..3d70c04c 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets @@ -49,6 +49,10 @@ true $(RepositoryUrl) + + $(GitBaseVersionMajor) + $(GitBaseVersionMinor) + $(GitBaseVersionPatch) MS-RL false $copyright$ @@ -19,7 +19,7 @@ - + diff --git a/src/ext/Bal/wixext/WixToolset.Bal.wixext.csproj b/src/ext/Bal/wixext/WixToolset.Bal.wixext.csproj index 8df40d5c..5591abde 100644 --- a/src/ext/Bal/wixext/WixToolset.Bal.wixext.csproj +++ b/src/ext/Bal/wixext/WixToolset.Bal.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Bal/wixext/WixToolset.Bal.wixext.nuspec b/src/ext/Bal/wixext/WixToolset.Bal.wixext.nuspec deleted file mode 100644 index cdbb001c..00000000 --- a/src/ext/Bal/wixext/WixToolset.Bal.wixext.nuspec +++ /dev/null @@ -1,24 +0,0 @@ - - - - $id$ - $version$ - $authors$ - $authors$ - wix-white-bg.png - MS-RL - $projectUrl$ - false - $title$ - $description$ - $copyright$ - - - - - - - - - - diff --git a/src/ext/Bal/wixext/WixToolset.Bal.wixext.targets b/src/ext/Bal/wixext/WixToolset.Bal.wixext.targets index 70c5a19c..bf6df083 100644 --- a/src/ext/Bal/wixext/WixToolset.Bal.wixext.targets +++ b/src/ext/Bal/wixext/WixToolset.Bal.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Bal.wixext.dll - + - + + diff --git a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.csproj b/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.csproj index 77f9a8d3..1975d7d4 100644 --- a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.csproj +++ b/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.nuspec b/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.nuspec deleted file mode 100644 index 7143d993..00000000 --- a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.nuspec +++ /dev/null @@ -1,21 +0,0 @@ - - - - $id$ - $version$ - $title$ - $description$ - $authors$ - MS-RL - false - $copyright$ - $projectUrl$ - - - - - - - - - diff --git a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.targets b/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.targets index 8115b715..bf6df083 100644 --- a/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.targets +++ b/src/ext/ComPlus/wixext/WixToolset.ComPlus.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.ComPlus.wixext.dll - + - + + diff --git a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.csproj b/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.csproj index b477ddf3..b61c6665 100644 --- a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.csproj +++ b/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.nuspec b/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.nuspec deleted file mode 100644 index 7143d993..00000000 --- a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.nuspec +++ /dev/null @@ -1,21 +0,0 @@ - - - - $id$ - $version$ - $title$ - $description$ - $authors$ - MS-RL - false - $copyright$ - $projectUrl$ - - - - - - - - - diff --git a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.targets b/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.targets index 2b298736..bf6df083 100644 --- a/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.targets +++ b/src/ext/Dependency/wixext/WixToolset.Dependency.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Dependency.wixext.dll - + - + + diff --git a/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.csproj b/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.csproj index 9f2d353e..ec52e897 100644 --- a/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.csproj +++ b/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.targets b/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.targets index b01d4116..bf6df083 100644 --- a/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.targets +++ b/src/ext/DifxApp/wixext/WixToolset.DifxApp.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.DifxApp.wixext.dll - + - + + diff --git a/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.csproj b/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.csproj index c5f4770d..80263e9a 100644 --- a/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.csproj +++ b/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.targets b/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.targets index 4e27a6da..bf6df083 100644 --- a/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.targets +++ b/src/ext/DirectX/wixext/WixToolset.DirectX.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.DirectX.wixext.dll - + - + + diff --git a/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.csproj b/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.csproj index 4c2eed7e..8d1dc77e 100644 --- a/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.csproj +++ b/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.targets b/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.targets index c717450f..bf6df083 100644 --- a/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.targets +++ b/src/ext/Firewall/wixext/WixToolset.Firewall.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Firewall.wixext.dll - + - + + diff --git a/src/ext/Http/wixext/WixToolset.Http.wixext.csproj b/src/ext/Http/wixext/WixToolset.Http.wixext.csproj index d11e28cc..cee26f86 100644 --- a/src/ext/Http/wixext/WixToolset.Http.wixext.csproj +++ b/src/ext/Http/wixext/WixToolset.Http.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Http/wixext/WixToolset.Http.wixext.targets b/src/ext/Http/wixext/WixToolset.Http.wixext.targets index 254b0010..bf6df083 100644 --- a/src/ext/Http/wixext/WixToolset.Http.wixext.targets +++ b/src/ext/Http/wixext/WixToolset.Http.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Http.wixext.dll - + - + + diff --git a/src/ext/Iis/wixext/WixToolset.Iis.wixext.csproj b/src/ext/Iis/wixext/WixToolset.Iis.wixext.csproj index 090d9150..79c8dae7 100644 --- a/src/ext/Iis/wixext/WixToolset.Iis.wixext.csproj +++ b/src/ext/Iis/wixext/WixToolset.Iis.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Iis/wixext/WixToolset.Iis.wixext.targets b/src/ext/Iis/wixext/WixToolset.Iis.wixext.targets index 6398fce1..bf6df083 100644 --- a/src/ext/Iis/wixext/WixToolset.Iis.wixext.targets +++ b/src/ext/Iis/wixext/WixToolset.Iis.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Iis.wixext.dll - + - + + diff --git a/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.csproj b/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.csproj index 0c2325a8..ef369c2c 100644 --- a/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.csproj +++ b/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.targets b/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.targets index 5f69fe48..bf6df083 100644 --- a/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.targets +++ b/src/ext/Msmq/wixext/WixToolset.Msmq.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Msmq.wixext.dll - + - + + diff --git a/src/ext/NetFx/test/WixToolsetTest.Netfx/NetfxExtensionFixture.cs b/src/ext/NetFx/test/WixToolsetTest.Netfx/NetfxExtensionFixture.cs index 8db3db46..6a75f30f 100644 --- a/src/ext/NetFx/test/WixToolsetTest.Netfx/NetfxExtensionFixture.cs +++ b/src/ext/NetFx/test/WixToolsetTest.Netfx/NetfxExtensionFixture.cs @@ -21,13 +21,19 @@ namespace WixToolsetTest.Netfx var bundleSourceFolder = TestData.Get(@"TestData\UsingDotNetCorePackages"); var intermediateFolder = Path.Combine(baseFolder, "obj"); + var extensionResult = WixRunner.Execute(new[] + { + "extension", "add", + "WixToolset.Bal.wixext" + }); + var compileResult = WixRunner.Execute(new[] { "build", Path.Combine(bundleSourceFolder, "BundleLatest.wxs"), Path.Combine(bundleSourceFolder, "NetCore3.1.12_x86.wxs"), Path.Combine(bundleSourceFolder, "NetCore3.1.12_x64.wxs"), - "-ext", TestData.Get(@"WixToolset.Bal.wixext.dll"), + "-ext", "WixToolset.Bal.wixext", "-ext", TestData.Get(@"WixToolset.Netfx.wixext.dll"), "-intermediateFolder", intermediateFolder, "-o", bundleFile, @@ -48,12 +54,18 @@ namespace WixToolsetTest.Netfx var bundleSourceFolder = TestData.Get(@"TestData\UsingDotNetCorePackages"); var intermediateFolder = Path.Combine(baseFolder, "obj"); + var extensionResult = WixRunner.Execute(new[] + { + "extension", "add", + "WixToolset.Bal.wixext" + }); + var compileResult = WixRunner.Execute(new[] { "build", Path.Combine(bundleSourceFolder, "BundleLatest_x64.wxs"), Path.Combine(bundleSourceFolder, "NetCore3.1.12_x64.wxs"), - "-ext", TestData.Get(@"WixToolset.Bal.wixext.dll"), + "-ext", "WixToolset.Bal.wixext", "-ext", TestData.Get(@"WixToolset.Netfx.wixext.dll"), "-intermediateFolder", intermediateFolder, "-o", bundleFile, diff --git a/src/ext/NetFx/test/WixToolsetTest.Netfx/WixToolsetTest.Netfx.csproj b/src/ext/NetFx/test/WixToolsetTest.Netfx/WixToolsetTest.Netfx.csproj index e2f97a16..8b13d357 100644 --- a/src/ext/NetFx/test/WixToolsetTest.Netfx/WixToolsetTest.Netfx.csproj +++ b/src/ext/NetFx/test/WixToolsetTest.Netfx/WixToolsetTest.Netfx.csproj @@ -16,11 +16,6 @@ - - - - - diff --git a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.csproj b/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.csproj index 15bf1654..67759ab3 100644 --- a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.csproj +++ b/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.nuspec b/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.nuspec deleted file mode 100644 index 4abfa98c..00000000 --- a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.nuspec +++ /dev/null @@ -1,24 +0,0 @@ - - - - $id$ - $version$ - $authors$ - $authors$ - wix-white-bg.png - MS-RL - https://github.com/wixtoolset/Bal.wixext - false - $title$ - $description$ - $copyright$ - - - - - - - - - - diff --git a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.targets b/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.targets index 2ed9c488..bf6df083 100644 --- a/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.targets +++ b/src/ext/NetFx/wixext/WixToolset.Netfx.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Netfx.wixext.dll - + - + + diff --git a/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.csproj b/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.csproj index 54079c4e..812915a8 100644 --- a/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.csproj +++ b/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.targets b/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.targets index bf06e1e4..bf6df083 100644 --- a/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.targets +++ b/src/ext/PowerShell/wixext/WixToolset.PowerShell.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.PowerShell.wixext.dll - + - + + diff --git a/src/ext/Sql/wixext/WixToolset.Sql.wixext.csproj b/src/ext/Sql/wixext/WixToolset.Sql.wixext.csproj index b3eb5a4c..28a66297 100644 --- a/src/ext/Sql/wixext/WixToolset.Sql.wixext.csproj +++ b/src/ext/Sql/wixext/WixToolset.Sql.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/Sql/wixext/WixToolset.Sql.wixext.nuspec b/src/ext/Sql/wixext/WixToolset.Sql.wixext.nuspec deleted file mode 100644 index 7143d993..00000000 --- a/src/ext/Sql/wixext/WixToolset.Sql.wixext.nuspec +++ /dev/null @@ -1,21 +0,0 @@ - - - - $id$ - $version$ - $title$ - $description$ - $authors$ - MS-RL - false - $copyright$ - $projectUrl$ - - - - - - - - - diff --git a/src/ext/Sql/wixext/WixToolset.Sql.wixext.targets b/src/ext/Sql/wixext/WixToolset.Sql.wixext.targets index 4950e119..bf6df083 100644 --- a/src/ext/Sql/wixext/WixToolset.Sql.wixext.targets +++ b/src/ext/Sql/wixext/WixToolset.Sql.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Sql.wixext.dll - + - + + diff --git a/src/ext/UI/ui.cmd b/src/ext/UI/ui.cmd index d62870d4..3823f45a 100644 --- a/src/ext/UI/ui.cmd +++ b/src/ext/UI/ui.cmd @@ -4,18 +4,34 @@ @set _C=Debug :parse_args @if /i "%1"=="release" set _C=Release +@if /i "%1"=="inc" set _INC=1 +@if /i "%1"=="clean" set _CLEAN=1 @if not "%1"=="" shift & goto parse_args +:: Clean + +@if "%_INC%"=="" call :clean +@if NOT "%_CLEAN%"=="" goto :end + @echo UI.wixext build %_C% :: Build msbuild -Restore -p:Configuration=%_C% || exit /b :: Test -dotnet test -c %_C% --no-build test\WixToolsetTest.UI || exit /b +:: dotnet test -c %_C% --no-build test\WixToolsetTest.UI || exit /b :: Pack msbuild -t:Pack -p:Configuration=%_C% -p:NoBuild=true wixext\WixToolset.UI.wixext.csproj || exit /b +@goto :end + +:clean +@rd /s/q "..\..\..\build\UI.wixext" 2> nul +@del "..\..\..\build\artifacts\WixToolset.UI.wixext.*.nupkg" 2> nul +@rd /s/q "%USERPROFILE%\.nuget\packages\wixtoolset.ui.wixext" 2> nul +@exit /b + +:end @popd @endlocal diff --git a/src/ext/UI/wixext/WixToolset.UI.wixext.csproj b/src/ext/UI/wixext/WixToolset.UI.wixext.csproj index 09f748c3..288b4a85 100644 --- a/src/ext/UI/wixext/WixToolset.UI.wixext.csproj +++ b/src/ext/UI/wixext/WixToolset.UI.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/UI/wixext/WixToolset.UI.wixext.nuspec b/src/ext/UI/wixext/WixToolset.UI.wixext.nuspec deleted file mode 100644 index 4abfa98c..00000000 --- a/src/ext/UI/wixext/WixToolset.UI.wixext.nuspec +++ /dev/null @@ -1,24 +0,0 @@ - - - - $id$ - $version$ - $authors$ - $authors$ - wix-white-bg.png - MS-RL - https://github.com/wixtoolset/Bal.wixext - false - $title$ - $description$ - $copyright$ - - - - - - - - - - diff --git a/src/ext/UI/wixext/WixToolset.UI.wixext.targets b/src/ext/UI/wixext/WixToolset.UI.wixext.targets index b07a0886..bf6df083 100644 --- a/src/ext/UI/wixext/WixToolset.UI.wixext.targets +++ b/src/ext/UI/wixext/WixToolset.UI.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.UI.wixext.dll - + - + + diff --git a/src/ext/Util/wixext/WixToolset.Util.wixext.csproj b/src/ext/Util/wixext/WixToolset.Util.wixext.csproj index 82e1886b..a4fcaf14 100644 --- a/src/ext/Util/wixext/WixToolset.Util.wixext.csproj +++ b/src/ext/Util/wixext/WixToolset.Util.wixext.csproj @@ -10,16 +10,13 @@ embedded + + - - + - - + + diff --git a/src/ext/Util/wixext/WixToolset.Util.wixext.nuspec b/src/ext/Util/wixext/WixToolset.Util.wixext.nuspec deleted file mode 100644 index 4abfa98c..00000000 --- a/src/ext/Util/wixext/WixToolset.Util.wixext.nuspec +++ /dev/null @@ -1,24 +0,0 @@ - - - - $id$ - $version$ - $authors$ - $authors$ - wix-white-bg.png - MS-RL - https://github.com/wixtoolset/Bal.wixext - false - $title$ - $description$ - $copyright$ - - - - - - - - - - diff --git a/src/ext/Util/wixext/WixToolset.Util.wixext.targets b/src/ext/Util/wixext/WixToolset.Util.wixext.targets index 64dff429..bf6df083 100644 --- a/src/ext/Util/wixext/WixToolset.Util.wixext.targets +++ b/src/ext/Util/wixext/WixToolset.Util.wixext.targets @@ -1,11 +1,11 @@ - - - $(MSBuildThisFileDirectory)..\tools\WixToolset.Util.wixext.dll - + - + + diff --git a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.csproj b/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.csproj index 209ea00c..0224c98c 100644 --- a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.csproj +++ b/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.csproj @@ -10,6 +10,8 @@ embedded + + @@ -17,8 +19,4 @@ - - - - diff --git a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.nuspec b/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.nuspec deleted file mode 100644 index 7143d993..00000000 --- a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.nuspec +++ /dev/null @@ -1,21 +0,0 @@ - - - - $id$ - $version$ - $title$ - $description$ - $authors$ - MS-RL - false - $copyright$ - $projectUrl$ - - - - - - - - - diff --git a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.targets b/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.targets index 4542375f..bf6df083 100644 --- a/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.targets +++ b/src/ext/VisualStudio/wixext/WixToolset.VisualStudio.wixext.targets @@ -1,8 +1,11 @@ - + - + + diff --git a/src/ext/WixExt.props b/src/ext/WixExt.props new file mode 100644 index 00000000..23bce7fa --- /dev/null +++ b/src/ext/WixExt.props @@ -0,0 +1,19 @@ + + + + + + wix.png + false + true + NU5100 + + + + + + + + + + diff --git a/src/internal/images/wix-black-bg.png b/src/internal/images/wix-black-bg.png index 375d05a4..8bf978a5 100644 Binary files a/src/internal/images/wix-black-bg.png and b/src/internal/images/wix-black-bg.png differ diff --git a/src/internal/images/wix-white-bg.png b/src/internal/images/wix-white-bg.png index 8e752f69..ebff9e13 100644 Binary files a/src/internal/images/wix-white-bg.png and b/src/internal/images/wix-white-bg.png differ diff --git a/src/internal/images/wix.png b/src/internal/images/wix.png new file mode 100644 index 00000000..9a92155e Binary files /dev/null and b/src/internal/images/wix.png differ diff --git a/src/wix/WixToolset.Core.ExtensionCache/ExtensionCacheManager.cs b/src/wix/WixToolset.Core.ExtensionCache/ExtensionCacheManager.cs index b50ad6e8..5706413f 100644 --- a/src/wix/WixToolset.Core.ExtensionCache/ExtensionCacheManager.cs +++ b/src/wix/WixToolset.Core.ExtensionCache/ExtensionCacheManager.cs @@ -197,6 +197,8 @@ namespace WixToolset.Core.ExtensionCache var extensionFolder = Path.Combine(cacheFolder, id, nugetVersion.ToString()); + var extensionPackageRootFolderName = this.ExtensionManager.GetExtensionPackageRootFolderName(); + foreach (var source in searchSources) { var repository = Repository.Factory.GetCoreV3(source.Source); @@ -214,7 +216,7 @@ namespace WixToolset.Core.ExtensionCache using (var archive = new PackageArchiveReader(stream)) { - var files = PackagingConstants.Folders.Known.SelectMany(folder => archive.GetFiles(folder)).Distinct(StringComparer.OrdinalIgnoreCase); + var files = archive.GetFiles(extensionPackageRootFolderName); await archive.CopyFilesAsync(extensionFolder, files, this.ExtractProgress, logger, cancellationToken); } diff --git a/src/wix/WixToolset.Core/ExtensibilityServices/ExtensionManager.cs b/src/wix/WixToolset.Core/ExtensibilityServices/ExtensionManager.cs index 6e10744d..00ab5e6d 100644 --- a/src/wix/WixToolset.Core/ExtensibilityServices/ExtensionManager.cs +++ b/src/wix/WixToolset.Core/ExtensibilityServices/ExtensionManager.cs @@ -15,8 +15,11 @@ namespace WixToolset.Core.ExtensibilityServices internal class ExtensionManager : IExtensionManager { - private const string UserWixFolderName = ".wix4"; - private const string MachineWixFolderName = "WixToolset4"; + // This value needs to stay in sync with the Property in "wix.targets" with the same name. + private const string WixToolsetExtensionPackageFolder = "wixext4"; + + private const string UserWixFolderName = ".wix"; + private const string MachineWixFolderName = "WixToolset"; private const string ExtensionsFolderName = "extensions"; private const string UserEnvironmentName = "WIX_EXTENSIONS"; @@ -70,7 +73,7 @@ namespace WixToolset.Core.ExtensibilityServices continue; } - checkPath = Path.Combine(extensionFolder, versionFolder, "tools", extensionId + ".dll"); + checkPath = Path.Combine(extensionFolder, versionFolder, WixToolsetExtensionPackageFolder, extensionId + ".dll"); checkedPaths.Add(checkPath); if (TryLoadFromPath(checkPath, out assembly)) @@ -128,6 +131,11 @@ namespace WixToolset.Core.ExtensibilityServices return locations; } + public string GetExtensionPackageRootFolderName() + { + return WixToolsetExtensionPackageFolder; + } + public IReadOnlyCollection GetServices() where T : class { if (!this.loadedExtensionsByType.TryGetValue(typeof(T), out var extensions)) diff --git a/src/wix/WixToolset.Sdk/WixToolset.Sdk.csproj b/src/wix/WixToolset.Sdk/WixToolset.Sdk.csproj index 8c2d866c..4a5e6229 100644 --- a/src/wix/WixToolset.Sdk/WixToolset.Sdk.csproj +++ b/src/wix/WixToolset.Sdk/WixToolset.Sdk.csproj @@ -31,13 +31,31 @@ + Query="//msb:WixToolsetMajorVersion" + Value="$(WixMajorVersion)" /> + + + + + + diff --git a/src/wix/WixToolset.Sdk/tools/wix.props b/src/wix/WixToolset.Sdk/tools/wix.props index cd4aa4ac..d3c202bf 100644 --- a/src/wix/WixToolset.Sdk/tools/wix.props +++ b/src/wix/WixToolset.Sdk/tools/wix.props @@ -4,8 +4,12 @@ true - $$WixToolsetVersion$$ + $$WixToolsetMajorVersion$$ + $$WixToolsetMinorVersion$$ + $$WixToolsetPatchVersion$$ $$WixToolsetMajorMinorVersion$$ + $$WixToolsetVersion$$ + wixext4 diff --git a/src/wix/WixToolset.Sdk/tools/wix.targets b/src/wix/WixToolset.Sdk/tools/wix.targets index 6a8b6055..8665f05c 100644 --- a/src/wix/WixToolset.Sdk/tools/wix.targets +++ b/src/wix/WixToolset.Sdk/tools/wix.targets @@ -577,6 +577,9 @@ <_WixBuildCabinetCachePath Condition=" '$(CabinetCachePath)'!='' ">$([MSBuild]::NormalizeDirectory($(CabinetCachePath), %(CultureGroup.OutputFolder))) + + $title$ $description$ $authors$ - wix-white-bg.png + wix.png MS-RL false $copyright$ @@ -19,7 +19,7 @@ - + diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/ExtensionFixture.cs b/src/wix/test/WixToolsetTest.CoreIntegration/ExtensionFixture.cs index 0d5418a5..aabaac42 100644 --- a/src/wix/test/WixToolsetTest.CoreIntegration/ExtensionFixture.cs +++ b/src/wix/test/WixToolsetTest.CoreIntegration/ExtensionFixture.cs @@ -190,7 +190,7 @@ namespace WixToolsetTest.CoreIntegration result.AssertSuccess(); - var cacheFolder = Path.Combine(folder, ".wix4", "extensions", "WixToolset.UI.wixext"); + var cacheFolder = Path.Combine(folder, ".wix", "extensions", "WixToolset.UI.wixext"); Assert.True(Directory.Exists(cacheFolder), $"Expected folder '{cacheFolder}' to exist"); result = WixRunner.Execute(new[] -- cgit v1.2.3-55-g6feb