From b710f6e40239f12d1b7ff670c8580a550f0bb557 Mon Sep 17 00:00:00 2001 From: Bevan Weiss Date: Sat, 15 Feb 2025 17:15:03 +1100 Subject: Skip Decompile roundtrip test for Msmq (it will require more time to investigate Wix4Group / Wix6Group decompiler interactions). Fix up Msmq Util dependency by bringing it into Build explicitly, as per NetFx extension. Signed-off-by: Bevan Weiss --- .../WixToolsetTest.Msmq/MsmqExtensionFixture.cs | 32 ++++++++++++++++------ .../WixToolsetTest.Msmq/WixToolsetTest.Msmq.csproj | 1 - 2 files changed, 23 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/ext/Msmq/test/WixToolsetTest.Msmq/MsmqExtensionFixture.cs b/src/ext/Msmq/test/WixToolsetTest.Msmq/MsmqExtensionFixture.cs index c89d138a..970bc2e9 100644 --- a/src/ext/Msmq/test/WixToolsetTest.Msmq/MsmqExtensionFixture.cs +++ b/src/ext/Msmq/test/WixToolsetTest.Msmq/MsmqExtensionFixture.cs @@ -9,7 +9,6 @@ namespace WixToolsetTest.Msmq using WixInternal.TestSupport; using WixInternal.Core.TestPackage; using WixToolset.Msmq; - using WixToolset.Util; using Xunit; public class MsmqExtensionFixture @@ -18,9 +17,9 @@ namespace WixToolsetTest.Msmq public void CanBuildUsingMessageQueue() { var folder = TestData.Get(@"TestData\UsingMessageQueue"); - var build = new Builder(folder, new[] { typeof(MsmqExtensionFactory), typeof(UtilExtensionFactory) }, new[] { folder }); + var build = new Builder(folder, new[] { typeof(MsmqExtensionFactory) }, new[] { folder }); - var results = build.BuildAndQuery(Build, "Wix4MessageQueue", "CustomAction", "Wix4MessageQueueUserPermission", "Wix4MessageQueueGroupPermission", "Wix4Group", "Wix4User"); + var results = build.BuildAndQuery(BuildWithUtil, "Wix4MessageQueue", "CustomAction", "Wix4MessageQueueUserPermission", "Wix4MessageQueueGroupPermission", "Wix4Group", "Wix4User"); WixAssert.CompareLineByLine(new[] { "CustomAction:Wix4MessageQueuingExecuteInstall_A64\t3073\tWix4MsmqCA_A64\tMessageQueuingExecuteInstall\t", @@ -37,14 +36,14 @@ namespace WixToolsetTest.Msmq }, results); } - [Fact] + [Fact(Skip = "Util:Wix4Group and Util:Wix6Group decompilation issues prevent this usage currently")] public void CanRoundtripMessageQueue() { var folder = TestData.Get(@"TestData\UsingMessageQueue"); - var build = new Builder(folder, new[] { typeof(MsmqExtensionFactory), typeof(UtilExtensionFactory) }, new[] { folder }); + var build = new Builder(folder, new[] { typeof(MsmqExtensionFactory) }, new[] { folder }); var output = Path.Combine(folder, "MessageQueueDecompile.xml"); - build.BuildAndDecompileAndBuild(Build, Decompile, output); + build.BuildAndDecompileAndBuild(BuildWithUtil, DecompileWithUtil, output); var doc = XDocument.Load(output); var actual = doc.Descendants() @@ -60,16 +59,31 @@ namespace WixToolsetTest.Msmq }, actual.Select(a => $"{a.Name}:{a.Id}").ToArray()); } - private static void Build(string[] args) + private static void BuildWithUtil(string[] args) { - args = args.Concat(new[] { "-arch", "arm64" }).ToArray(); + var extensionResult = WixRunner.Execute(warningsAsErrors: true, new[] + { + "extension", "add", + "WixToolset.Util.wixext", + }); + + args = args.Concat(new[] + { + "-ext", "WixToolset.Util.wixext", + "-arch", "arm64" + }).ToArray(); var result = WixRunner.Execute(args); result.AssertSuccess(); } - private static void Decompile(string[] args) + private static void DecompileWithUtil(string[] args) { + args = args.Concat(new[] + { + "-ext", "WixToolset.Util.wixext", + }).ToArray(); + var result = WixRunner.Execute(args); result.AssertSuccess(); } diff --git a/src/ext/Msmq/test/WixToolsetTest.Msmq/WixToolsetTest.Msmq.csproj b/src/ext/Msmq/test/WixToolsetTest.Msmq/WixToolsetTest.Msmq.csproj index 88718f98..e7b6f21e 100644 --- a/src/ext/Msmq/test/WixToolsetTest.Msmq/WixToolsetTest.Msmq.csproj +++ b/src/ext/Msmq/test/WixToolsetTest.Msmq/WixToolsetTest.Msmq.csproj @@ -16,7 +16,6 @@ - -- cgit v1.2.3-55-g6feb