summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix bug when level 0 used with Z_HUFFMAN or Z_RLE.Mark Adler2016-10-271-3/+4
| | | | | | | | | | | Compression level 0 requests no compression, using only stored blocks. When Z_HUFFMAN or Z_RLE was used with level 0 (granted, an odd choice, but permitted), the resulting blocks were mostly fixed or dynamic. The reason is that deflate_stored() was not being called in that case. The compressed data was valid, but it was not what the application requested. This commit assures that only stored blocks are emitted for compression level 0, regardless of the strategy selected.
* Clean up and comment the use of local for static.Mark Adler2016-10-264-6/+6
|
* Make a noble effort at setting OS_CODE correctly.Mark Adler2016-10-251-14/+30
| | | | | | | | This updates the OS_CODE determination at compile time to match as closely as possible the operating system mappings documented in the PKWare APPNOTE.TXT version 6.3.4, section 4.4.2.2. That byte in the gzip header is used by nobody for anything, as far as I can tell. However we might as well try to set it appropriately.
* Do a more thorough check of the state for every stream call.Mark Adler2016-10-243-41/+72
| | | | | | This verifies that the state has been initialized, that it is the expected type of state, deflate or inflate, and that at least the first several bytes of the internal state have not been clobbered.
* Document the rejection of 256-byte window requests in zlib.h.Mark Adler2016-10-241-0/+4
|
* Reject a window size of 256 bytes if not using the zlib wrapper.Mark Adler2016-10-241-1/+1
| | | | | | | | | | | | There is a bug in deflate for windowBits == 8 (256-byte window). As a result, zlib silently changes a request for 8 to a request for 9 (512-byte window), and sets the zlib header accordingly so that the decompressor knows to use a 512-byte window. However if deflateInit2() is used for raw deflate or gzip streams, then there is no indication that the request was not honored, and the application might assume that it can use a 256-byte window when decompressing. This commit returns an error if the user requests a 256-byte window when using raw deflate or gzip encoding.
* Avoid obfuscating use of default case in inftrees.c.Mark Adler2016-10-141-1/+1
|
* Move macro definition in deflate.c to where it is used.Mark Adler2016-10-141-3/+4
| | | | This avoid defining a macro that is never used when not debugging.
* Avoid recursive gzgetc() macro call.Mark Adler2016-10-141-2/+2
| | | | | Recursive macro calls are normally caught by the preprocessor and avoided. This commit avoids the possibility of a problem entirely.
* Make globals in examples local to compilation unit.Mark Adler2016-10-142-4/+4
|
* Add --warn option to ./configure, instead of environment variable.Mark Adler2016-10-111-1/+3
|
* Clean up type conversions.Mark Adler2016-10-119-57/+62
|
* Avoid casting an out-of-range value to long.Mark Adler2016-10-111-1/+1
|
* Note the violation of the strict aliasing rule in crc32.c.Mark Adler2016-10-031-0/+12
| | | | | | See the comment for more details. This is in response to an issue raised as a result of a security audit of the zlib code by Trail of Bits and TrustInSoft, in support of the Mozilla Foundation.
* Avoid pre-decrement of pointer in big-endian CRC calculation.Mark Adler2016-09-281-3/+1
| | | | | | | | | | | | | | There was a small optimization for PowerPCs to pre-increment a pointer when accessing a word, instead of post-incrementing. This required prefacing the loop with a decrement of the pointer, possibly pointing before the object passed. This is not compliant with the C standard, for which decrementing a pointer before its allocated memory is undefined. When tested on a modern PowerPC with a modern compiler, the optimization no longer has any effect. Due to all that, and per the recommendation of a security audit of the zlib code by Trail of Bits and TrustInSoft, in support of the Mozilla Foundation, this "optimization" was removed, in order to avoid the possibility of undefined behavior.
* Remove offset pointer optimization in inftrees.c.Mark Adler2016-09-211-10/+8
| | | | | | | | | | | inftrees.c was subtracting an offset from a pointer to an array, in order to provide a pointer that allowed indexing starting at the offset. This is not compliant with the C standard, for which the behavior of a pointer decremented before its allocated memory is undefined. Per the recommendation of a security audit of the zlib code by Trail of Bits and TrustInSoft, in support of the Mozilla Foundation, this tiny optimization was removed, in order to avoid the possibility of undefined behavior.
* Use post-increment only in inffast.c.Mark Adler2016-09-211-50/+31
| | | | | | | | | | An old inffast.c optimization turns out to not be optimal anymore with modern compilers, and furthermore was not compliant with the C standard, for which decrementing a pointer before its allocated memory is undefined. Per the recommendation of a security audit of the zlib code by Trail of Bits and TrustInSoft, in support of the Mozilla Foundation, this "optimization" was removed, in order to avoid the possibility of undefined behavior.
* Remove dummy structure declarations for old buggy compilers.Mark Adler2016-09-216-28/+0
| | | | | | | | | | | | | | While woolly mammoths still roamed the Earth and before Atlantis sunk into the ocean, there were C compilers that could not handle forward structure references, e.g. "struct name;". zlib dutifully provided a work-around for such compilers. That work-around is no longer needed, and, per the recommendation of a security audit of the zlib code by Trail of Bits and TrustInSoft, in support of the Mozilla Foundation, should be removed since what a compiler will do with this is technically undefined. From the report: "there is no telling what interactions the bug could have in the future with link-time optimizations and type-based alias analyses, both features that are present (but not default) in clang."
* Fix typo.Mark Adler2016-09-211-1/+1
|
* Add option to not compute or check check values.Mark Adler2016-09-203-13/+34
| | | | | | | | | | | | | | | | | | The undocumented (except in these commit comments) function inflateValidate(strm, check) can be called after an inflateInit(), inflateInit2(), or inflateReset2() with check equal to zero to turn off the check value (CRC-32 or Adler-32) computation and comparison. Calling with check not equal to zero turns checking back on. This should only be called immediately after the init or reset function. inflateReset() does not change the state, so a previous inflateValidate() setting will remain in effect. This also turns off validation of the gzip header CRC when present. This should only be used when a zlib or gzip stream has already been checked, and repeated decompressions of the same stream no longer need to be validated.
* Correct the size of the inflate state in the comments.Mark Adler2016-09-201-1/+2
|
* Fix typo in blast.c.Mark Adler2016-07-101-1/+1
|
* Add configure.log to .gitignore.Mark Adler2016-06-171-0/+1
|
* Loop on write() calls in gzwrite.c in case of non-blocking I/O.Mark Adler2016-04-051-11/+16
|
* Fix gzseek() problem on MinGW due to buggy _lseeki64 there.Mark Adler2016-01-291-1/+1
|
* Fix bug that accepted invalid zlib header when windowBits is zero.Mark Adler2015-11-261-1/+1
| | | | | | | | When windowBits is zero, the size of the sliding window comes from the zlib header. The allowed values of the four-bit field are 0..7, but when windowBits is zero, values greater than 7 are permitted and acted upon, resulting in large, mostly unused memory allocations. This fix rejects such invalid zlib headers.
* Use a consistent and more modern approach to not use a parameter.Mark Adler2015-10-041-6/+10
| | | | | | A remarkably creative and diverse set of approaches to letting the compiler know that opaque was being used when it wasn't is changed by this commit to the more standard (void)opaque.
* Use UTF-8 for non-ASCII characters in ChangeLog.Mark Adler2015-09-161-3/+3
|
* Clean up portability for shifts and integer sizes.Mark Adler2015-09-053-4/+4
|
* Avoid shifts of negative values inflateMark().Mark Adler2015-09-051-2/+3
| | | | | | The C standard says that bit shifts of negative integers is undefined. This casts to unsigned values to assure a known result.
* Fix typo.Mark Adler2015-08-151-1/+1
|
* Use const for static tree descriptions in deflate.Mark Adler2015-08-152-4/+4
| | | | This is in order to permit shared memory for these structures.
* Allow building zlib outside of the source directory.Mark Adler2015-08-022-61/+197
| | | | | | | | | | To build, simply run configure from the source directory by specifying its path. That path will be used to find the source files. The source directory will not be touched. All new and modified files will be made in the current directory. Discovered in the process that not all makes understand % or $<, and not all compilers understand -include or -I-. This required a larger Makefile.in with explicit dependencies.
* Do not initialize unsigned with -1 in compress.c uncompr.c.Mark Adler2015-08-022-2/+2
| | | | Sun compiler complained. Use (unsigned)0 - 1 instead.
* Align deflateParams() and its documentation in zlib.h.Mark Adler2015-08-022-14/+27
| | | | | | | | This updates the documentation to reflect the behavior of deflateParams() when it is not able to compress all of the input data provided so far due to insufficient output space. It also assures that data provided is compressed before the parameter changes, even if at the beginning of the stream.
* Compile the gzopen_w() function when __CYGWIN__ defined.Mark Adler2015-08-013-5/+9
|
* Define _POSIX_SOURCE to enable POSIX extensions on some systems.Mark Adler2015-07-281-0/+4
|
* Clarify deflateReset() documentation.Mark Adler2015-07-281-4/+4
| | | | | | It previously could have been misinterpreted to mean that parameter changes after deflateInit2() would be reversed, which is not the case.
* Avoid uninitialized access by gzclose_w().Mark Adler2015-07-282-1/+2
|
* Avoid use of DEBUG macro -- change to ZLIB_DEBUG.Mark Adler2015-07-2814-33/+33
|
* Avoid use of reallocf() in test/infcover.c.Mark Adler2015-07-281-8/+8
|
* Fix inflateInit2() bug when windowBits is 16 or 32.Mark Adler2015-07-281-0/+2
| | | | | | | | A windowBits value of 0, 16, or 32 gets the window bits from the zlib header. However there is no zlib header for 16, or for 32 when the input is gzip. This commit sets the window bits for inflate to 15 if a gzip stream is detected and windowBits was 16 or 32.
* Add comment about not using windowBits of 8 for deflate().Mark Adler2015-07-281-0/+8
|
* Put license in zlib.3 man page.Mark Adler2015-07-072-9/+27
| | | | | Previously there was a confusing reference to a "distribution directory".
* Improve speed of gzprintf() in transparent mode.Mark Adler2015-07-054-51/+70
|
* Avoid left shift of a negative value in flush rank calculation.Mark Adler2015-07-051-1/+1
| | | | | The C standard permits an undefined result for a left shift of a negative value.
* Remedy Coverity warning. [Randers-Pehrson]Mark Adler2015-01-261-1/+1
|
* Add inflateCodesUsed() function for internal use.Mark Adler2014-12-291-0/+9
|
* Fix bug in test/example.c where error code not saved.Mark Adler2014-07-021-1/+1
|
* Note in zlib.h that compress() uses Z_DEFAULT_COMPRESSION.Mark Adler2014-04-261-1/+2
|