Tobias Krawutschke found a bug where the DHCP client would accept packets

with the wrong ARP address, meaning we could easily get somebody else's IP.
That is a bad thing, and this is the minimal two-line fix.

1 files changed, 3 insertions, 0 deletions

diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
index 8009bec04..d99711c43 100644
--- a/networking/udhcp/dhcpc.c
+++ b/networking/udhcp/dhcpc.c
@@ -439,6 +439,9 @@ int main(int argc, char *argv[])
                                         (unsigned long) packet.xid, xid);
                                 continue;
                         }
+                        /* Ignore packets that aren't for us */
+                        if (memcmp(client_config.arp,packet.chaddr,6))
+                                continue;
 
                         if ((message = get_option(&packet, DHCP_MESSAGE_TYPE)) == NULL) {
                                 DEBUG(LOG_ERR, "couldnt get option from packet -- ignoring");