Avoid segfaults by not using snprintf to copy strings.

3 files changed, 6 insertions, 3 deletions

diff --git a/lash.c b/lash.c
index a2969082f..cbaf16ef8 100644
--- a/lash.c
+++ b/lash.c
@@ -1023,7 +1023,8 @@ static int parseCommand(char **commandPtr, struct job *job, struct jobSet *jobLi
 
                                         /* Make some space to hold just the backticked command */
                                         charptr1 = charptr2 = xmalloc(1+ptr-src);
-                                        snprintf(charptr1, 1+ptr-src, src);
+                                        memcpy(charptr1, src, ptr-src);
+                                        charptr1[ptr-src] = '\0';
                                         newJob = xmalloc(sizeof(struct job));
                                         /* Now parse and run the backticked command */
                                         if (!parseCommand(&charptr1, newJob, &njobList, inBg) 
diff --git a/sh.c b/sh.c
index a2969082f..cbaf16ef8 100644
--- a/sh.c
+++ b/sh.c
@@ -1023,7 +1023,8 @@ static int parseCommand(char **commandPtr, struct job *job, struct jobSet *jobLi
 
                                         /* Make some space to hold just the backticked command */
                                         charptr1 = charptr2 = xmalloc(1+ptr-src);
-                                        snprintf(charptr1, 1+ptr-src, src);
+                                        memcpy(charptr1, src, ptr-src);
+                                        charptr1[ptr-src] = '\0';
                                         newJob = xmalloc(sizeof(struct job));
                                         /* Now parse and run the backticked command */
                                         if (!parseCommand(&charptr1, newJob, &njobList, inBg) 
diff --git a/shell/lash.c b/shell/lash.c
index a2969082f..cbaf16ef8 100644
--- a/shell/lash.c
+++ b/shell/lash.c
@@ -1023,7 +1023,8 @@ static int parseCommand(char **commandPtr, struct job *job, struct jobSet *jobLi
 
                                         /* Make some space to hold just the backticked command */
                                         charptr1 = charptr2 = xmalloc(1+ptr-src);
-                                        snprintf(charptr1, 1+ptr-src, src);
+                                        memcpy(charptr1, src, ptr-src);
+                                        charptr1[ptr-src] = '\0';
                                         newJob = xmalloc(sizeof(struct job));
                                         /* Now parse and run the backticked command */
                                         if (!parseCommand(&charptr1, newJob, &njobList, inBg)