find: reset stat(2) flags before terminating

Commit a717c6844 (find: skip check for execute when not needed)
didn't reset stat(2) to its default behaviour (at my insistence).

This was incorrect.  The '-exec cmd {} +' action calls a nofork
'cmd' directly without spawning a new process.  If 'cmd' calls
'stat(2)' it won't be in its default state which can affect the
result.

Reintroduce the code to reset 'stat(2)'.

Adds 16 bytes.

(GitHub PR #600)

Signed-off-by: Ron Yorston <rmy@pobox.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/findutils/find.c b/findutils/find.c
index bdca6d08a..f2b5c4ace 100644
--- a/findutils/find.c
+++ b/findutils/find.c
@@ -1759,7 +1759,6 @@ int find_main(int argc UNUSED_PARAM, char **argv)
 #if ENABLE_PLATFORM_MINGW32
         /* Do this all the time. That way we prevent doing double-stats for
         executable files (the executable check above uses access() which calls stat again)
-        And we don't need to worry about resetting at the end since this isn't a NOFORK applet.
         */
         stat_flag = BB_STAT_NO_HAS_EXEC_FORMAT;
         stat(&stat_flag, NULL);
@@ -1776,6 +1775,13 @@ int find_main(int argc UNUSED_PARAM, char **argv)
                 }
         }
 
+#if ENABLE_PLATFORM_MINGW32
+        /* Reinstate costly check for executables.  flush_exec_plus() may
+         * invoke a NOFORK applet */
+        stat_flag = 0;
+        stat(&stat_flag, NULL);
+#endif
+
         IF_FEATURE_FIND_EXEC_PLUS(G.exitstatus |= flush_exec_plus();)
         return G.exitstatus;
 }