diff options
author | John Beppu <beppu@lbox.org> | 2000-06-27 04:56:45 +0000 |
---|---|---|
committer | John Beppu <beppu@lbox.org> | 2000-06-27 04:56:45 +0000 |
commit | 27b5924b96fc71a6f70ea1a13a5232fca2439e7d (patch) | |
tree | 48b399259f741dc28e34da5955a72292031e946b | |
parent | 8f425dbf9a8af9d3ee9848a18a641a93d9fe039b (diff) | |
download | busybox-w32-27b5924b96fc71a6f70ea1a13a5232fca2439e7d.tar.gz busybox-w32-27b5924b96fc71a6f70ea1a13a5232fca2439e7d.tar.bz2 busybox-w32-27b5924b96fc71a6f70ea1a13a5232fca2439e7d.zip |
+ littering my code w/ comments about what troubles me.
-rw-r--r-- | applets/busybox.c | 7 | ||||
-rw-r--r-- | busybox.c | 7 |
2 files changed, 12 insertions, 2 deletions
diff --git a/applets/busybox.c b/applets/busybox.c index 78f07e338..5f1c56bc3 100644 --- a/applets/busybox.c +++ b/applets/busybox.c | |||
@@ -420,10 +420,15 @@ int main(int argc, char **argv) | |||
420 | const struct BB_applet *a = applets; | 420 | const struct BB_applet *a = applets; |
421 | 421 | ||
422 | #ifdef BB_FEATURE_INSTALLER | 422 | #ifdef BB_FEATURE_INSTALLER |
423 | /* | ||
424 | * This style of argument parsing doesn't scale well | ||
425 | * in the event that busybox starts wanting more --options. | ||
426 | * If someone has a cleaner approach, by all means implement it. | ||
427 | */ | ||
423 | if (argc > 1 && (strcmp(argv[1], "--install") == 0)) { | 428 | if (argc > 1 && (strcmp(argv[1], "--install") == 0)) { |
424 | int use_symbolic_links = 0; | 429 | int use_symbolic_links = 0; |
425 | 430 | ||
426 | /* to use symlinks, or to not use symlinks... */ | 431 | /* to use symlinks, or not to use symlinks... */ |
427 | if (argc > 2) { | 432 | if (argc > 2) { |
428 | if ((strcmp(argv[2], "-s") == 0)) { | 433 | if ((strcmp(argv[2], "-s") == 0)) { |
429 | use_symbolic_links = 1; | 434 | use_symbolic_links = 1; |
@@ -420,10 +420,15 @@ int main(int argc, char **argv) | |||
420 | const struct BB_applet *a = applets; | 420 | const struct BB_applet *a = applets; |
421 | 421 | ||
422 | #ifdef BB_FEATURE_INSTALLER | 422 | #ifdef BB_FEATURE_INSTALLER |
423 | /* | ||
424 | * This style of argument parsing doesn't scale well | ||
425 | * in the event that busybox starts wanting more --options. | ||
426 | * If someone has a cleaner approach, by all means implement it. | ||
427 | */ | ||
423 | if (argc > 1 && (strcmp(argv[1], "--install") == 0)) { | 428 | if (argc > 1 && (strcmp(argv[1], "--install") == 0)) { |
424 | int use_symbolic_links = 0; | 429 | int use_symbolic_links = 0; |
425 | 430 | ||
426 | /* to use symlinks, or to not use symlinks... */ | 431 | /* to use symlinks, or not to use symlinks... */ |
427 | if (argc > 2) { | 432 | if (argc > 2) { |
428 | if ((strcmp(argv[2], "-s") == 0)) { | 433 | if ((strcmp(argv[2], "-s") == 0)) { |
429 | use_symbolic_links = 1; | 434 | use_symbolic_links = 1; |