aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Landley <rob@landley.net>2006-08-04 19:16:31 +0000
committerRob Landley <rob@landley.net>2006-08-04 19:16:31 +0000
commit27d07c9ce2f07cf85116455e356ba6c4b57f86fe (patch)
tree92c46c98529619d8cfc8d4762671041b4fb69258
parentdaf58ef61a5f78fa54958c0f7a53d13d792e0bb9 (diff)
downloadbusybox-w32-27d07c9ce2f07cf85116455e356ba6c4b57f86fe.tar.gz
busybox-w32-27d07c9ce2f07cf85116455e356ba6c4b57f86fe.tar.bz2
busybox-w32-27d07c9ce2f07cf85116455e356ba6c4b57f86fe.zip
Now that we have xopen3(), it's just plain unclean to have xopen() with
O_CREAT. Two users are still doing it (and thus getting permissions 777), I'm not sure what permissions they should be using but here they are changed to xopen3(). This costs us a dozen or so bytes, but removing the 777 from xopen() should get some of that back.
-rw-r--r--archival/unzip.c2
-rw-r--r--networking/ftpgetput.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/archival/unzip.c b/archival/unzip.c
index 68083e987..2585cbf3f 100644
--- a/archival/unzip.c
+++ b/archival/unzip.c
@@ -333,7 +333,7 @@ int unzip_main(int argc, char **argv)
333 overwrite = o_always; 333 overwrite = o_always;
334 case 'y': /* Open file and fall into unzip */ 334 case 'y': /* Open file and fall into unzip */
335 unzip_create_leading_dirs(dst_fn); 335 unzip_create_leading_dirs(dst_fn);
336 dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT); 336 dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT, 777);
337 case -1: /* Unzip */ 337 case -1: /* Unzip */
338 if (verbosity == v_normal) { 338 if (verbosity == v_normal) {
339 printf(" inflating: %s\n", dst_fn); 339 printf(" inflating: %s\n", dst_fn);
diff --git a/networking/ftpgetput.c b/networking/ftpgetput.c
index 767ace9fb..978601d26 100644
--- a/networking/ftpgetput.c
+++ b/networking/ftpgetput.c
@@ -166,7 +166,7 @@ static int ftp_receive(ftp_host_info_t *server, FILE *control_stream,
166 if (do_continue) { 166 if (do_continue) {
167 fd_local = xopen(local_path, O_APPEND | O_WRONLY); 167 fd_local = xopen(local_path, O_APPEND | O_WRONLY);
168 } else { 168 } else {
169 fd_local = xopen(local_path, O_CREAT | O_TRUNC | O_WRONLY); 169 fd_local = xopen3(local_path, O_CREAT | O_TRUNC | O_WRONLY, 777);
170 } 170 }
171 } 171 }
172 172