aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2016-10-26 16:26:45 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2016-10-26 16:26:45 +0200
commit350e686f3b04f41f623316706094f0e18a10c1cf (patch)
tree721ff03c6f5538060cc91f5c03bb9047c354970c
parentf15aa57a7f5edcbf3098873b8798c0ea7f496ed7 (diff)
downloadbusybox-w32-350e686f3b04f41f623316706094f0e18a10c1cf.tar.gz
busybox-w32-350e686f3b04f41f623316706094f0e18a10c1cf.tar.bz2
busybox-w32-350e686f3b04f41f623316706094f0e18a10c1cf.zip
ash: [PARSER] Recognise here-doc delimiters terminated by EOF
Upstream commit 1: Date: Wed, 26 Sep 2007 17:14:16 +0800 [PARSER] Recognise here-doc delimiters terminated by EOF Previously dash required a <newline> character to be present in order for a here-document delimiter to be detected. Allowing EOF in the absence of a <newline> to play the same purpose allows some intuitive scripts to succeed. POSIX seems to be silence on this so this should be OK. Test case: eval 'cat <<- NOT test NOT' echo OK Old result: test NOTOK New result: test OK Upstream commit 2: Date: Sat, 20 Oct 2007 18:49:31 +0800 [PARSER] Fix here-doc corruption The change [PARSER] Recognise here-doc delimiters terminated by EOF introduced a regerssion whereby lines starting with eofmark but are not equal to eofmark would be corrupted. This patch fixes it. Test case: cat << _ACEOF _ASBOX _ACEOF Old result: SASBOX New result: _ASBOX Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/ash.c12
-rw-r--r--shell/ash_test/ash-heredoc/heredoc6.right2
-rwxr-xr-xshell/ash_test/ash-heredoc/heredoc6.tests4
-rw-r--r--shell/ash_test/ash-heredoc/heredoc7.right1
-rwxr-xr-xshell/ash_test/ash-heredoc/heredoc7.tests3
-rw-r--r--shell/hush_test/hush-heredoc/heredoc6.right2
-rwxr-xr-xshell/hush_test/hush-heredoc/heredoc6.tests4
-rw-r--r--shell/hush_test/hush-heredoc/heredoc7.right1
-rwxr-xr-xshell/hush_test/hush-heredoc/heredoc7.tests3
9 files changed, 29 insertions, 3 deletions
diff --git a/shell/ash.c b/shell/ash.c
index 2cebfe2c0..e0828d4a7 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -11592,11 +11592,17 @@ checkend: {
11592 if (c == *eofmark) { 11592 if (c == *eofmark) {
11593 if (pfgets(line, sizeof(line)) != NULL) { 11593 if (pfgets(line, sizeof(line)) != NULL) {
11594 char *p, *q; 11594 char *p, *q;
11595 int cc;
11595 11596
11596 p = line; 11597 p = line;
11597 for (q = eofmark + 1; *q && *p == *q; p++, q++) 11598 for (q = eofmark + 1;; p++, q++) {
11598 continue; 11599 cc = *p;
11599 if (*p == '\n' && *q == '\0') { 11600 if (cc == '\n')
11601 cc = 0;
11602 if (!*q || cc != *q)
11603 break;
11604 }
11605 if (cc == *q) {
11600 c = PEOF; 11606 c = PEOF;
11601 nlnoprompt(); 11607 nlnoprompt();
11602 } else { 11608 } else {
diff --git a/shell/ash_test/ash-heredoc/heredoc6.right b/shell/ash_test/ash-heredoc/heredoc6.right
new file mode 100644
index 000000000..5d0f077cd
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc6.right
@@ -0,0 +1,2 @@
1test
2OK:0
diff --git a/shell/ash_test/ash-heredoc/heredoc6.tests b/shell/ash_test/ash-heredoc/heredoc6.tests
new file mode 100755
index 000000000..346f5949a
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc6.tests
@@ -0,0 +1,4 @@
1eval 'cat <<- NOT
2test
3NOT'
4echo OK:$?
diff --git a/shell/ash_test/ash-heredoc/heredoc7.right b/shell/ash_test/ash-heredoc/heredoc7.right
new file mode 100644
index 000000000..5d9c6c6c0
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc7.right
@@ -0,0 +1 @@
_ASBOX
diff --git a/shell/ash_test/ash-heredoc/heredoc7.tests b/shell/ash_test/ash-heredoc/heredoc7.tests
new file mode 100755
index 000000000..abd5941d9
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc7.tests
@@ -0,0 +1,3 @@
1cat << _ACEOF
2_ASBOX
3_ACEOF
diff --git a/shell/hush_test/hush-heredoc/heredoc6.right b/shell/hush_test/hush-heredoc/heredoc6.right
new file mode 100644
index 000000000..5d0f077cd
--- /dev/null
+++ b/shell/hush_test/hush-heredoc/heredoc6.right
@@ -0,0 +1,2 @@
1test
2OK:0
diff --git a/shell/hush_test/hush-heredoc/heredoc6.tests b/shell/hush_test/hush-heredoc/heredoc6.tests
new file mode 100755
index 000000000..346f5949a
--- /dev/null
+++ b/shell/hush_test/hush-heredoc/heredoc6.tests
@@ -0,0 +1,4 @@
1eval 'cat <<- NOT
2test
3NOT'
4echo OK:$?
diff --git a/shell/hush_test/hush-heredoc/heredoc7.right b/shell/hush_test/hush-heredoc/heredoc7.right
new file mode 100644
index 000000000..5d9c6c6c0
--- /dev/null
+++ b/shell/hush_test/hush-heredoc/heredoc7.right
@@ -0,0 +1 @@
_ASBOX
diff --git a/shell/hush_test/hush-heredoc/heredoc7.tests b/shell/hush_test/hush-heredoc/heredoc7.tests
new file mode 100755
index 000000000..abd5941d9
--- /dev/null
+++ b/shell/hush_test/hush-heredoc/heredoc7.tests
@@ -0,0 +1,3 @@
1cat << _ACEOF
2_ASBOX
3_ACEOF