diff options
author | Aaron Lehmann <aaronl@vitelius.com> | 2002-08-02 06:39:47 +0000 |
---|---|---|
committer | Aaron Lehmann <aaronl@vitelius.com> | 2002-08-02 06:39:47 +0000 |
commit | 49c024addd79be2b6024e33c69f5fafe9f5eff90 (patch) | |
tree | 599b501656d3ae8da4e025d22a2c1bf3506e2691 | |
parent | e85dbfdd80eb5f7674b17c86589d41007cc69688 (diff) | |
download | busybox-w32-49c024addd79be2b6024e33c69f5fafe9f5eff90.tar.gz busybox-w32-49c024addd79be2b6024e33c69f5fafe9f5eff90.tar.bz2 busybox-w32-49c024addd79be2b6024e33c69f5fafe9f5eff90.zip |
Remove ckfree, and replace all references with free. Remove freefunc,
which is also equivilent to free. Remove some if(x)free(x)
redundancies.
-rw-r--r-- | shell/ash.c | 100 |
1 files changed, 41 insertions, 59 deletions
diff --git a/shell/ash.c b/shell/ash.c index 64761b9aa..09975198d 100644 --- a/shell/ash.c +++ b/shell/ash.c | |||
@@ -308,7 +308,6 @@ static int stacknleft = MINSIZE; | |||
308 | #define STADJUST(amount, p) (p += (amount), sstrnleft -= (amount)) | 308 | #define STADJUST(amount, p) (p += (amount), sstrnleft -= (amount)) |
309 | #define grabstackstr(p) stalloc(stackblocksize() - sstrnleft) | 309 | #define grabstackstr(p) stalloc(stackblocksize() - sstrnleft) |
310 | 310 | ||
311 | #define ckfree(p) free((pointer)(p)) | ||
312 | 311 | ||
313 | 312 | ||
314 | #ifdef DEBUG | 313 | #ifdef DEBUG |
@@ -1305,7 +1304,7 @@ setalias(char *name, char *val) | |||
1305 | INTOFF; | 1304 | INTOFF; |
1306 | if (ap) { | 1305 | if (ap) { |
1307 | if (!(ap->flag & ALIASINUSE)) { | 1306 | if (!(ap->flag & ALIASINUSE)) { |
1308 | ckfree(ap->val); | 1307 | free(ap->val); |
1309 | } | 1308 | } |
1310 | ap->val = xstrdup(val); | 1309 | ap->val = xstrdup(val); |
1311 | ap->flag &= ~ALIASDEAD; | 1310 | ap->flag &= ~ALIASDEAD; |
@@ -1446,9 +1445,9 @@ freealias(struct alias *ap) | |||
1446 | } | 1445 | } |
1447 | 1446 | ||
1448 | next = ap->next; | 1447 | next = ap->next; |
1449 | ckfree(ap->name); | 1448 | free(ap->name); |
1450 | ckfree(ap->val); | 1449 | free(ap->val); |
1451 | ckfree(ap); | 1450 | free(ap); |
1452 | return next; | 1451 | return next; |
1453 | } | 1452 | } |
1454 | 1453 | ||
@@ -2172,18 +2171,6 @@ copyfunc(union node *n) | |||
2172 | } | 2171 | } |
2173 | 2172 | ||
2174 | /* | 2173 | /* |
2175 | * Free a parse tree. | ||
2176 | */ | ||
2177 | |||
2178 | static void | ||
2179 | freefunc(union node *n) | ||
2180 | { | ||
2181 | if (n) | ||
2182 | ckfree(n); | ||
2183 | } | ||
2184 | |||
2185 | |||
2186 | /* | ||
2187 | * Add a new command entry, replacing any existing command entry for | 2174 | * Add a new command entry, replacing any existing command entry for |
2188 | * the same name. | 2175 | * the same name. |
2189 | */ | 2176 | */ |
@@ -2196,7 +2183,7 @@ addcmdentry(char *name, struct cmdentry *entry) | |||
2196 | INTOFF; | 2183 | INTOFF; |
2197 | cmdp = cmdlookup(name, 1); | 2184 | cmdp = cmdlookup(name, 1); |
2198 | if (cmdp->cmdtype == CMDFUNCTION) { | 2185 | if (cmdp->cmdtype == CMDFUNCTION) { |
2199 | freefunc(cmdp->param.func); | 2186 | free(cmdp->param.func); |
2200 | } | 2187 | } |
2201 | cmdp->cmdtype = entry->cmdtype; | 2188 | cmdp->cmdtype = entry->cmdtype; |
2202 | cmdp->param = entry->u; | 2189 | cmdp->param = entry->u; |
@@ -3130,7 +3117,7 @@ clear_traps(void) | |||
3130 | for (tp = trap ; tp < &trap[NSIG] ; tp++) { | 3117 | for (tp = trap ; tp < &trap[NSIG] ; tp++) { |
3131 | if (*tp && **tp) { /* trap not NULL or SIG_IGN */ | 3118 | if (*tp && **tp) { /* trap not NULL or SIG_IGN */ |
3132 | INTOFF; | 3119 | INTOFF; |
3133 | ckfree(*tp); | 3120 | free(*tp); |
3134 | *tp = NULL; | 3121 | *tp = NULL; |
3135 | if (tp != &trap[0]) | 3122 | if (tp != &trap[0]) |
3136 | setsignal(tp - trap); | 3123 | setsignal(tp - trap); |
@@ -3250,12 +3237,11 @@ popfile(void) | |||
3250 | INTOFF; | 3237 | INTOFF; |
3251 | if (pf->fd >= 0) | 3238 | if (pf->fd >= 0) |
3252 | close(pf->fd); | 3239 | close(pf->fd); |
3253 | if (pf->buf) | 3240 | free(pf->buf); |
3254 | ckfree(pf->buf); | ||
3255 | while (pf->strpush) | 3241 | while (pf->strpush) |
3256 | popstring(); | 3242 | popstring(); |
3257 | parsefile = pf->prev; | 3243 | parsefile = pf->prev; |
3258 | ckfree(pf); | 3244 | free(pf); |
3259 | parsenleft = parsefile->nleft; | 3245 | parsenleft = parsefile->nleft; |
3260 | parselleft = parsefile->lleft; | 3246 | parselleft = parsefile->lleft; |
3261 | parsenextc = parsefile->nextc; | 3247 | parsenextc = parsefile->nextc; |
@@ -3543,7 +3529,7 @@ printentry(struct tblentry *cmdp, int verbose) | |||
3543 | out1str("a function\n"); | 3529 | out1str("a function\n"); |
3544 | name = commandtext(cmdp->param.func); | 3530 | name = commandtext(cmdp->param.func); |
3545 | printf("%s() {\n %s\n}", cmdp->cmdname, name); | 3531 | printf("%s() {\n %s\n}", cmdp->cmdname, name); |
3546 | ckfree(name); | 3532 | free(name); |
3547 | INTON; | 3533 | INTON; |
3548 | } | 3534 | } |
3549 | #ifdef DEBUG | 3535 | #ifdef DEBUG |
@@ -3867,7 +3853,7 @@ clearcmdentry(int firstchange) | |||
3867 | || (cmdp->cmdtype == CMDBUILTIN && | 3853 | || (cmdp->cmdtype == CMDBUILTIN && |
3868 | builtinloc >= firstchange)) { | 3854 | builtinloc >= firstchange)) { |
3869 | *pp = cmdp->next; | 3855 | *pp = cmdp->next; |
3870 | ckfree(cmdp); | 3856 | free(cmdp); |
3871 | } else { | 3857 | } else { |
3872 | pp = &cmdp->next; | 3858 | pp = &cmdp->next; |
3873 | } | 3859 | } |
@@ -3894,8 +3880,8 @@ deletefuncs(void) | |||
3894 | while ((cmdp = *pp) != NULL) { | 3880 | while ((cmdp = *pp) != NULL) { |
3895 | if (cmdp->cmdtype == CMDFUNCTION) { | 3881 | if (cmdp->cmdtype == CMDFUNCTION) { |
3896 | *pp = cmdp->next; | 3882 | *pp = cmdp->next; |
3897 | freefunc(cmdp->param.func); | 3883 | free(cmdp->param.func); |
3898 | ckfree(cmdp); | 3884 | free(cmdp); |
3899 | } else { | 3885 | } else { |
3900 | pp = &cmdp->next; | 3886 | pp = &cmdp->next; |
3901 | } | 3887 | } |
@@ -3961,7 +3947,7 @@ delete_cmd_entry() | |||
3961 | INTOFF; | 3947 | INTOFF; |
3962 | cmdp = *lastcmdentry; | 3948 | cmdp = *lastcmdentry; |
3963 | *lastcmdentry = cmdp->next; | 3949 | *lastcmdentry = cmdp->next; |
3964 | ckfree(cmdp); | 3950 | free(cmdp); |
3965 | INTON; | 3951 | INTON; |
3966 | } | 3952 | } |
3967 | 3953 | ||
@@ -4010,7 +3996,7 @@ unsetfunc(char *name) | |||
4010 | struct tblentry *cmdp; | 3996 | struct tblentry *cmdp; |
4011 | 3997 | ||
4012 | if ((cmdp = cmdlookup(name, 0)) != NULL && cmdp->cmdtype == CMDFUNCTION) { | 3998 | if ((cmdp = cmdlookup(name, 0)) != NULL && cmdp->cmdtype == CMDFUNCTION) { |
4013 | freefunc(cmdp->param.func); | 3999 | free(cmdp->param.func); |
4014 | delete_cmd_entry(); | 4000 | delete_cmd_entry(); |
4015 | } | 4001 | } |
4016 | } | 4002 | } |
@@ -4526,7 +4512,7 @@ removerecordregions(int endoff) | |||
4526 | struct ifsregion *ifsp; | 4512 | struct ifsregion *ifsp; |
4527 | INTOFF; | 4513 | INTOFF; |
4528 | ifsp = ifsfirst.next->next; | 4514 | ifsp = ifsfirst.next->next; |
4529 | ckfree(ifsfirst.next); | 4515 | free(ifsfirst.next); |
4530 | ifsfirst.next = ifsp; | 4516 | ifsfirst.next = ifsp; |
4531 | INTON; | 4517 | INTON; |
4532 | } | 4518 | } |
@@ -4546,7 +4532,7 @@ removerecordregions(int endoff) | |||
4546 | struct ifsregion *ifsp; | 4532 | struct ifsregion *ifsp; |
4547 | INTOFF; | 4533 | INTOFF; |
4548 | ifsp = ifslastp->next->next; | 4534 | ifsp = ifslastp->next->next; |
4549 | ckfree(ifslastp->next); | 4535 | free(ifslastp->next); |
4550 | ifslastp->next = ifsp; | 4536 | ifslastp->next = ifsp; |
4551 | INTON; | 4537 | INTON; |
4552 | } | 4538 | } |
@@ -4709,8 +4695,7 @@ err1: | |||
4709 | err2: | 4695 | err2: |
4710 | if (in.fd >= 0) | 4696 | if (in.fd >= 0) |
4711 | close(in.fd); | 4697 | close(in.fd); |
4712 | if (in.buf) | 4698 | free(in.buf); |
4713 | ckfree(in.buf); | ||
4714 | if (in.jp) | 4699 | if (in.jp) |
4715 | exitstatus = waitforjob(in.jp); | 4700 | exitstatus = waitforjob(in.jp); |
4716 | handler = savehandler; | 4701 | handler = savehandler; |
@@ -5091,7 +5076,7 @@ ifsfree(void) | |||
5091 | struct ifsregion *ifsp; | 5076 | struct ifsregion *ifsp; |
5092 | INTOFF; | 5077 | INTOFF; |
5093 | ifsp = ifsfirst.next->next; | 5078 | ifsp = ifsfirst.next->next; |
5094 | ckfree(ifsfirst.next); | 5079 | free(ifsfirst.next); |
5095 | ifsfirst.next = ifsp; | 5080 | ifsfirst.next = ifsp; |
5096 | INTON; | 5081 | INTON; |
5097 | } | 5082 | } |
@@ -5203,7 +5188,7 @@ expandmeta(struct strlist *str, int flag) | |||
5203 | } | 5188 | } |
5204 | 5189 | ||
5205 | expmeta(expdir, str->text); | 5190 | expmeta(expdir, str->text); |
5206 | ckfree(expdir); | 5191 | free(expdir); |
5207 | expdir = NULL; | 5192 | expdir = NULL; |
5208 | INTON; | 5193 | INTON; |
5209 | if (exparg.lastp == savelastp) { | 5194 | if (exparg.lastp == savelastp) { |
@@ -5896,7 +5881,7 @@ popstring(void) | |||
5896 | } | 5881 | } |
5897 | } | 5882 | } |
5898 | if (sp->string != sp->ap->val) { | 5883 | if (sp->string != sp->ap->val) { |
5899 | ckfree(sp->string); | 5884 | free(sp->string); |
5900 | } | 5885 | } |
5901 | 5886 | ||
5902 | sp->ap->flag &= ~ALIASINUSE; | 5887 | sp->ap->flag &= ~ALIASINUSE; |
@@ -5910,7 +5895,7 @@ popstring(void) | |||
5910 | /*dprintf("*** calling popstring: restoring to '%s'\n", parsenextc);*/ | 5895 | /*dprintf("*** calling popstring: restoring to '%s'\n", parsenextc);*/ |
5911 | parsefile->strpush = sp->prev; | 5896 | parsefile->strpush = sp->prev; |
5912 | if (sp != &(parsefile->basestrpush)) | 5897 | if (sp != &(parsefile->basestrpush)) |
5913 | ckfree(sp); | 5898 | free(sp); |
5914 | INTON; | 5899 | INTON; |
5915 | } | 5900 | } |
5916 | 5901 | ||
@@ -6411,10 +6396,10 @@ freejob(struct job *jp) | |||
6411 | INTOFF; | 6396 | INTOFF; |
6412 | for (i = jp->nprocs, ps = jp->ps ; --i >= 0 ; ps++) { | 6397 | for (i = jp->nprocs, ps = jp->ps ; --i >= 0 ; ps++) { |
6413 | if (ps->cmd != nullstr) | 6398 | if (ps->cmd != nullstr) |
6414 | ckfree(ps->cmd); | 6399 | free(ps->cmd); |
6415 | } | 6400 | } |
6416 | if (jp->ps != &jp->ps0) | 6401 | if (jp->ps != &jp->ps0) |
6417 | ckfree(jp->ps); | 6402 | free(jp->ps); |
6418 | jp->used = 0; | 6403 | jp->used = 0; |
6419 | #ifdef CONFIG_ASH_JOB_CONTROL | 6404 | #ifdef CONFIG_ASH_JOB_CONTROL |
6420 | if (curjob == jp - jobtab + 1) | 6405 | if (curjob == jp - jobtab + 1) |
@@ -6555,7 +6540,7 @@ makejob(const union node *node, int nprocs) | |||
6555 | for (i = 0; i < njobs; i++) | 6540 | for (i = 0; i < njobs; i++) |
6556 | if (jp[i].ps == &jobtab[i].ps0) | 6541 | if (jp[i].ps == &jobtab[i].ps0) |
6557 | jp[i].ps = &jp[i].ps0; | 6542 | jp[i].ps = &jp[i].ps0; |
6558 | ckfree(jobtab); | 6543 | free(jobtab); |
6559 | jobtab = jp; | 6544 | jobtab = jp; |
6560 | } | 6545 | } |
6561 | jp = jobtab + njobs; | 6546 | jp = jobtab + njobs; |
@@ -7368,7 +7353,6 @@ commandtext(const union node *n) | |||
7368 | 7353 | ||
7369 | static void waitonint(int sig) { | 7354 | static void waitonint(int sig) { |
7370 | intreceived = 1; | 7355 | intreceived = 1; |
7371 | return; | ||
7372 | } | 7356 | } |
7373 | 7357 | ||
7374 | #ifdef CONFIG_ASH_MAIL | 7358 | #ifdef CONFIG_ASH_MAIL |
@@ -7840,7 +7824,7 @@ popstackmark(struct stackmark *mark) | |||
7840 | while (stackp != mark->stackp) { | 7824 | while (stackp != mark->stackp) { |
7841 | sp = stackp; | 7825 | sp = stackp; |
7842 | stackp = sp->prev; | 7826 | stackp = sp->prev; |
7843 | ckfree(sp); | 7827 | free(sp); |
7844 | } | 7828 | } |
7845 | stacknxt = mark->stacknxt; | 7829 | stacknxt = mark->stacknxt; |
7846 | stacknleft = mark->stacknleft; | 7830 | stacknleft = mark->stacknleft; |
@@ -9025,8 +9009,8 @@ freeparam(volatile struct shparam *param) | |||
9025 | 9009 | ||
9026 | if (param->malloc) { | 9010 | if (param->malloc) { |
9027 | for (ap = param->p ; *ap ; ap++) | 9011 | for (ap = param->p ; *ap ; ap++) |
9028 | ckfree(*ap); | 9012 | free(*ap); |
9029 | ckfree(param->p); | 9013 | free(param->p); |
9030 | } | 9014 | } |
9031 | } | 9015 | } |
9032 | 9016 | ||
@@ -9051,7 +9035,7 @@ shiftcmd(int argc, char **argv) | |||
9051 | shellparam.nparam -= n; | 9035 | shellparam.nparam -= n; |
9052 | for (ap1 = shellparam.p ; --n >= 0 ; ap1++) { | 9036 | for (ap1 = shellparam.p ; --n >= 0 ; ap1++) { |
9053 | if (shellparam.malloc) | 9037 | if (shellparam.malloc) |
9054 | ckfree(*ap1); | 9038 | free(*ap1); |
9055 | } | 9039 | } |
9056 | ap2 = shellparam.p; | 9040 | ap2 = shellparam.p; |
9057 | while ((*ap2++ = *ap1++) != NULL); | 9041 | while ((*ap2++ = *ap1++) != NULL); |
@@ -10673,8 +10657,7 @@ parsebackq: { | |||
10673 | 10657 | ||
10674 | savepbq = parsebackquote; | 10658 | savepbq = parsebackquote; |
10675 | if (setjmp(jmploc.loc)) { | 10659 | if (setjmp(jmploc.loc)) { |
10676 | if (str) | 10660 | free(str); |
10677 | ckfree(str); | ||
10678 | parsebackquote = 0; | 10661 | parsebackquote = 0; |
10679 | handler = savehandler; | 10662 | handler = savehandler; |
10680 | longjmp(handler->loc, 1); | 10663 | longjmp(handler->loc, 1); |
@@ -10794,7 +10777,7 @@ done: | |||
10794 | memcpy(out, str, savelen); | 10777 | memcpy(out, str, savelen); |
10795 | STADJUST(savelen, out); | 10778 | STADJUST(savelen, out); |
10796 | INTOFF; | 10779 | INTOFF; |
10797 | ckfree(str); | 10780 | free(str); |
10798 | str = NULL; | 10781 | str = NULL; |
10799 | INTON; | 10782 | INTON; |
10800 | } | 10783 | } |
@@ -11237,7 +11220,7 @@ popredir(void) | |||
11237 | } | 11220 | } |
11238 | } | 11221 | } |
11239 | redirlist = rp->next; | 11222 | redirlist = rp->next; |
11240 | ckfree(rp); | 11223 | free(rp); |
11241 | INTON; | 11224 | INTON; |
11242 | } | 11225 | } |
11243 | 11226 | ||
@@ -11683,8 +11666,7 @@ trapcmd(int argc, char **argv) | |||
11683 | else | 11666 | else |
11684 | action = xstrdup(action); | 11667 | action = xstrdup(action); |
11685 | } | 11668 | } |
11686 | if (trap[signo]) | 11669 | free(trap[signo]); |
11687 | ckfree(trap[signo]); | ||
11688 | trap[signo] = action; | 11670 | trap[signo] = action; |
11689 | if (signo != 0) | 11671 | if (signo != 0) |
11690 | setsignal(signo); | 11672 | setsignal(signo); |
@@ -11995,7 +11977,7 @@ setvareq(char *s, int flags) | |||
11995 | (*vp->func)(strchr(s, '=') + 1); | 11977 | (*vp->func)(strchr(s, '=') + 1); |
11996 | 11978 | ||
11997 | if ((vp->flags & (VTEXTFIXED|VSTACK)) == 0) | 11979 | if ((vp->flags & (VTEXTFIXED|VSTACK)) == 0) |
11998 | ckfree(vp->text); | 11980 | free(vp->text); |
11999 | 11981 | ||
12000 | vp->flags &= ~(VTEXTFIXED|VSTACK|VUNSET); | 11982 | vp->flags &= ~(VTEXTFIXED|VSTACK|VUNSET); |
12001 | vp->flags |= flags; | 11983 | vp->flags |= flags; |
@@ -12122,9 +12104,9 @@ shprocvar(void) { | |||
12122 | if ((vp->flags & VEXPORT) == 0) { | 12104 | if ((vp->flags & VEXPORT) == 0) { |
12123 | *prev = vp->next; | 12105 | *prev = vp->next; |
12124 | if ((vp->flags & VTEXTFIXED) == 0) | 12106 | if ((vp->flags & VTEXTFIXED) == 0) |
12125 | ckfree(vp->text); | 12107 | free(vp->text); |
12126 | if ((vp->flags & VSTRFIXED) == 0) | 12108 | if ((vp->flags & VSTRFIXED) == 0) |
12127 | ckfree(vp); | 12109 | free(vp); |
12128 | } else { | 12110 | } else { |
12129 | if (vp->flags & VSTACK) { | 12111 | if (vp->flags & VSTACK) { |
12130 | vp->text = xstrdup(vp->text); | 12112 | vp->text = xstrdup(vp->text); |
@@ -12270,16 +12252,16 @@ poplocalvars() { | |||
12270 | vp = lvp->vp; | 12252 | vp = lvp->vp; |
12271 | if (vp == NULL) { /* $- saved */ | 12253 | if (vp == NULL) { /* $- saved */ |
12272 | memcpy(optet_vals, lvp->text, sizeof optet_vals); | 12254 | memcpy(optet_vals, lvp->text, sizeof optet_vals); |
12273 | ckfree(lvp->text); | 12255 | free(lvp->text); |
12274 | } else if ((lvp->flags & (VUNSET|VSTRFIXED)) == VUNSET) { | 12256 | } else if ((lvp->flags & (VUNSET|VSTRFIXED)) == VUNSET) { |
12275 | (void)unsetvar(vp->text); | 12257 | (void)unsetvar(vp->text); |
12276 | } else { | 12258 | } else { |
12277 | if ((vp->flags & VTEXTFIXED) == 0) | 12259 | if ((vp->flags & VTEXTFIXED) == 0) |
12278 | ckfree(vp->text); | 12260 | free(vp->text); |
12279 | vp->flags = lvp->flags; | 12261 | vp->flags = lvp->flags; |
12280 | vp->text = lvp->text; | 12262 | vp->text = lvp->text; |
12281 | } | 12263 | } |
12282 | ckfree(lvp); | 12264 | free(lvp); |
12283 | } | 12265 | } |
12284 | } | 12266 | } |
12285 | 12267 | ||
@@ -12353,9 +12335,9 @@ unsetvar(const char *s) | |||
12353 | vp->flags |= VUNSET; | 12335 | vp->flags |= VUNSET; |
12354 | if ((vp->flags & VSTRFIXED) == 0) { | 12336 | if ((vp->flags & VSTRFIXED) == 0) { |
12355 | if ((vp->flags & VTEXTFIXED) == 0) | 12337 | if ((vp->flags & VTEXTFIXED) == 0) |
12356 | ckfree(vp->text); | 12338 | free(vp->text); |
12357 | *vpp = vp->next; | 12339 | *vpp = vp->next; |
12358 | ckfree(vp); | 12340 | free(vp); |
12359 | } | 12341 | } |
12360 | INTON; | 12342 | INTON; |
12361 | return (0); | 12343 | return (0); |
@@ -12440,7 +12422,7 @@ findvar(struct var **vpp, const char *name) | |||
12440 | /* | 12422 | /* |
12441 | * Copyright (c) 1999 Herbert Xu <herbert@debian.org> | 12423 | * Copyright (c) 1999 Herbert Xu <herbert@debian.org> |
12442 | * This file contains code for the times builtin. | 12424 | * This file contains code for the times builtin. |
12443 | * $Id: ash.c,v 1.55 2002/07/11 11:11:51 andersen Exp $ | 12425 | * $Id: ash.c,v 1.56 2002/08/02 06:39:47 aaronl Exp $ |
12444 | */ | 12426 | */ |
12445 | static int timescmd (int argc, char **argv) | 12427 | static int timescmd (int argc, char **argv) |
12446 | { | 12428 | { |