diff options
author | aldot <aldot@69ca8d6d-28ef-0310-b511-8ec308f3f277> | 2006-06-04 16:05:02 +0000 |
---|---|---|
committer | aldot <aldot@69ca8d6d-28ef-0310-b511-8ec308f3f277> | 2006-06-04 16:05:02 +0000 |
commit | 62b0e2a4eb86f351f459050a2b5f347b9a6c2e25 (patch) | |
tree | 8f3d93ba1eaf148433dcba0078fcc344ddcb2f00 | |
parent | 96f5cde25e55a9f9cfd33d8f54c19cbc93db6655 (diff) | |
download | busybox-w32-62b0e2a4eb86f351f459050a2b5f347b9a6c2e25.tar.gz busybox-w32-62b0e2a4eb86f351f459050a2b5f347b9a6c2e25.tar.bz2 busybox-w32-62b0e2a4eb86f351f459050a2b5f347b9a6c2e25.zip |
- add note about removing superfluous fmt specifiers
git-svn-id: svn://busybox.net/trunk/busybox@15281 69ca8d6d-28ef-0310-b511-8ec308f3f277
-rw-r--r-- | TODO | 9 |
1 files changed, 7 insertions, 2 deletions
@@ -259,12 +259,17 @@ Minor stuff: | |||
259 | if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); | 259 | if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); |
260 | Unfortunately, that needs linux/watchdog.h and that contains unfiltered | 260 | Unfortunately, that needs linux/watchdog.h and that contains unfiltered |
261 | kernel types on some distros, which breaks the build. | 261 | kernel types on some distros, which breaks the build. |
262 | 262 | --- | |
263 | use bb_error_msg where appropriate: See | 263 | use bb_error_msg where appropriate: See |
264 | egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" | 264 | egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" |
265 | 265 | --- | |
266 | use bb_perror_msg where appropriate: See | 266 | use bb_perror_msg where appropriate: See |
267 | egrep "[^_]perror" | 267 | egrep "[^_]perror" |
268 | --- | ||
269 | Remove superfluous fmt occurances: e.g. | ||
270 | fprintf(stderr, "%s: %s not found\n", "unalias", *argptr); | ||
271 | -> fprintf(stderr, "unalias: %s not found\n", *argptr); | ||
272 | --- | ||
268 | 273 | ||
269 | 274 | ||
270 | Code cleanup: | 275 | Code cleanup: |