aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author"Vladimir N. Oleynik" <dzo@simtreas.ru>2006-02-28 08:23:27 +0000
committer"Vladimir N. Oleynik" <dzo@simtreas.ru>2006-02-28 08:23:27 +0000
commit73804d6f7e6220e220ac167bd77ef210ea6e3d68 (patch)
treef2c617ba2047113c2661a3fd5fc87997dc37e184
parent8bbee852149faacd89558be2449a69d75c4cb9cf (diff)
downloadbusybox-w32-73804d6f7e6220e220ac167bd77ef210ea6e3d68.tar.gz
busybox-w32-73804d6f7e6220e220ac167bd77ef210ea6e3d68.tar.bz2
busybox-w32-73804d6f7e6220e220ac167bd77ef210ea6e3d68.zip
more security: don't start shell code from argv
-rw-r--r--miscutils/eject.c2
-rw-r--r--util-linux/setarch.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/miscutils/eject.c b/miscutils/eject.c
index 2643f36d5..189f54510 100644
--- a/miscutils/eject.c
+++ b/miscutils/eject.c
@@ -43,7 +43,7 @@ extern int eject_main(int argc, char **argv)
43 } 43 }
44 if (ioctl(bb_xopen(device, (O_RDONLY | O_NONBLOCK)), 44 if (ioctl(bb_xopen(device, (O_RDONLY | O_NONBLOCK)),
45 (flags ? CDROMCLOSETRAY : CDROMEJECT))) { 45 (flags ? CDROMCLOSETRAY : CDROMEJECT))) {
46 bb_perror_msg_and_die(device); 46 bb_perror_msg_and_die("%s", device);
47 } 47 }
48 return (EXIT_SUCCESS); 48 return (EXIT_SUCCESS);
49} 49}
diff --git a/util-linux/setarch.c b/util-linux/setarch.c
index 4a5853adc..33588e4ee 100644
--- a/util-linux/setarch.c
+++ b/util-linux/setarch.c
@@ -49,5 +49,5 @@ retry:
49 execvp(argv[0], argv); 49 execvp(argv[0], argv);
50 50
51failure: 51failure:
52 bb_perror_msg_and_die(argv[0]); 52 bb_perror_msg_and_die("%s", argv[0]);
53} 53}