diff options
| author | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2018-03-02 17:39:36 +0100 |
|---|---|---|
| committer | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2018-10-01 22:45:36 +0200 |
| commit | 7effa31cd4b5c76d20f63882002eb023f05aaa46 (patch) | |
| tree | d2b4562ff8b761bc46699691a2769b60d5cc0ffa | |
| parent | 349d72c19ced4fae64e8fdd5792b37e78ac2f616 (diff) | |
| download | busybox-w32-7effa31cd4b5c76d20f63882002eb023f05aaa46.tar.gz busybox-w32-7effa31cd4b5c76d20f63882002eb023f05aaa46.tar.bz2 busybox-w32-7effa31cd4b5c76d20f63882002eb023f05aaa46.zip | |
brctl: use a single buffer for brname and ifname
function old new delta
brctl_main 1681 1675 -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-6) Total: -6 bytes
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
| -rw-r--r-- | networking/brctl.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/networking/brctl.c b/networking/brctl.c index 5d5f0af30..ba4a714f8 100644 --- a/networking/brctl.c +++ b/networking/brctl.c | |||
| @@ -241,7 +241,7 @@ int brctl_main(int argc UNUSED_PARAM, char **argv) | |||
| 241 | 241 | ||
| 242 | #if ENABLE_FEATURE_BRCTL_SHOW | 242 | #if ENABLE_FEATURE_BRCTL_SHOW |
| 243 | if (key == ARG_show) { /* show */ | 243 | if (key == ARG_show) { /* show */ |
| 244 | char brname[IFNAMSIZ]; | 244 | char buf[IFNAMSIZ]; |
| 245 | int bridx[MAX_PORTS]; | 245 | int bridx[MAX_PORTS]; |
| 246 | int i, num; | 246 | int i, num; |
| 247 | arm_ioctl(args, BRCTL_GET_BRIDGES, | 247 | arm_ioctl(args, BRCTL_GET_BRIDGES, |
| @@ -249,19 +249,18 @@ int brctl_main(int argc UNUSED_PARAM, char **argv) | |||
| 249 | num = xioctl(fd, SIOCGIFBR, args); | 249 | num = xioctl(fd, SIOCGIFBR, args); |
| 250 | puts("bridge name\tbridge id\t\tSTP enabled\tinterfaces"); | 250 | puts("bridge name\tbridge id\t\tSTP enabled\tinterfaces"); |
| 251 | for (i = 0; i < num; i++) { | 251 | for (i = 0; i < num; i++) { |
| 252 | char ifname[IFNAMSIZ]; | ||
| 253 | int j, tabs; | 252 | int j, tabs; |
| 254 | struct __bridge_info bi; | 253 | struct __bridge_info bi; |
| 255 | unsigned char *x; | 254 | unsigned char *x; |
| 256 | 255 | ||
| 257 | if (!if_indextoname(bridx[i], brname)) | 256 | if (!if_indextoname(bridx[i], buf)) |
| 258 | bb_perror_msg_and_die("can't get bridge name for index %d", i); | 257 | bb_perror_msg_and_die("can't get bridge name for index %d", i); |
| 259 | strncpy_IFNAMSIZ(ifr.ifr_name, brname); | 258 | strncpy_IFNAMSIZ(ifr.ifr_name, buf); |
| 260 | 259 | ||
| 261 | arm_ioctl(args, BRCTL_GET_BRIDGE_INFO, | 260 | arm_ioctl(args, BRCTL_GET_BRIDGE_INFO, |
| 262 | (unsigned long) &bi, 0); | 261 | (unsigned long) &bi, 0); |
| 263 | xioctl(fd, SIOCDEVPRIVATE, &ifr); | 262 | xioctl(fd, SIOCDEVPRIVATE, &ifr); |
| 264 | printf("%s\t\t", brname); | 263 | printf("%s\t\t", buf); |
| 265 | 264 | ||
| 266 | /* print bridge id */ | 265 | /* print bridge id */ |
| 267 | x = (unsigned char *) &bi.bridge_id; | 266 | x = (unsigned char *) &bi.bridge_id; |
| @@ -280,13 +279,13 @@ int brctl_main(int argc UNUSED_PARAM, char **argv) | |||
| 280 | for (j = 0; j < MAX_PORTS; j++) { | 279 | for (j = 0; j < MAX_PORTS; j++) { |
| 281 | if (!ifidx[j]) | 280 | if (!ifidx[j]) |
| 282 | continue; | 281 | continue; |
| 283 | if (!if_indextoname(ifidx[j], ifname)) | 282 | if (!if_indextoname(ifidx[j], buf)) |
| 284 | bb_perror_msg_and_die("can't get interface name for index %d", j); | 283 | bb_perror_msg_and_die("can't get interface name for index %d", j); |
| 285 | if (tabs) | 284 | if (tabs) |
| 286 | printf("\t\t\t\t\t"); | 285 | printf("\t\t\t\t\t"); |
| 287 | else | 286 | else |
| 288 | tabs = 1; | 287 | tabs = 1; |
| 289 | printf("\t\t%s\n", ifname); | 288 | printf("\t\t%s\n", buf); |
| 290 | } | 289 | } |
| 291 | if (!tabs) /* bridge has no interfaces */ | 290 | if (!tabs) /* bridge has no interfaces */ |
| 292 | bb_putchar('\n'); | 291 | bb_putchar('\n'); |
