aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMing Liu <peter.x.liu@external.atlascopco.com>2017-06-02 10:47:23 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2017-06-13 19:13:37 +0200
commit978307f8a19084ffb6e977ee28c731445e37dbbd (patch)
tree367ff8dd42c7bb7b4f9c562f079b4a3e8ccfc6c2
parent192dce4b84fb32346ebc5194de7daa5da3b8d1b4 (diff)
downloadbusybox-w32-978307f8a19084ffb6e977ee28c731445e37dbbd.tar.gz
busybox-w32-978307f8a19084ffb6e977ee28c731445e37dbbd.tar.bz2
busybox-w32-978307f8a19084ffb6e977ee28c731445e37dbbd.zip
tar: add IF_FEATURE_* checks
A following linking error was observed: | ========== | archival/lib.a(tar.o): In function `tar_main': | archival/tar.c:1168: undefined reference to `unpack_Z_stream' | archival/tar.c:1168: undefined reference to `unpack_Z_stream' | ld: busybox_unstripped: hidden symbol `unpack_Z_stream' isn't defined | ld: final link failed: Bad value this happened with clang compiler, with the following configs: | CONFIG_TAR=y | # CONFIG_FEATURE_SEAMLESS_Z is not set which can be fixed by adding IF_FEATURE_* checks in. Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--archival/tar.c25
1 files changed, 15 insertions, 10 deletions
diff --git a/archival/tar.c b/archival/tar.c
index b70e00a8b..7598b71e3 100644
--- a/archival/tar.c
+++ b/archival/tar.c
@@ -1216,21 +1216,26 @@ int tar_main(int argc UNUSED_PARAM, char **argv)
1216 USE_FOR_MMU(IF_DESKTOP(long long) int FAST_FUNC (*xformer)(transformer_state_t *xstate);) 1216 USE_FOR_MMU(IF_DESKTOP(long long) int FAST_FUNC (*xformer)(transformer_state_t *xstate);)
1217 USE_FOR_NOMMU(const char *xformer_prog;) 1217 USE_FOR_NOMMU(const char *xformer_prog;)
1218 1218
1219 if (opt & OPT_COMPRESS) 1219 if (opt & OPT_COMPRESS) {
1220 USE_FOR_MMU(xformer = unpack_Z_stream;) 1220 USE_FOR_MMU(IF_FEATURE_SEAMLESS_Z(xformer = unpack_Z_stream;))
1221 USE_FOR_NOMMU(xformer_prog = "uncompress";) 1221 USE_FOR_NOMMU(xformer_prog = "uncompress";)
1222 if (opt & OPT_GZIP) 1222 }
1223 USE_FOR_MMU(xformer = unpack_gz_stream;) 1223 if (opt & OPT_GZIP) {
1224 USE_FOR_MMU(IF_FEATURE_SEAMLESS_GZ(xformer = unpack_gz_stream;))
1224 USE_FOR_NOMMU(xformer_prog = "gunzip";) 1225 USE_FOR_NOMMU(xformer_prog = "gunzip";)
1225 if (opt & OPT_BZIP2) 1226 }
1226 USE_FOR_MMU(xformer = unpack_bz2_stream;) 1227 if (opt & OPT_BZIP2) {
1228 USE_FOR_MMU(IF_FEATURE_SEAMLESS_BZ2(xformer = unpack_bz2_stream;))
1227 USE_FOR_NOMMU(xformer_prog = "bunzip2";) 1229 USE_FOR_NOMMU(xformer_prog = "bunzip2";)
1228 if (opt & OPT_LZMA) 1230 }
1229 USE_FOR_MMU(xformer = unpack_lzma_stream;) 1231 if (opt & OPT_LZMA) {
1232 USE_FOR_MMU(IF_FEATURE_SEAMLESS_LZMA(xformer = unpack_lzma_stream;))
1230 USE_FOR_NOMMU(xformer_prog = "unlzma";) 1233 USE_FOR_NOMMU(xformer_prog = "unlzma";)
1231 if (opt & OPT_XZ) 1234 }
1232 USE_FOR_MMU(xformer = unpack_xz_stream;) 1235 if (opt & OPT_XZ) {
1236 USE_FOR_MMU(IF_FEATURE_SEAMLESS_XZ(xformer = unpack_xz_stream;))
1233 USE_FOR_NOMMU(xformer_prog = "unxz";) 1237 USE_FOR_NOMMU(xformer_prog = "unxz";)
1238 }
1234 1239
1235 fork_transformer_with_sig(tar_handle->src_fd, xformer, xformer_prog); 1240 fork_transformer_with_sig(tar_handle->src_fd, xformer, xformer_prog);
1236 /* Can't lseek over pipes */ 1241 /* Can't lseek over pipes */