diff options
author | Ron Yorston <rmy@pobox.com> | 2019-12-16 09:31:10 +0000 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2020-04-30 17:30:02 +0200 |
commit | 9f3b410006956c59896034bb790b20e655f8b4cb (patch) | |
tree | ffb97991063a42b85a4cc14e91317558d1f536b7 | |
parent | 981b2eff814bd186188ad66a32990a6d17b37a3e (diff) | |
download | busybox-w32-9f3b410006956c59896034bb790b20e655f8b4cb.tar.gz busybox-w32-9f3b410006956c59896034bb790b20e655f8b4cb.tar.bz2 busybox-w32-9f3b410006956c59896034bb790b20e655f8b4cb.zip |
ash,hush: drop pointer check before calls to show_history
show_history() checks that its argument in non-null so there's
no need to repeat the test at call sites.
function old new delta
historycmd 25 17 -8
builtin_history 29 21 -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-16) Total: -16 bytes
Signed-off-by: Ron Yorston <rmy@pobox.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r-- | shell/ash.c | 3 | ||||
-rw-r--r-- | shell/hush.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/shell/ash.c b/shell/ash.c index a11b1d67d..2a4c839a7 100644 --- a/shell/ash.c +++ b/shell/ash.c | |||
@@ -13824,8 +13824,7 @@ helpcmd(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) | |||
13824 | static int FAST_FUNC | 13824 | static int FAST_FUNC |
13825 | historycmd(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) | 13825 | historycmd(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) |
13826 | { | 13826 | { |
13827 | if (line_input_state) | 13827 | show_history(line_input_state); |
13828 | show_history(line_input_state); | ||
13829 | return EXIT_SUCCESS; | 13828 | return EXIT_SUCCESS; |
13830 | } | 13829 | } |
13831 | #endif | 13830 | #endif |
diff --git a/shell/hush.c b/shell/hush.c index 0a92f5da7..cab7ea5b0 100644 --- a/shell/hush.c +++ b/shell/hush.c | |||
@@ -10461,8 +10461,7 @@ static int FAST_FUNC builtin_help(char **argv UNUSED_PARAM) | |||
10461 | #if MAX_HISTORY && ENABLE_FEATURE_EDITING | 10461 | #if MAX_HISTORY && ENABLE_FEATURE_EDITING |
10462 | static int FAST_FUNC builtin_history(char **argv UNUSED_PARAM) | 10462 | static int FAST_FUNC builtin_history(char **argv UNUSED_PARAM) |
10463 | { | 10463 | { |
10464 | if (G.line_input_state) | 10464 | show_history(G.line_input_state); |
10465 | show_history(G.line_input_state); | ||
10466 | return EXIT_SUCCESS; | 10465 | return EXIT_SUCCESS; |
10467 | } | 10466 | } |
10468 | #endif | 10467 | #endif |