diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2017-08-05 01:29:12 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2017-08-05 01:29:12 +0200 |
commit | 9f59849daab488b5a46926a2979e8b957021e844 (patch) | |
tree | 874c7feabc9c931ee2c2be0dddc02414562a0c58 | |
parent | b182e9ad6011909fdb76358431d23d195febaf54 (diff) | |
download | busybox-w32-9f59849daab488b5a46926a2979e8b957021e844.tar.gz busybox-w32-9f59849daab488b5a46926a2979e8b957021e844.tar.bz2 busybox-w32-9f59849daab488b5a46926a2979e8b957021e844.zip |
blockdev, fsfreeze, fstrim, mountpoint: make NOEXEC
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r-- | NOFORK_NOEXEC.lst | 8 | ||||
-rw-r--r-- | util-linux/blockdev.c | 2 | ||||
-rw-r--r-- | util-linux/fsfreeze.c | 2 | ||||
-rw-r--r-- | util-linux/fstrim.c | 2 | ||||
-rw-r--r-- | util-linux/mountpoint.c | 2 |
5 files changed, 8 insertions, 8 deletions
diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst index ad49cd809..b2f410177 100644 --- a/NOFORK_NOEXEC.lst +++ b/NOFORK_NOEXEC.lst | |||
@@ -51,7 +51,7 @@ basename - NOFORK | |||
51 | beep | 51 | beep |
52 | blkdiscard | 52 | blkdiscard |
53 | blkid | 53 | blkid |
54 | blockdev - noexec candidate (rather simple), leaks fd | 54 | blockdev - noexec. leaks fd |
55 | bootchartd - daemon | 55 | bootchartd - daemon |
56 | brctl | 56 | brctl |
57 | bunzip2 - runner | 57 | bunzip2 - runner |
@@ -134,8 +134,8 @@ free - nofork candidate(struct globals, needs to close /proc/meminfo fd) | |||
134 | freeramdisk - leaks: open+ioctl_or_perror_and_die | 134 | freeramdisk - leaks: open+ioctl_or_perror_and_die |
135 | fsck - interactive, longterm | 135 | fsck - interactive, longterm |
136 | fsck.minix - needs ^C | 136 | fsck.minix - needs ^C |
137 | fsfreeze - noexec candidate (it's very simple), leaks: open+xioctl | 137 | fsfreeze - noexec. leaks: open+xioctl |
138 | fstrim - noexec candidate (it's very simple), leaks: open+xioctl, find_block_device -> readdir+xstrdup | 138 | fstrim - noexec. leaks: open+xioctl, find_block_device -> readdir+xstrdup |
139 | fsync - NOFORK | 139 | fsync - NOFORK |
140 | ftpd - daemon | 140 | ftpd - daemon |
141 | ftpget - runner | 141 | ftpget - runner |
@@ -236,7 +236,7 @@ modinfo - noexec | |||
236 | modprobe - noexec | 236 | modprobe - noexec |
237 | more - interactive, longterm | 237 | more - interactive, longterm |
238 | mount - suid | 238 | mount - suid |
239 | mountpoint - noexec candidate, leaks: option -n "print dev name": find_block_device -> readdir+xstrdup | 239 | mountpoint - noexec. leaks: option -n "print dev name": find_block_device -> readdir+xstrdup |
240 | mpstat - noexec candidate (it's a measuring tool, putting less load by itself is good), complex | 240 | mpstat - noexec candidate (it's a measuring tool, putting less load by itself is good), complex |
241 | mt - rare | 241 | mt - rare |
242 | mv - noexec candidate, runner | 242 | mv - noexec candidate, runner |
diff --git a/util-linux/blockdev.c b/util-linux/blockdev.c index 9e1fef206..e53ade995 100644 --- a/util-linux/blockdev.c +++ b/util-linux/blockdev.c | |||
@@ -11,7 +11,7 @@ | |||
11 | //config: help | 11 | //config: help |
12 | //config: Performs some ioctls with block devices. | 12 | //config: Performs some ioctls with block devices. |
13 | 13 | ||
14 | //applet:IF_BLOCKDEV(APPLET(blockdev, BB_DIR_SBIN, BB_SUID_DROP)) | 14 | //applet:IF_BLOCKDEV(APPLET_NOEXEC(blockdev, blockdev, BB_DIR_SBIN, BB_SUID_DROP, blockdev)) |
15 | 15 | ||
16 | //kbuild:lib-$(CONFIG_BLOCKDEV) += blockdev.o | 16 | //kbuild:lib-$(CONFIG_BLOCKDEV) += blockdev.o |
17 | 17 | ||
diff --git a/util-linux/fsfreeze.c b/util-linux/fsfreeze.c index 5c10c8044..c1f31569f 100644 --- a/util-linux/fsfreeze.c +++ b/util-linux/fsfreeze.c | |||
@@ -13,7 +13,7 @@ | |||
13 | //config: help | 13 | //config: help |
14 | //config: Halt new accesses and flush writes on a mounted filesystem. | 14 | //config: Halt new accesses and flush writes on a mounted filesystem. |
15 | 15 | ||
16 | //applet:IF_FSFREEZE(APPLET(fsfreeze, BB_DIR_USR_SBIN, BB_SUID_DROP)) | 16 | //applet:IF_FSFREEZE(APPLET_NOEXEC(fsfreeze, fsfreeze, BB_DIR_USR_SBIN, BB_SUID_DROP, fsfreeze)) |
17 | 17 | ||
18 | //kbuild:lib-$(CONFIG_FSFREEZE) += fsfreeze.o | 18 | //kbuild:lib-$(CONFIG_FSFREEZE) += fsfreeze.o |
19 | 19 | ||
diff --git a/util-linux/fstrim.c b/util-linux/fstrim.c index 6d0d61d92..49b3ceb72 100644 --- a/util-linux/fstrim.c +++ b/util-linux/fstrim.c | |||
@@ -15,7 +15,7 @@ | |||
15 | //config: help | 15 | //config: help |
16 | //config: Discard unused blocks on a mounted filesystem. | 16 | //config: Discard unused blocks on a mounted filesystem. |
17 | 17 | ||
18 | //applet:IF_FSTRIM(APPLET(fstrim, BB_DIR_SBIN, BB_SUID_DROP)) | 18 | //applet:IF_FSTRIM(APPLET_NOEXEC(fstrim, fstrim, BB_DIR_SBIN, BB_SUID_DROP, fstrim)) |
19 | 19 | ||
20 | //kbuild:lib-$(CONFIG_FSTRIM) += fstrim.o | 20 | //kbuild:lib-$(CONFIG_FSTRIM) += fstrim.o |
21 | 21 | ||
diff --git a/util-linux/mountpoint.c b/util-linux/mountpoint.c index b7f048196..50772533f 100644 --- a/util-linux/mountpoint.c +++ b/util-linux/mountpoint.c | |||
@@ -14,7 +14,7 @@ | |||
14 | //config: help | 14 | //config: help |
15 | //config: mountpoint checks if the directory is a mountpoint. | 15 | //config: mountpoint checks if the directory is a mountpoint. |
16 | 16 | ||
17 | //applet:IF_MOUNTPOINT(APPLET(mountpoint, BB_DIR_BIN, BB_SUID_DROP)) | 17 | //applet:IF_MOUNTPOINT(APPLET_NOEXEC(mountpoint, mountpoint, BB_DIR_BIN, BB_SUID_DROP, mountpoint)) |
18 | 18 | ||
19 | //kbuild:lib-$(CONFIG_MOUNTPOINT) += mountpoint.o | 19 | //kbuild:lib-$(CONFIG_MOUNTPOINT) += mountpoint.o |
20 | 20 | ||