Merge branch 'busybox' into merge

8 files changed, 101 insertions, 59 deletions

diff --git a/shell/ash.c b/shell/ash.c
index 252061dae..690796740 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -1842,15 +1842,16 @@ popstackmark(struct stackmark *mark)
  * part of the block that has been used.
  */
 static void
-growstackblock(void)
+growstackblock(size_t min)
 {
         size_t newlen;
 
         newlen = g_stacknleft * 2;
         if (newlen < g_stacknleft)
                 ash_msg_and_raise_error(bb_msg_memory_exhausted);
-        if (newlen < 128)
-                newlen += 128;
+        min = SHELL_ALIGN(min | 128);
+        if (newlen < min)
+                newlen += min;
 
         if (g_stacknxt == g_stackp->space && g_stackp != &stackbase) {
                 struct stack_block *sp;
@@ -1900,16 +1901,15 @@ static void *
 growstackstr(void)
 {
         size_t len = stackblocksize();
-        growstackblock();
+        growstackblock(0);
         return (char *)stackblock() + len;
 }
 
 static char *
 growstackto(size_t len)
 {
-        while (stackblocksize() < len)
-                growstackblock();
-
+        if (stackblocksize() < len)
+                growstackblock(len);
         return stackblock();
 }
 
@@ -5962,29 +5962,36 @@ stoppedjobs(void)
  * the pipe without forking.
  */
 /* openhere needs this forward reference */
-static void expandhere(union node *arg, int fd);
+static void expandhere(union node *arg);
 static int
 openhere(union node *redir)
 {
+        char *p;
         int pip[2];
         size_t len = 0;
         IF_PLATFORM_MINGW32(struct forkshell fs);
 
         if (pipe(pip) < 0)
                 ash_msg_and_raise_perror("can't create pipe");
-        if (redir->type == NHERE) {
-                len = strlen(redir->nhere.doc->narg.text);
-                if (len <= PIPE_BUF) {
-                        full_write(pip[1], redir->nhere.doc->narg.text, len);
-                        goto out;
-                }
+
+        p = redir->nhere.doc->narg.text;
+        if (redir->type == NXHERE) {
+                expandhere(redir->nhere.doc);
+                p = stackblock();
         }
+
+        len = strlen(p);
+        if (len <= PIPE_BUF) {
+                xwrite(pip[1], p, len);
+                goto out;
+        }
+
 #if ENABLE_PLATFORM_MINGW32
         memset(&fs, 0, sizeof(fs));
         fs.fpid = FS_OPENHERE;
-        fs.n = redir;
         fs.fd[0] = pip[0];
         fs.fd[1] = pip[1];
+        fs.path = p;
         spawn_forkshell(&fs, NULL, NULL, FORK_NOJOB);
 #else
         if (forkshell((struct job *)NULL, (union node *)NULL, FORK_NOJOB) == 0) {
@@ -5995,10 +6002,7 @@ openhere(union node *redir)
                 ignoresig(SIGHUP);  //signal(SIGHUP, SIG_IGN);
                 ignoresig(SIGTSTP); //signal(SIGTSTP, SIG_IGN);
                 signal(SIGPIPE, SIG_DFL);
-                if (redir->type == NHERE)
-                        full_write(pip[1], redir->nhere.doc->narg.text, len);
-                else /* NXHERE */
-                        expandhere(redir->nhere.doc, pip[1]);
+                xwrite(pip[1], p, len);
                 _exit(EXIT_SUCCESS);
         }
 #endif
@@ -6602,26 +6606,6 @@ static struct ifsregion *ifslastp;
 static struct arglist exparg;
 
 /*
- * Our own itoa().
- * cvtnum() is used even if math support is off (to prepare $? values and such).
- */
-static int
-cvtnum(arith_t num)
-{
-        int len;
-
-        /* 32-bit and wider ints require buffer size of bytes*3 (or less) */
-        len = sizeof(arith_t) * 3;
-        /* If narrower: worst case, 1-byte ints: need 5 bytes: "-127<NUL>" */
-        if (sizeof(arith_t) < 4) len += 2;
-
-        expdest = makestrspace(len, expdest);
-        len = fmtstr(expdest, len, ARITH_FMT, num);
-        STADJUST(len, expdest);
-        return len;
-}
-
-/*
  * Break the argument string into pieces based upon IFS and add the
  * strings to the argument list.  The regions of the string to be
  * searched for IFS characters have been stored by recordregion.
@@ -6878,16 +6862,18 @@ preglob(const char *pattern, int flag)
 /*
  * Put a string on the stack.
  */
-static void
+static size_t
 memtodest(const char *p, size_t len, int flags)
 {
         int syntax = flags & EXP_QUOTED ? DQSYNTAX : BASESYNTAX;
         char *q;
+        char *s;
 
         if (!len)
-                return;
+                return 0;
 
         q = makestrspace(len * 2, expdest);
+        s = q;
 
         do {
                 unsigned char c = *p++;
@@ -6906,6 +6892,7 @@ memtodest(const char *p, size_t len, int flags)
         } while (--len);
 
         expdest = q;
+        return q - s;
 }
 
 static size_t
@@ -6917,6 +6904,22 @@ strtodest(const char *p, int flags)
 }
 
 /*
+ * Our own itoa().
+ * cvtnum() is used even if math support is off (to prepare $? values and such).
+ */
+static int
+cvtnum(arith_t num, int flags)
+{
+        /* 32-bit and wider ints require buffer size of bytes*3 (or less) */
+        /* If narrower: worst case, 1-byte ints: need 5 bytes: "-127<NUL>" */
+        int len = (sizeof(arith_t) >= 4) ? sizeof(arith_t) * 3 : sizeof(arith_t) * 3 + 2;
+        char buf[len];
+
+        len = fmtstr(buf, len, ARITH_FMT, num);
+        return memtodest(buf, len, flags);
+}
+
+/*
  * Record the fact that we have to scan this region of the
  * string for IFS characters.
  */
@@ -7225,7 +7228,7 @@ expari(int flag)
         if (flag & QUOTES_ESC)
                 rmescapes(p + 1, 0, NULL);
 
-        len = cvtnum(ash_arith(p + 1));
+        len = cvtnum(ash_arith(p + 1), flag);
 
         if (!(flag & EXP_QUOTED))
                 recordregion(begoff, begoff + len, 0);
@@ -7870,7 +7873,7 @@ varvalue(char *name, int varflags, int flags, int quoted)
                 if (num == 0)
                         return -1;
  numvar:
-                len = cvtnum(num);
+                len = cvtnum(num, flags);
                 goto check_1char_name;
         case '-':
                 expdest = makestrspace(NOPTS, expdest);
@@ -8036,7 +8039,7 @@ evalvar(char *p, int flag)
                 varunset(p, var, 0, 0);
 
         if (subtype == VSLENGTH) {
-                cvtnum(varlen > 0 ? varlen : 0);
+                cvtnum(varlen > 0 ? varlen : 0, flag);
                 goto record;
         }
 
@@ -8567,10 +8570,9 @@ expandarg(union node *arg, struct arglist *arglist, int flag)
  * Expand shell variables and backquotes inside a here document.
  */
 static void
-expandhere(union node *arg, int fd)
+expandhere(union node *arg)
 {
         expandarg(arg, (struct arglist *)NULL, EXP_QUOTED);
-        full_write(fd, stackblock(), expdest - (char *)stackblock());
 }
 
 /*
@@ -12331,7 +12333,7 @@ list(int nlflag)
 
         n1 = NULL;
         for (;;) {
-                switch (peektoken()) {
+                switch (readtoken()) {
                 case TNL:
                         if (!(nlflag & 1))
                                 break;
@@ -12342,9 +12344,12 @@ list(int nlflag)
                         if (!n1 && (nlflag & 1))
                                 n1 = NODE_EOF;
                         parseheredoc();
+                        tokpushback++;
+                        lasttoken = TEOF;
                         return n1;
                 }
 
+                tokpushback++;
                 checkkwd = CHKNL | CHKKWD | CHKALIAS;
                 if (nlflag == 2 && ((1 << peektoken()) & tokendlist))
                         return n1;
@@ -13601,9 +13606,9 @@ parsebackq: {
                 if (readtoken() != TRP)
                         raise_error_unexpected_syntax(TRP);
                 setinputstring(nullstr);
-                parseheredoc();
         }
 
+        parseheredoc();
         heredoclist = saveheredoclist;
 
         (*nlpp)->n = n;
@@ -15473,7 +15478,8 @@ int ash_main(int argc UNUSED_PARAM, char **argv)
 static void
 forkshell_openhere(struct forkshell *fs)
 {
-        union node *redir = fs->n;
+        const char *p = fs->path;
+        size_t len = strlen(p);
         int pip[2];
 
         pip[0] = fs->fd[0];
@@ -15487,11 +15493,7 @@ forkshell_openhere(struct forkshell *fs)
         ignoresig(SIGHUP);  //signal(SIGHUP, SIG_IGN);
         ignoresig(SIGTSTP); //signal(SIGTSTP, SIG_IGN);
         signal(SIGPIPE, SIG_DFL);
-        if (redir->type == NHERE) {
-                size_t len = strlen(redir->nhere.doc->narg.text);
-                full_write(pip[1], redir->nhere.doc->narg.text, len);
-        } else /* NXHERE */
-                expandhere(redir->nhere.doc, pip[1]);
+        xwrite(pip[1], p, len);
         _exit(EXIT_SUCCESS);
 }
 
diff --git a/shell/ash_test/ash-heredoc/heredoc_side_effects.right b/shell/ash_test/ash-heredoc/heredoc_side_effects.right
new file mode 100644
index 000000000..53b2c03c1
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc_side_effects.right
@@ -0,0 +1 @@
+NO BUG
diff --git a/shell/ash_test/ash-heredoc/heredoc_side_effects.tests b/shell/ash_test/ash-heredoc/heredoc_side_effects.tests
new file mode 100755
index 000000000..3fb622ae4
--- /dev/null
+++ b/shell/ash_test/ash-heredoc/heredoc_side_effects.tests
@@ -0,0 +1,5 @@
+unset a
+cat <<EOF >/dev/null
+${a=NO}
+EOF
+echo $a BUG
diff --git a/shell/ash_test/ash-quoting/negative_arith.right b/shell/ash_test/ash-quoting/negative_arith.right
new file mode 100644
index 000000000..e7e51eee7
--- /dev/null
+++ b/shell/ash_test/ash-quoting/negative_arith.right
@@ -0,0 +1,2 @@
+tempfile0.tmp tempfile9.tmp
+tempfile0.tmp tempfile1.tmp tempfile9.tmp
diff --git a/shell/ash_test/ash-quoting/negative_arith.tests b/shell/ash_test/ash-quoting/negative_arith.tests
new file mode 100755
index 000000000..8e47ca111
--- /dev/null
+++ b/shell/ash_test/ash-quoting/negative_arith.tests
@@ -0,0 +1,8 @@
+>tempfile0.tmp
+>tempfile1.tmp
+>tempfile9.tmp
+# The [...] is interpreted as: "any of the chars 0, -, and 9"
+echo tempfile[0"$((-9))"].tmp
+# The [...] is [0-9], interpreted as: "any digit"
+echo tempfile[0$((-9))].tmp
+rm tempfile?.tmp
diff --git a/shell/hush.c b/shell/hush.c
index 357a354e2..0a92f5da7 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -3007,7 +3007,10 @@ static void x_mode_flush(void)
 static void o_addqchr(o_string *o, int ch)
 {
         int sz = 1;
-        char *found = strchr("*?[\\" MAYBE_BRACES, ch);
+        /* '-' is included because of this case:
+         * >filename0 >filename1 >filename9; v='-'; echo filename[0"$v"9]
+         */
+        char *found = strchr("*?[-\\" MAYBE_BRACES, ch);
         if (found)
                 sz++;
         o_grow_by(o, sz);
@@ -3024,7 +3027,7 @@ static void o_addQchr(o_string *o, int ch)
 {
         int sz = 1;
         if ((o->o_expflags & EXP_FLAG_ESC_GLOB_CHARS)
-         && strchr("*?[\\" MAYBE_BRACES, ch)
+         && strchr("*?[-\\" MAYBE_BRACES, ch)
         ) {
                 sz++;
                 o->data[o->length] = '\\';
@@ -3041,7 +3044,7 @@ static void o_addqblock(o_string *o, const char *str, int len)
         while (len) {
                 char ch;
                 int sz;
-                int ordinary_cnt = strcspn(str, "*?[\\" MAYBE_BRACES);
+                int ordinary_cnt = strcspn(str, "*?[-\\" MAYBE_BRACES);
                 if (ordinary_cnt > len) /* paranoia */
                         ordinary_cnt = len;
                 o_addblock(o, str, ordinary_cnt);
@@ -3052,7 +3055,7 @@ static void o_addqblock(o_string *o, const char *str, int len)
 
                 ch = *str++;
                 sz = 1;
-                if (ch) { /* it is necessarily one of "*?[\\" MAYBE_BRACES */
+                if (ch) { /* it is necessarily one of "*?[-\\" MAYBE_BRACES */
                         sz++;
                         o->data[o->length] = '\\';
                         o->length++;
@@ -5049,7 +5052,7 @@ static int parse_dollar(o_string *as_string,
                         ch = i_getch(input);
                         nommu_addchr(as_string, ch);
                         o_addchr(dest, SPECIAL_VAR_SYMBOL);
-                        o_addchr(dest, /*quote_mask |*/ '+');
+                        o_addchr(dest, quote_mask | '+');
                         if (!BB_MMU)
                                 pos = dest->length;
                         if (!add_till_closing_bracket(dest, input, ')' | DOUBLE_CLOSE_CHAR_FLAG))
@@ -6851,6 +6854,17 @@ static NOINLINE int expand_vars_to_list(o_string *output, int n, char *arg)
                         res = expand_and_evaluate_arith(arg, NULL);
                         debug_printf_subst("ARITH RES '"ARITH_FMT"'\n", res);
                         sprintf(arith_buf, ARITH_FMT, res);
+                        if (res < 0
+                         && first_ch == (char)('+'|0x80)
+                        /* && (output->o_expflags & EXP_FLAG_ESC_GLOB_CHARS) */
+                        ) {
+                                /* Quoted negative ariths, like filename[0"$((-9))"],
+                                 * should not be interpreted as glob ranges.
+                                 * Convert leading '-' to '\-':
+                                 */
+                                o_grow_by(output, 1);
+                                output->data[output->length++] = '\\';
+                        }
                         o_addstr(output, arith_buf);
                         break;
                 }
diff --git a/shell/hush_test/hush-quoting/negative_arith.right b/shell/hush_test/hush-quoting/negative_arith.right
new file mode 100644
index 000000000..e7e51eee7
--- /dev/null
+++ b/shell/hush_test/hush-quoting/negative_arith.right
@@ -0,0 +1,2 @@
+tempfile0.tmp tempfile9.tmp
+tempfile0.tmp tempfile1.tmp tempfile9.tmp
diff --git a/shell/hush_test/hush-quoting/negative_arith.tests b/shell/hush_test/hush-quoting/negative_arith.tests
new file mode 100755
index 000000000..8e47ca111
--- /dev/null
+++ b/shell/hush_test/hush-quoting/negative_arith.tests
@@ -0,0 +1,8 @@
+>tempfile0.tmp
+>tempfile1.tmp
+>tempfile9.tmp
+# The [...] is interpreted as: "any of the chars 0, -, and 9"
+echo tempfile[0"$((-9))"].tmp
+# The [...] is [0-9], interpreted as: "any digit"
+echo tempfile[0$((-9))].tmp
+rm tempfile?.tmp