aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorManuel Novoa III <mjn3@codepoet.org>2003-03-19 18:09:03 +0000
committerManuel Novoa III <mjn3@codepoet.org>2003-03-19 18:09:03 +0000
commitea4c43445c1fcb378b80216ef388eebc61a57696 (patch)
tree01295b8a4b3f31ff3684c0dbc61c6e4182d31466
parent1cb1b64c35a9356575dc7c0e6125805c5ea62cf9 (diff)
downloadbusybox-w32-ea4c43445c1fcb378b80216ef388eebc61a57696.tar.gz
busybox-w32-ea4c43445c1fcb378b80216ef388eebc61a57696.tar.bz2
busybox-w32-ea4c43445c1fcb378b80216ef388eebc61a57696.zip
Restrict octal perms to <= 07777. Cosmetic error message change.
-rw-r--r--coreutils/chmod.c2
-rw-r--r--libbb/parse_mode.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/coreutils/chmod.c b/coreutils/chmod.c
index 28c98552a..a9758d58b 100644
--- a/coreutils/chmod.c
+++ b/coreutils/chmod.c
@@ -38,7 +38,7 @@
38static int fileAction(const char *fileName, struct stat *statbuf, void* junk) 38static int fileAction(const char *fileName, struct stat *statbuf, void* junk)
39{ 39{
40 if (!bb_parse_mode((char *)junk, &(statbuf->st_mode))) 40 if (!bb_parse_mode((char *)junk, &(statbuf->st_mode)))
41 bb_error_msg_and_die( "unknown mode: %s", (char *)junk); 41 bb_error_msg_and_die( "invalid mode: %s", (char *)junk);
42 if (chmod(fileName, statbuf->st_mode) == 0) 42 if (chmod(fileName, statbuf->st_mode) == 0)
43 return (TRUE); 43 return (TRUE);
44 bb_perror_msg("%s", fileName); /* Avoid multibyte problems. */ 44 bb_perror_msg("%s", fileName); /* Avoid multibyte problems. */
diff --git a/libbb/parse_mode.c b/libbb/parse_mode.c
index 49573dfbb..7132c76ef 100644
--- a/libbb/parse_mode.c
+++ b/libbb/parse_mode.c
@@ -65,7 +65,7 @@ extern int bb_parse_mode(const char *s, mode_t *current_mode)
65 char *e; 65 char *e;
66 66
67 tmp = strtol(s, &e, 8); 67 tmp = strtol(s, &e, 8);
68 if (*e || (tmp > 0xffffU)) { /* Check range and trailing chars. */ 68 if (*e || (tmp > 07777U)) { /* Check range and trailing chars. */
69 return 0; 69 return 0;
70 } 70 }
71 *current_mode = tmp; 71 *current_mode = tmp;