diff options
author | vapier <vapier@69ca8d6d-28ef-0310-b511-8ec308f3f277> | 2006-03-23 02:07:20 +0000 |
---|---|---|
committer | vapier <vapier@69ca8d6d-28ef-0310-b511-8ec308f3f277> | 2006-03-23 02:07:20 +0000 |
commit | f8148b756b36b8d3156b400c5efc0713905fe72e (patch) | |
tree | 4a748b7660c089bc78da852352e90ac10a3cf15c | |
parent | 04ad71f3301e675b89a399275cc08b30425f756f (diff) | |
download | busybox-w32-f8148b756b36b8d3156b400c5efc0713905fe72e.tar.gz busybox-w32-f8148b756b36b8d3156b400c5efc0713905fe72e.tar.bz2 busybox-w32-f8148b756b36b8d3156b400c5efc0713905fe72e.zip |
dont printf arguments given by user for security sanity
git-svn-id: svn://busybox.net/trunk/busybox@14613 69ca8d6d-28ef-0310-b511-8ec308f3f277
-rw-r--r-- | coreutils/watch.c | 2 | ||||
-rw-r--r-- | miscutils/mountpoint.c | 2 | ||||
-rw-r--r-- | miscutils/setsid.c | 2 | ||||
-rw-r--r-- | util-linux/fdformat.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/coreutils/watch.c b/coreutils/watch.c index 9da591b48..9e0c54c7f 100644 --- a/coreutils/watch.c +++ b/coreutils/watch.c | |||
@@ -100,7 +100,7 @@ int watch_main(int argc, char **argv) | |||
100 | //child | 100 | //child |
101 | dup2(old_stdout, STDOUT_FILENO); | 101 | dup2(old_stdout, STDOUT_FILENO); |
102 | execvp(*watched_argv, watched_argv); | 102 | execvp(*watched_argv, watched_argv); |
103 | bb_perror_msg_and_die(*watched_argv); | 103 | bb_perror_msg_and_die("%s", *watched_argv); |
104 | } else { | 104 | } else { |
105 | bb_perror_msg_and_die("vfork"); | 105 | bb_perror_msg_and_die("vfork"); |
106 | } | 106 | } |
diff --git a/miscutils/mountpoint.c b/miscutils/mountpoint.c index 38c654c6d..1248dc011 100644 --- a/miscutils/mountpoint.c +++ b/miscutils/mountpoint.c | |||
@@ -64,7 +64,7 @@ int mountpoint_main(int argc, char **argv) | |||
64 | } | 64 | } |
65 | } | 65 | } |
66 | if (!(opt & OPT_q)) | 66 | if (!(opt & OPT_q)) |
67 | bb_perror_msg(arg); | 67 | bb_perror_msg("%s", arg); |
68 | return EXIT_FAILURE; | 68 | return EXIT_FAILURE; |
69 | } | 69 | } |
70 | } | 70 | } |
diff --git a/miscutils/setsid.c b/miscutils/setsid.c index 8061896f5..39be54621 100644 --- a/miscutils/setsid.c +++ b/miscutils/setsid.c | |||
@@ -41,6 +41,6 @@ setsid_main(int argc, char *argv[]) { | |||
41 | 41 | ||
42 | execvp(argv[1], argv + 1); | 42 | execvp(argv[1], argv + 1); |
43 | 43 | ||
44 | bb_perror_msg_and_die(argv[1]); | 44 | bb_perror_msg_and_die("%s", argv[1]); |
45 | 45 | ||
46 | } | 46 | } |
diff --git a/util-linux/fdformat.c b/util-linux/fdformat.c index e7dd943bb..5772e1309 100644 --- a/util-linux/fdformat.c +++ b/util-linux/fdformat.c | |||
@@ -85,7 +85,7 @@ int fdformat_main(int argc,char **argv) | |||
85 | 85 | ||
86 | /* R_OK is needed for verifying */ | 86 | /* R_OK is needed for verifying */ |
87 | if (stat(*argv,&st) < 0 || access(*argv,W_OK | R_OK ) < 0) { | 87 | if (stat(*argv,&st) < 0 || access(*argv,W_OK | R_OK ) < 0) { |
88 | bb_perror_msg_and_die(*argv); | 88 | bb_perror_msg_and_die("%s",*argv); |
89 | } | 89 | } |
90 | if (!S_ISBLK(st.st_mode)) { | 90 | if (!S_ISBLK(st.st_mode)) { |
91 | bb_error_msg_and_die("%s: not a block device",*argv); | 91 | bb_error_msg_and_die("%s: not a block device",*argv); |