aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Vlasenko <vda.linux@googlemail.com>2008-06-24 16:08:22 +0000
committerDenis Vlasenko <vda.linux@googlemail.com>2008-06-24 16:08:22 +0000
commitfe733a974457dae2126edf6b2e2bae594418ad74 (patch)
treed8ac2b8803f32c7abe8b9f9d84e43a9a373e5d59
parent70685bd022855c858682c51da95a07336505536d (diff)
downloadbusybox-w32-fe733a974457dae2126edf6b2e2bae594418ad74.tar.gz
busybox-w32-fe733a974457dae2126edf6b2e2bae594418ad74.tar.bz2
busybox-w32-fe733a974457dae2126edf6b2e2bae594418ad74.zip
changes in comments only
-rw-r--r--libbb/read.c4
-rw-r--r--modutils/insmod.c13
2 files changed, 10 insertions, 7 deletions
diff --git a/libbb/read.c b/libbb/read.c
index fb903c18a..fa9874d31 100644
--- a/libbb/read.c
+++ b/libbb/read.c
@@ -203,8 +203,8 @@ ssize_t open_read_close(const char *filename, void *buf, size_t size)
203 return read_close(fd, buf, size); 203 return read_close(fd, buf, size);
204} 204}
205 205
206// Read (potentially big) files in one go. File size is estimated by 206// Read (potentially big) files in one go. File size is estimated
207// lseek to end. 207// by stat.
208void *xmalloc_open_read_close(const char *filename, size_t *sizep) 208void *xmalloc_open_read_close(const char *filename, size_t *sizep)
209{ 209{
210 char *buf; 210 char *buf;
diff --git a/modutils/insmod.c b/modutils/insmod.c
index f45a59465..3fbb02b75 100644
--- a/modutils/insmod.c
+++ b/modutils/insmod.c
@@ -4235,12 +4235,15 @@ static int insmod_ng_main(int argc ATTRIBUTE_UNUSED, char **argv)
4235 } 4235 }
4236 4236
4237#if 0 4237#if 0
4238 /* Any special reason why mmap? It isn't performace critical... */ 4238 /* Any special reason why mmap? It isn't performance critical. -vda */
4239 4239 /* Yes, xmalloc'ing can use *alot* of RAM. Don't forget that there are
4240 /* yes, xmalloc'ing can use *alot* of RAM. Don't forget that there are
4241 * modules out there that are half a megabyte! mmap()ing is way nicer 4240 * modules out there that are half a megabyte! mmap()ing is way nicer
4242 * for small mem boxes, i guess. 4241 * for small mem boxes, i guess. */
4243 */ 4242 /* But after load, these modules will take up that 0.5mb in kernel
4243 * anyway. Using malloc here causes only a transient spike to 1mb,
4244 * after module is loaded, we go back to normal 0.5mb usage
4245 * (in kernel). Also, mmap isn't magic - when we touch mapped data,
4246 * we use memory. -vda */
4244 int fd; 4247 int fd;
4245 struct stat st; 4248 struct stat st;
4246 unsigned long len; 4249 unsigned long len;