Steve Grubb writes:

Hello,

I found and patched 2 more bugs. The first is a misplaced semi-colon. The second
one is a buffer overflow. I doubt the buffer overflow is triggered in real life.
But you never know what those wily hackers are up to.

Thanks,
Steve Grubb


git-svn-id: svn://busybox.net/trunk/busybox@8804 69ca8d6d-28ef-0310-b511-8ec308f3f277

1 files changed, 2 insertions, 2 deletions

diff --git a/archival/tar.c b/archival/tar.c
index 9d50a101d..efdc46587 100644
--- a/archival/tar.c
+++ b/archival/tar.c
@@ -477,8 +477,8 @@ static inline int writeTarFile(const int tar_fd, const int verboseFlag,
                         dup2(gzipDataPipe[0], 0);
                         close(gzipDataPipe[1]);
 
-                        if (tbInfo.tarFd != 1);
-                        dup2(tbInfo.tarFd, 1);
+                        if (tbInfo.tarFd != 1)
+                                dup2(tbInfo.tarFd, 1);
 
                         close(gzipStatusPipe[0]);
                         fcntl(gzipStatusPipe[1], F_SETFD, FD_CLOEXEC);  /* close on exec shows sucess */