diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-07 17:02:46 +0200 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-07 17:02:46 +0200 |
| commit | 085f19cdffd653013b1483c08851ecc35cdd818e (patch) | |
| tree | 79136e38f3097183f51c0a0e890fdc4180bf6777 /coreutils | |
| parent | 2496616b0a8d1c80cd1416b73a4847b59b9f969a (diff) | |
| download | busybox-w32-085f19cdffd653013b1483c08851ecc35cdd818e.tar.gz busybox-w32-085f19cdffd653013b1483c08851ecc35cdd818e.tar.bz2 busybox-w32-085f19cdffd653013b1483c08851ecc35cdd818e.zip | |
uudecode: fix possible signed char bug
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'coreutils')
| -rw-r--r-- | coreutils/uudecode.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c index dc8ef5cca..5b2edd649 100644 --- a/coreutils/uudecode.c +++ b/coreutils/uudecode.c | |||
| @@ -110,9 +110,7 @@ static void FAST_FUNC read_stduu(FILE *src_stream, FILE *dst_stream, int flags U | |||
| 110 | } | 110 | } |
| 111 | bb_simple_error_msg_and_die("short file"); | 111 | bb_simple_error_msg_and_die("short file"); |
| 112 | } | 112 | } |
| 113 | #endif | ||
| 114 | 113 | ||
| 115 | #if ENABLE_UUDECODE | ||
| 116 | int uudecode_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 114 | int uudecode_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
| 117 | int uudecode_main(int argc UNUSED_PARAM, char **argv) | 115 | int uudecode_main(int argc UNUSED_PARAM, char **argv) |
| 118 | { | 116 | { |
| @@ -202,10 +200,10 @@ int base64_main(int argc UNUSED_PARAM, char **argv) | |||
| 202 | *--argv = (char*)"-"; | 200 | *--argv = (char*)"-"; |
| 203 | src_stream = xfopen_stdin(argv[0]); | 201 | src_stream = xfopen_stdin(argv[0]); |
| 204 | if (opts) { | 202 | if (opts) { |
| 205 | read_base64(src_stream, stdout, /*flags:*/ (char)EOF); | 203 | read_base64(src_stream, stdout, /*flags:*/ (unsigned char)EOF); |
| 206 | } else { | 204 | } else { |
| 207 | enum { | 205 | enum { |
| 208 | SRC_BUF_SIZE = 76/4*3, /* This *MUST* be a multiple of 3 */ | 206 | SRC_BUF_SIZE = 76 / 4 * 3, /* this *MUST* be a multiple of 3 */ |
| 209 | DST_BUF_SIZE = 4 * ((SRC_BUF_SIZE + 2) / 3), | 207 | DST_BUF_SIZE = 4 * ((SRC_BUF_SIZE + 2) / 3), |
| 210 | }; | 208 | }; |
| 211 | char src_buf[SRC_BUF_SIZE]; | 209 | char src_buf[SRC_BUF_SIZE]; |
