diff options
| author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2016-11-22 00:19:51 +0200 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2016-11-24 11:40:36 +0100 |
| commit | cb810c48c036f50c19b08df7e161cdb0550a2abd (patch) | |
| tree | fe18bf724cb5c53ae9861e778bbf6db1bce712f6 /editors | |
| parent | 2eff59667d3c590f27ee39cd0969b2221af739a0 (diff) | |
| download | busybox-w32-cb810c48c036f50c19b08df7e161cdb0550a2abd.tar.gz busybox-w32-cb810c48c036f50c19b08df7e161cdb0550a2abd.tar.bz2 busybox-w32-cb810c48c036f50c19b08df7e161cdb0550a2abd.zip | |
patch: fix matching failure
Fix matching failure when plist is advanced while checking for buffered
lines - the lines in the hunk that are about to be added should be
skipped when checking for matching context.
Also add a valid test case that fails with current busybox and is fixed
by the change.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'editors')
| -rw-r--r-- | editors/patch.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/editors/patch.c b/editors/patch.c index 4ee9339a7..ea1fc0974 100644 --- a/editors/patch.c +++ b/editors/patch.c | |||
| @@ -290,6 +290,17 @@ static int apply_one_hunk(void) | |||
| 290 | // out of buffer. | 290 | // out of buffer. |
| 291 | 291 | ||
| 292 | for (;;) { | 292 | for (;;) { |
| 293 | while (plist && *plist->data == "+-"[reverse]) { | ||
| 294 | if (!strcmp(check->data, plist->data+1) && | ||
| 295 | !backwarn) { | ||
| 296 | backwarn = TT.linenum; | ||
| 297 | if (option_mask32 & FLAG_IGNORE) { | ||
| 298 | dummy_revert = 1; | ||
| 299 | reverse ^= 1; | ||
| 300 | } | ||
| 301 | } | ||
| 302 | plist = plist->next; | ||
| 303 | } | ||
| 293 | if (!plist || strcmp(check->data, plist->data+1)) { | 304 | if (!plist || strcmp(check->data, plist->data+1)) { |
| 294 | // Match failed. Write out first line of buffered data and | 305 | // Match failed. Write out first line of buffered data and |
| 295 | // recheck remaining buffered data for a new match. | 306 | // recheck remaining buffered data for a new match. |
