ps: obtain applet names from other BusyBox processes

Remove the code which passed applet names to child processes using
environment variables.  This only allowed ps to display names for
its ancestors.

Instead attempt to read applet names from the memory of unrelated
processes.

The Microsoft documentation alone wasn't enough to figure out how
to do this.  Additional hints from:

  https://stackoverflow.com/questions/4298331/exe-or-dll-image-base-address
  https://stackoverflow.com/questions/14467229/get-base-address-of-process

1 files changed, 8 insertions, 11 deletions

diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index 1488d4bd6..3e740363a 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -796,13 +796,6 @@ static void install_links(const char *busybox UNUSED_PARAM,
 
 static void run_applet_and_exit(const char *name, char **argv) NORETURN;
 
-#if ENABLE_PLATFORM_MINGW32
-char *bb_applet_pid(void)
-{
-        return auto_string(xasprintf("BB_APPLET_%d=%s", getpid(), applet_name));
-}
-#endif
-
 # if ENABLE_BUSYBOX
 #  if ENABLE_FEATURE_SH_STANDALONE && ENABLE_FEATURE_TAB_COMPLETION
     /*
@@ -979,6 +972,11 @@ int busybox_main(int argc UNUSED_PARAM, char **argv)
 # endif
 
 # if NUM_APPLETS > 0
+
+#  if ENABLE_PLATFORM_MINGW32
+char bb_applet_name[MAX_APPLET_NAME_LEN+1];
+#  endif
+
 void FAST_FUNC run_applet_no_and_exit(int applet_no, const char *name, char **argv)
 {
         int argc = string_array_len(argv);
@@ -988,6 +986,9 @@ void FAST_FUNC run_applet_no_and_exit(int applet_no, const char *name, char **ar
          * "-/sbin/halt" -> "halt", for example.
          */
         applet_name = name;
+#if ENABLE_PLATFORM_MINGW32
+        strcpy(bb_applet_name, applet_name);
+#endif
 
         /* Special case. POSIX says "test --help"
          * should be no different from e.g. "test --foo".
@@ -1014,10 +1015,6 @@ void FAST_FUNC run_applet_no_and_exit(int applet_no, const char *name, char **ar
         if (ENABLE_FEATURE_SUID)
                 check_suid(applet_no);
 
-#if ENABLE_PLATFORM_MINGW32
-        putenv(bb_applet_pid());
-#endif
-
         xfunc_error_retval = applet_main[applet_no](argc, argv);
         /* Note: applet_main() may also not return (die on a xfunc or such) */
         xfunc_die();