diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-05-15 21:30:45 +0000 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-05-15 21:30:45 +0000 |
commit | 6b06cb80be64fcf207bee734cc678c25434ed1a4 (patch) | |
tree | aebc37ae3a2658fba3f57003102fa0dfb1a10ac8 /libbb | |
parent | 43d5d429fd7a80ca02eb8388f058fd9654cc118d (diff) | |
download | busybox-w32-6b06cb80be64fcf207bee734cc678c25434ed1a4.tar.gz busybox-w32-6b06cb80be64fcf207bee734cc678c25434ed1a4.tar.bz2 busybox-w32-6b06cb80be64fcf207bee734cc678c25434ed1a4.zip |
more of -Wall fixes from Cristian Ionescu-Idbohrn.
Some are fixing real bugs.
function old new delta
syslogd_main 938 958 +20
get_signum 136 143 +7
obj_load 777 782 +5
recv_from_to 210 214 +4
get_next_block 1795 1799 +4
display_topmem_process_list 1117 1121 +4
logread_main 484 487 +3
buffer_fill_and_print 73 76 +3
kill_main 687 689 +2
ll_remember_index 240 241 +1
do_stats 452 453 +1
if_readconf 166 165 -1
display_process_list 1192 1191 -1
run_applet_and_exit 507 505 -2
print_signames 33 31 -2
parse_one_line 1092 1090 -2
find_out_spec 57 55 -2
add_ksymoops_symbols 421 419 -2
ash_main 1407 1402 -5
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 11/8 up/down: 54/-17) Total: 37 bytes
Diffstat (limited to 'libbb')
-rw-r--r-- | libbb/appletlib.c | 2 | ||||
-rw-r--r-- | libbb/lineedit.c | 5 | ||||
-rw-r--r-- | libbb/u_signal_names.c | 8 | ||||
-rw-r--r-- | libbb/udp_io.c | 2 |
4 files changed, 9 insertions, 8 deletions
diff --git a/libbb/appletlib.c b/libbb/appletlib.c index 9fe0cf963..3d5aef873 100644 --- a/libbb/appletlib.c +++ b/libbb/appletlib.c | |||
@@ -598,7 +598,7 @@ static void install_links(const char *busybox, int use_symbolic_links) | |||
598 | 598 | ||
599 | int (*lf)(const char *, const char *); | 599 | int (*lf)(const char *, const char *); |
600 | char *fpc; | 600 | char *fpc; |
601 | int i; | 601 | unsigned i; |
602 | int rc; | 602 | int rc; |
603 | 603 | ||
604 | lf = link; | 604 | lf = link; |
diff --git a/libbb/lineedit.c b/libbb/lineedit.c index 62dcc55cd..9c802a35f 100644 --- a/libbb/lineedit.c +++ b/libbb/lineedit.c | |||
@@ -199,7 +199,7 @@ static void cmdedit_set_out_char(int next_char) | |||
199 | { | 199 | { |
200 | bb_putchar(c); | 200 | bb_putchar(c); |
201 | } | 201 | } |
202 | if (++cmdedit_x >= cmdedit_termw) { | 202 | if (++cmdedit_x >= (int)cmdedit_termw) { |
203 | /* terminal is scrolled down */ | 203 | /* terminal is scrolled down */ |
204 | cmdedit_y++; | 204 | cmdedit_y++; |
205 | cmdedit_x = 0; | 205 | cmdedit_x = 0; |
@@ -861,7 +861,8 @@ static void input_tab(smallint *lastWasTab) | |||
861 | exe_n_cwd_tab_completion(matchBuf, find_type); | 861 | exe_n_cwd_tab_completion(matchBuf, find_type); |
862 | /* Sort, then remove any duplicates found */ | 862 | /* Sort, then remove any duplicates found */ |
863 | if (matches) { | 863 | if (matches) { |
864 | int i, n = 0; | 864 | unsigned i; |
865 | int n = 0; | ||
865 | qsort_string_vector(matches, num_matches); | 866 | qsort_string_vector(matches, num_matches); |
866 | for (i = 0; i < num_matches - 1; ++i) { | 867 | for (i = 0; i < num_matches - 1; ++i) { |
867 | if (matches[i] && matches[i+1]) { /* paranoia */ | 868 | if (matches[i] && matches[i+1]) { /* paranoia */ |
diff --git a/libbb/u_signal_names.c b/libbb/u_signal_names.c index 7a0f75d6f..1dcbf5f2d 100644 --- a/libbb/u_signal_names.c +++ b/libbb/u_signal_names.c | |||
@@ -123,14 +123,14 @@ static const char signals[][7] = { | |||
123 | 123 | ||
124 | int get_signum(const char *name) | 124 | int get_signum(const char *name) |
125 | { | 125 | { |
126 | int i; | 126 | unsigned i; |
127 | 127 | ||
128 | i = bb_strtou(name, NULL, 10); | 128 | i = bb_strtou(name, NULL, 10); |
129 | if (!errno) | 129 | if (!errno) |
130 | return i; | 130 | return i; |
131 | if (strncasecmp(name, "SIG", 3) == 0) | 131 | if (strncasecmp(name, "SIG", 3) == 0) |
132 | name += 3; | 132 | name += 3; |
133 | for (i = 0; (size_t)i < ARRAY_SIZE(signals); i++) | 133 | for (i = 0; i < ARRAY_SIZE(signals); i++) |
134 | if (strcasecmp(name, signals[i]) == 0) | 134 | if (strcasecmp(name, signals[i]) == 0) |
135 | return i; | 135 | return i; |
136 | 136 | ||
@@ -170,9 +170,9 @@ const char *get_signame(int number) | |||
170 | 170 | ||
171 | void print_signames(void) | 171 | void print_signames(void) |
172 | { | 172 | { |
173 | int signo; | 173 | unsigned signo; |
174 | 174 | ||
175 | for (signo = 1; (size_t)signo < ARRAY_SIZE(signals); signo++) { | 175 | for (signo = 1; signo < ARRAY_SIZE(signals); signo++) { |
176 | const char *name = signals[signo]; | 176 | const char *name = signals[signo]; |
177 | if (name[0]) | 177 | if (name[0]) |
178 | puts(name); | 178 | puts(name); |
diff --git a/libbb/udp_io.c b/libbb/udp_io.c index e968ecb66..689c39a82 100644 --- a/libbb/udp_io.c +++ b/libbb/udp_io.c | |||
@@ -113,7 +113,7 @@ recv_from_to(int fd, void *buf, size_t len, int flags, | |||
113 | } u; | 113 | } u; |
114 | struct cmsghdr *cmsgptr; | 114 | struct cmsghdr *cmsgptr; |
115 | struct msghdr msg; | 115 | struct msghdr msg; |
116 | socklen_t recv_length; | 116 | ssize_t recv_length; |
117 | 117 | ||
118 | iov[0].iov_base = buf; | 118 | iov[0].iov_base = buf; |
119 | iov[0].iov_len = len; | 119 | iov[0].iov_len = len; |