Terminate source correctly when copying symlink. Report and patch by

Brian Webb <webbb@desertscenes.net>.


git-svn-id: svn://busybox.net/trunk/busybox@2478 69ca8d6d-28ef-0310-b511-8ec308f3f277

1 files changed, 3 insertions, 2 deletions

diff --git a/libbb/copy_file.c b/libbb/copy_file.c
index 4ee3efdbc..6c220022f 100644
--- a/libbb/copy_file.c
+++ b/libbb/copy_file.c
@@ -200,13 +200,14 @@ int copy_file(const char *source, const char *dest, int flags)
 
                 umask(saved_umask);
         } else if (S_ISLNK(source_stat.st_mode)) {
+                int size;
                 char buf[BUFSIZ + 1];
 
-                if (readlink(source, buf, BUFSIZ) < 0) {
+                if ((size = readlink(source, buf, BUFSIZ)) < 0) {
                         perror_msg("cannot read `%s'", source);
                         return -1;
                 }
-                buf[BUFSIZ] = '\0';
+                buf[size] = '\0';
 
                 if (symlink(buf, dest) < 0) {
                         perror_msg("cannot create symlink `%s'", dest);