aboutsummaryrefslogtreecommitdiff
path: root/loginutils
diff options
context:
space:
mode:
authorRon Yorston <rmy@pobox.com>2019-08-16 09:42:39 +0100
committerRon Yorston <rmy@pobox.com>2019-08-16 09:45:21 +0100
commit517cf74f6265ec4308b790b637b3f9778cbdc6e0 (patch)
treebe9337069b60ca1bb03565d8575bacfc71181003 /loginutils
parentae65dc37bcc9b1d9cef0b111131c79dc4ba1bf51 (diff)
parentac78f2ac96b3efd6551a08e7dc609efa1fb69481 (diff)
downloadbusybox-w32-517cf74f6265ec4308b790b637b3f9778cbdc6e0.tar.gz
busybox-w32-517cf74f6265ec4308b790b637b3f9778cbdc6e0.tar.bz2
busybox-w32-517cf74f6265ec4308b790b637b3f9778cbdc6e0.zip
Merge branch 'busybox' into merge
Diffstat (limited to 'loginutils')
-rw-r--r--loginutils/addgroup.c2
-rw-r--r--loginutils/adduser.c4
-rw-r--r--loginutils/chpasswd.c4
-rw-r--r--loginutils/deluser.c2
-rw-r--r--loginutils/getty.c16
-rw-r--r--loginutils/login.c4
-rw-r--r--loginutils/su.c4
-rw-r--r--loginutils/sulogin.c8
8 files changed, 22 insertions, 22 deletions
diff --git a/loginutils/addgroup.c b/loginutils/addgroup.c
index baa961ff3..2a83c8a15 100644
--- a/loginutils/addgroup.c
+++ b/loginutils/addgroup.c
@@ -149,7 +149,7 @@ int addgroup_main(int argc UNUSED_PARAM, char **argv)
149 149
150 /* need to be root */ 150 /* need to be root */
151 if (geteuid()) { 151 if (geteuid()) {
152 bb_error_msg_and_die(bb_msg_perm_denied_are_you_root); 152 bb_simple_error_msg_and_die(bb_msg_perm_denied_are_you_root);
153 } 153 }
154 /* Syntax: 154 /* Syntax:
155 * addgroup group 155 * addgroup group
diff --git a/loginutils/adduser.c b/loginutils/adduser.c
index 850c810c4..d3c795afa 100644
--- a/loginutils/adduser.c
+++ b/loginutils/adduser.c
@@ -159,7 +159,7 @@ static void passwd_wrapper(const char *login_name) NORETURN;
159static void passwd_wrapper(const char *login_name) 159static void passwd_wrapper(const char *login_name)
160{ 160{
161 BB_EXECLP("passwd", "passwd", "--", login_name, NULL); 161 BB_EXECLP("passwd", "passwd", "--", login_name, NULL);
162 bb_error_msg_and_die("can't execute passwd, you must set password manually"); 162 bb_simple_error_msg_and_die("can't execute passwd, you must set password manually");
163} 163}
164 164
165//FIXME: upstream adduser has no short options! NOT COMPATIBLE! 165//FIXME: upstream adduser has no short options! NOT COMPATIBLE!
@@ -193,7 +193,7 @@ int adduser_main(int argc UNUSED_PARAM, char **argv)
193 193
194 /* got root? */ 194 /* got root? */
195 if (geteuid()) { 195 if (geteuid()) {
196 bb_error_msg_and_die(bb_msg_perm_denied_are_you_root); 196 bb_simple_error_msg_and_die(bb_msg_perm_denied_are_you_root);
197 } 197 }
198 198
199 pw.pw_gecos = (char *)"Linux User,,,"; 199 pw.pw_gecos = (char *)"Linux User,,,";
diff --git a/loginutils/chpasswd.c b/loginutils/chpasswd.c
index dd0532c66..4e70b2557 100644
--- a/loginutils/chpasswd.c
+++ b/loginutils/chpasswd.c
@@ -63,7 +63,7 @@ int chpasswd_main(int argc UNUSED_PARAM, char **argv)
63 int opt; 63 int opt;
64 64
65 if (getuid() != 0) 65 if (getuid() != 0)
66 bb_error_msg_and_die(bb_msg_perm_denied_are_you_root); 66 bb_simple_error_msg_and_die(bb_msg_perm_denied_are_you_root);
67 67
68 opt = getopt32long(argv, "^" "emc:R:" "\0" "m--ec:e--mc:c--em", 68 opt = getopt32long(argv, "^" "emc:R:" "\0" "m--ec:e--mc:c--em",
69 chpasswd_longopts, 69 chpasswd_longopts,
@@ -81,7 +81,7 @@ int chpasswd_main(int argc UNUSED_PARAM, char **argv)
81 81
82 pass = strchr(name, ':'); 82 pass = strchr(name, ':');
83 if (!pass) 83 if (!pass)
84 bb_error_msg_and_die("missing new password"); 84 bb_simple_error_msg_and_die("missing new password");
85 *pass++ = '\0'; 85 *pass++ = '\0';
86 86
87 xuname2uid(name); /* dies if there is no such user */ 87 xuname2uid(name); /* dies if there is no such user */
diff --git a/loginutils/deluser.c b/loginutils/deluser.c
index d7e9327ba..56bc7eaa6 100644
--- a/loginutils/deluser.c
+++ b/loginutils/deluser.c
@@ -76,7 +76,7 @@ int deluser_main(int argc, char **argv)
76#endif 76#endif
77 77
78 if (geteuid() != 0) 78 if (geteuid() != 0)
79 bb_error_msg_and_die(bb_msg_perm_denied_are_you_root); 79 bb_simple_error_msg_and_die(bb_msg_perm_denied_are_you_root);
80 80
81 name = argv[1]; 81 name = argv[1];
82 member = NULL; 82 member = NULL;
diff --git a/loginutils/getty.c b/loginutils/getty.c
index 23e92bc77..7393a3d1c 100644
--- a/loginutils/getty.c
+++ b/loginutils/getty.c
@@ -168,7 +168,7 @@ static void parse_speeds(char *arg)
168 /* note: arg "0" turns into speed B0 */ 168 /* note: arg "0" turns into speed B0 */
169 G.numspeed++; 169 G.numspeed++;
170 if (G.numspeed > MAX_SPEED) 170 if (G.numspeed > MAX_SPEED)
171 bb_error_msg_and_die("too many alternate speeds"); 171 bb_simple_error_msg_and_die("too many alternate speeds");
172 } 172 }
173 debug("exiting parse_speeds\n"); 173 debug("exiting parse_speeds\n");
174} 174}
@@ -230,7 +230,7 @@ static void open_tty(void)
230 * Make sure it is open for read/write. 230 * Make sure it is open for read/write.
231 */ 231 */
232 if ((fcntl(0, F_GETFL) & (O_RDWR|O_RDONLY|O_WRONLY)) != O_RDWR) 232 if ((fcntl(0, F_GETFL) & (O_RDWR|O_RDONLY|O_WRONLY)) != O_RDWR)
233 bb_error_msg_and_die("stdin is not open for read/write"); 233 bb_simple_error_msg_and_die("stdin is not open for read/write");
234 234
235 /* Try to get real tty name instead of "-" */ 235 /* Try to get real tty name instead of "-" */
236 n = xmalloc_ttyname(0); 236 n = xmalloc_ttyname(0);
@@ -243,7 +243,7 @@ static void open_tty(void)
243static void set_tty_attrs(void) 243static void set_tty_attrs(void)
244{ 244{
245 if (tcsetattr_stdin_TCSANOW(&G.tty_attrs) < 0) 245 if (tcsetattr_stdin_TCSANOW(&G.tty_attrs) < 0)
246 bb_perror_msg_and_die("tcsetattr"); 246 bb_simple_perror_msg_and_die("tcsetattr");
247} 247}
248 248
249/* We manipulate tty_attrs this way: 249/* We manipulate tty_attrs this way:
@@ -485,7 +485,7 @@ static char *get_logname(void)
485 finalize_tty_attrs(); 485 finalize_tty_attrs();
486 if (errno == EINTR || errno == EIO) 486 if (errno == EINTR || errno == EIO)
487 exit(EXIT_SUCCESS); 487 exit(EXIT_SUCCESS);
488 bb_perror_msg_and_die(bb_msg_read_error); 488 bb_simple_perror_msg_and_die(bb_msg_read_error);
489 } 489 }
490 490
491 switch (c) { 491 switch (c) {
@@ -582,7 +582,7 @@ int getty_main(int argc UNUSED_PARAM, char **argv)
582 // " sid %d pgid %d", 582 // " sid %d pgid %d",
583 // pid, getppid(), 583 // pid, getppid(),
584 // getsid(0), getpgid(0)); 584 // getsid(0), getpgid(0));
585 bb_perror_msg_and_die("setsid"); 585 bb_simple_perror_msg_and_die("setsid");
586 /* 586 /*
587 * When we can end up here? 587 * When we can end up here?
588 * Example: setsid() fails when run alone in interactive shell: 588 * Example: setsid() fails when run alone in interactive shell:
@@ -651,13 +651,13 @@ int getty_main(int argc UNUSED_PARAM, char **argv)
651 tsid = tcgetsid(STDIN_FILENO); 651 tsid = tcgetsid(STDIN_FILENO);
652 if (tsid < 0 || pid != tsid) { 652 if (tsid < 0 || pid != tsid) {
653 if (ioctl(STDIN_FILENO, TIOCSCTTY, /*force:*/ (long)1) < 0) 653 if (ioctl(STDIN_FILENO, TIOCSCTTY, /*force:*/ (long)1) < 0)
654 bb_perror_msg_and_die("TIOCSCTTY"); 654 bb_simple_perror_msg_and_die("TIOCSCTTY");
655 } 655 }
656 656
657#ifdef __linux__ 657#ifdef __linux__
658 /* Make ourself a foreground process group within our session */ 658 /* Make ourself a foreground process group within our session */
659 if (tcsetpgrp(STDIN_FILENO, pid) < 0) 659 if (tcsetpgrp(STDIN_FILENO, pid) < 0)
660 bb_perror_msg_and_die("tcsetpgrp"); 660 bb_simple_perror_msg_and_die("tcsetpgrp");
661#endif 661#endif
662 662
663 /* 663 /*
@@ -669,7 +669,7 @@ int getty_main(int argc UNUSED_PARAM, char **argv)
669 * 5 seconds seems to be a good value. 669 * 5 seconds seems to be a good value.
670 */ 670 */
671 if (tcgetattr(STDIN_FILENO, &G.tty_attrs) < 0) 671 if (tcgetattr(STDIN_FILENO, &G.tty_attrs) < 0)
672 bb_perror_msg_and_die("tcgetattr"); 672 bb_simple_perror_msg_and_die("tcgetattr");
673 673
674 /* Update the utmp file. This tty is ours now! */ 674 /* Update the utmp file. This tty is ours now! */
675 update_utmp(pid, LOGIN_PROCESS, G.tty_name, "LOGIN", G.fakehost); 675 update_utmp(pid, LOGIN_PROCESS, G.tty_name, "LOGIN", G.fakehost);
diff --git a/loginutils/login.c b/loginutils/login.c
index a08642a34..4e65b3a19 100644
--- a/loginutils/login.c
+++ b/loginutils/login.c
@@ -358,7 +358,7 @@ int login_main(int argc UNUSED_PARAM, char **argv)
358 opt = getopt32(argv, "f:h:p", &opt_user, &opt_host); 358 opt = getopt32(argv, "f:h:p", &opt_user, &opt_host);
359 if (opt & LOGIN_OPT_f) { 359 if (opt & LOGIN_OPT_f) {
360 if (!run_by_root) 360 if (!run_by_root)
361 bb_error_msg_and_die("-f is for root only"); 361 bb_simple_error_msg_and_die("-f is for root only");
362 safe_strncpy(username, opt_user, sizeof(username)); 362 safe_strncpy(username, opt_user, sizeof(username));
363 } 363 }
364 argv += optind; 364 argv += optind;
@@ -529,7 +529,7 @@ int login_main(int argc UNUSED_PARAM, char **argv)
529 child_pid = vfork(); 529 child_pid = vfork();
530 if (child_pid != 0) { 530 if (child_pid != 0) {
531 if (child_pid < 0) 531 if (child_pid < 0)
532 bb_perror_msg("vfork"); 532 bb_simple_perror_msg("vfork");
533 else { 533 else {
534 wait_for_exitstatus(child_pid); 534 wait_for_exitstatus(child_pid);
535 update_utmp_DEAD_PROCESS(child_pid); 535 update_utmp_DEAD_PROCESS(child_pid);
diff --git a/loginutils/su.c b/loginutils/su.c
index 2e1b309b0..79edbc44a 100644
--- a/loginutils/su.c
+++ b/loginutils/su.c
@@ -148,7 +148,7 @@ int su_main(int argc UNUSED_PARAM, char **argv)
148 syslog(LOG_NOTICE, "%c %s %s:%s", 148 syslog(LOG_NOTICE, "%c %s %s:%s",
149 '-', tty, old_user, opt_username); 149 '-', tty, old_user, opt_username);
150 bb_do_delay(LOGIN_FAIL_DELAY); 150 bb_do_delay(LOGIN_FAIL_DELAY);
151 bb_error_msg_and_die("incorrect password"); 151 bb_simple_error_msg_and_die("incorrect password");
152 } 152 }
153 153
154 if (ENABLE_FEATURE_CLEAN_UP && ENABLE_FEATURE_SU_SYSLOG) { 154 if (ENABLE_FEATURE_CLEAN_UP && ENABLE_FEATURE_SU_SYSLOG) {
@@ -166,7 +166,7 @@ int su_main(int argc UNUSED_PARAM, char **argv)
166 * probably a uucp account or has restricted access. Don't 166 * probably a uucp account or has restricted access. Don't
167 * compromise the account by allowing access with a standard 167 * compromise the account by allowing access with a standard
168 * shell. */ 168 * shell. */
169 bb_error_msg("using restricted shell"); 169 bb_simple_error_msg("using restricted shell");
170 opt_shell = NULL; /* ignore -s PROG */ 170 opt_shell = NULL; /* ignore -s PROG */
171 } 171 }
172 /* else: user can run whatever he wants via "su -s PROG USER". 172 /* else: user can run whatever he wants via "su -s PROG USER".
diff --git a/loginutils/sulogin.c b/loginutils/sulogin.c
index 9bb4d3613..099085340 100644
--- a/loginutils/sulogin.c
+++ b/loginutils/sulogin.c
@@ -56,7 +56,7 @@ int sulogin_main(int argc UNUSED_PARAM, char **argv)
56 56
57 pwd = getpwuid(0); 57 pwd = getpwuid(0);
58 if (!pwd) { 58 if (!pwd) {
59 bb_error_msg_and_die("no password entry for root"); 59 bb_simple_error_msg_and_die("no password entry for root");
60 } 60 }
61 61
62 while (1) { 62 while (1) {
@@ -68,17 +68,17 @@ int sulogin_main(int argc UNUSED_PARAM, char **argv)
68 ); 68 );
69 if (r < 0) { 69 if (r < 0) {
70 /* ^D, ^C, timeout, or read error */ 70 /* ^D, ^C, timeout, or read error */
71 bb_info_msg("normal startup"); 71 bb_simple_info_msg("normal startup");
72 return 0; 72 return 0;
73 } 73 }
74 if (r > 0) { 74 if (r > 0) {
75 break; 75 break;
76 } 76 }
77 bb_do_delay(LOGIN_FAIL_DELAY); 77 bb_do_delay(LOGIN_FAIL_DELAY);
78 bb_info_msg("Login incorrect"); 78 bb_simple_info_msg("Login incorrect");
79 } 79 }
80 80
81 bb_info_msg("starting shell for system maintenance"); 81 bb_simple_info_msg("starting shell for system maintenance");
82 82
83 IF_SELINUX(renew_current_security_context()); 83 IF_SELINUX(renew_current_security_context());
84 84