win32: special treatment for PATH

The PATH shell variable is a special case.  It can be exported to
the environment where it might be interpreted by native applications
which assume the separator is ';'.  Hence:

- require that the separator used in PATH is ';'
- enforce this by intercepting calls to setvareq() that set PATH
  and adjusting its value if necessary.

As a result of this the code to parse PATH can be simplified by
replacing the hardcoded Unix ':' path separator by the platform-
dependent macro PATH_SEP.

The MANPATH variable is also required to use ';' as its separator
but since it's less likely to be used this isn't enforced.

1 files changed, 2 insertions, 15 deletions

diff --git a/miscutils/man.c b/miscutils/man.c
index 567323a88..4ff58a9a0 100644
--- a/miscutils/man.c
+++ b/miscutils/man.c
@@ -199,19 +199,10 @@ static char **add_MANPATH(char **man_path_list, int *count_mp, char *path)
         if (path) while (*path) {
                 char *next_path;
                 char **path_element;
-#if ENABLE_PLATFORM_MINGW32
-                char save;
-
-                next_path = (char *)next_path_sep(path);
-#else
-                next_path = strchr(path, ':');
-#endif
+                next_path = strchr(path, PATH_SEP);
                 if (next_path) {
                         if (next_path == path) /* "::"? */
                                 goto next;
-#if ENABLE_PLATFORM_MINGW32
-                        save = *next_path;
-#endif
                         *next_path = '\0';
                 }
                 /* Do we already have path? */
@@ -230,11 +221,7 @@ static char **add_MANPATH(char **man_path_list, int *count_mp, char *path)
                 if (!next_path)
                         break;
                 /* "path" may be a result of getenv(), be nice and don't mangle it */
-#if ENABLE_PLATFORM_MINGW32
-                *next_path = save;
-#else
-                *next_path = ':';
-#endif
+                *next_path = PATH_SEP;
  next:
                 path = next_path + 1;
         }