httpd: fix return code when run in background

When httpd was run in the background the return code of the parent
process was incorrect.  It seems when spawn() is run in _P_DETACH
mode it returns 0 on success, not a process handle.

Fix the test for the return code and alter mingw_spawn_detach()
so it doesn't treat the return from spawn() as a handle.

Saves 32 bytes.

1 files changed, 1 insertions, 3 deletions

diff --git a/networking/httpd.c b/networking/httpd.c
index 2b2d14076..0de56a47a 100644
--- a/networking/httpd.c
+++ b/networking/httpd.c
@@ -2863,9 +2863,7 @@ static void mingw_daemonize(char **argv)
         xdup2(fd, 2);
         close(fd);
 
-        if (mingw_spawn_detach(new_argv))
-                exit_SUCCESS(); /* parent */
-        exit(EXIT_FAILURE); /* parent */
+        exit(mingw_spawn_detach(new_argv) == -1 ? EXIT_FAILURE : EXIT_SUCCESS);
 }
 #endif