hush: add a TODO about redir3.tests failure

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

1 files changed, 4 insertions, 0 deletions

diff --git a/shell/hush.c b/shell/hush.c
index 0ade2ccca..4ba6b3fdd 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -7723,6 +7723,10 @@ static NOINLINE int run_pipe(struct pipe *pi)
                         unset_vars(new_env);
                         add_vars(old_vars);
 /* clean_up_and_ret0: */
+
+//FIXME: this restores stdio fds, but does not close other redirects!
+//Example: after "echo TEST 9>/dev/null" fd#9 is not closed!
+//The squirreling code needs rework to remember all fds, not just 0,1,2.
                         restore_redirects(squirrel);
  clean_up_and_ret1:
                         free(argv_expanded);